From 2f151dc8f43f58e026849cdec7c28e84ff92b3d4 Mon Sep 17 00:00:00 2001 From: Daniel Ziegenberg Date: Fri, 10 Feb 2023 09:47:12 +0100 Subject: [PATCH] change deprecated parameter pw and db (#177) * change deprecated parameter pw to password * change deprecated parameter db to database * add changelog fragment * Old plugin versions are no longer supported * Use packaging version checking. * Use stdlib version comparison * Use parse_version from setuptools * Revert to tuple/reduce version check --------- Co-authored-by: Jorge-Rodriguez --- .../fragments/177-change_deprecated_connection_parameters.yml | 2 ++ plugins/module_utils/mysql.py | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) create mode 100644 changelogs/fragments/177-change_deprecated_connection_parameters.yml diff --git a/changelogs/fragments/177-change_deprecated_connection_parameters.yml b/changelogs/fragments/177-change_deprecated_connection_parameters.yml new file mode 100644 index 0000000..3c9e088 --- /dev/null +++ b/changelogs/fragments/177-change_deprecated_connection_parameters.yml @@ -0,0 +1,2 @@ +minor_changes: +- mysql module utils - change deprecated connection parameters ``passwd`` and ``db`` to ``password`` and ``database`` (https://github.com/ansible-collections/community.mysql/pull/177). \ No newline at end of file diff --git a/plugins/module_utils/mysql.py b/plugins/module_utils/mysql.py index 2cafcb6..6aeebe5 100644 --- a/plugins/module_utils/mysql.py +++ b/plugins/module_utils/mysql.py @@ -122,7 +122,7 @@ def mysql_connect(module, login_user=None, login_password=None, config_file='', if login_user is not None: config['user'] = login_user if login_password is not None: - config['passwd'] = login_password + config['password'] = login_password if ssl_cert is not None: config['ssl']['cert'] = ssl_cert if ssl_key is not None: @@ -130,7 +130,7 @@ def mysql_connect(module, login_user=None, login_password=None, config_file='', if ssl_ca is not None: config['ssl']['ca'] = ssl_ca if db is not None: - config['db'] = db + config['database'] = db if connect_timeout is not None: config['connect_timeout'] = connect_timeout if check_hostname is not None: