ansible-collections/community.mysql
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.mysql.git synced 2025-04-18 16:31:26 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

fix warning to be displayed only when option is not set by the user

Browse source
This commit is contained in:
Laurent Indermuehle 2023-10-06 14:09:28 +02:00
parent 7e2449813c
commit 2d2e56d13a
No known key found for this signature in database
GPG key ID: 93FA944C9F34DD09
3 changed files with 13 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

12
plugins/modules/mysql_role.py
View file

@ -128,7 +128,6 @@ options:
feature was introduced but since MySQL/MariaDB is case sensitive you should set this
to C(true) in most cases.
type: bool
default: false
version_added: '3.8.0'
notes:
@ -970,7 +969,7 @@ def main():
check_implicit_admin=dict(type='bool', default=False),
set_default_role_all=dict(type='bool', default=True),
members_must_exist=dict(type='bool', default=True),
column_case_sensitive=dict(type='bool', default=False),
column_case_sensitive=dict(type='bool', default=None), # TODO 4.0.0 add default=True
)
module = AnsibleModule(
argument_spec=argument_spec,
@ -1018,6 +1017,11 @@ def main():
if mysql_driver is None:
module.fail_json(msg=mysql_driver_fail_msg)
# TODO Release 4.0.0 : Remove this test and variable assignation
if column_case_sensitive is None:
column_case_sensitive = False
module.warn("Option column_case_sensitive not provided, column's name will be uppercased")
cursor = None
try:
if check_implicit_admin:
@ -1087,10 +1091,6 @@ def main():
try:
if state == 'present':
if not role.exists:
# TODO Release 4.0.0 : Remove this warning or change the message.
if not column_case_sensitive and "(" in str(priv):
module.warn("column_case_sensitive set to False, column's name will be uppercased")
if subtract_privs:
priv = None # avoid granting unwanted privileges
if detach_members: