Handle divergences between MySQL and MariaDB (#103)

* Initial attempt

* First functional approach

* Remove unused imports

* Add dychotomy handling for mysql_replication

* Fix cursor lookup

* Fix sanity tests

* Cleanup implementation conditional import

* Fix unit tests

* Fix conditional import to satisfy both sanity and integration tests

* Add changelog fragment
This commit is contained in:
Jorge Rodriguez (A.K.A. Tiriel) 2021-03-16 10:15:19 +02:00 committed by GitHub
parent a5ee4b3d1a
commit 11958ec46a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
12 changed files with 162 additions and 92 deletions

View file

@ -10,37 +10,10 @@ from ansible_collections.community.mysql.plugins.modules.mysql_user import (
has_grant_on_col,
normalize_col_grants,
sort_column_order,
supports_identified_by_password,
)
from ..utils import dummy_cursor_class
@pytest.mark.parametrize(
'function_return,cursor_output,cursor_ret_type',
[
(True, '5.5.1-mysql', 'list'),
(True, '5.7.0-mysql', 'dict'),
(True, '10.5.0-mariadb', 'dict'),
(True, '10.5.1-mariadb', 'dict'),
(True, '10.6.0-mariadb', 'dict'),
(True, '11.5.1-mariadb', 'dict'),
(False, '8.0.22-mysql', 'list'),
(False, '8.1.2-mysql', 'dict'),
(False, '9.0.0-mysql', 'list'),
(False, '8.0.0-mysql', 'list'),
(False, '8.0.11-mysql', 'dict'),
(False, '8.0.21-mysql', 'list'),
]
)
def test_supports_identified_by_password(function_return, cursor_output, cursor_ret_type):
"""
Tests whether 'CREATE USER %s@%s IDENTIFIED BY PASSWORD %s' is supported,
which is currently supported by everything besides MySQL >= 8.0.
"""
cursor = dummy_cursor_class(cursor_output, cursor_ret_type)
assert supports_identified_by_password(cursor) == function_return
@pytest.mark.parametrize(
'input_list,grant,output_tuple',
[