Embed pymysql within the collection and use default test container

This change eliminates the need to install the connector on each
controlled node, as `pymysql` version 1.1.1 is now included. As a
result, we can safely assume its availability, thus simplifying the
testing process.

Also, I managed to remove the need for pre-built test containers. We
now use the default test containers from ansible-test.

plugins/modules/mysql_db.py

@@ -343,7 +343,7 @@ import traceback
 
 from ansible.module_utils.basic import AnsibleModule
 from ansible_collections.community.mysql.plugins.module_utils.database import mysql_quote_identifier
-from ansible_collections.community.mysql.plugins.module_utils.mysql import mysql_connect, mysql_driver, mysql_driver_fail_msg, mysql_common_argument_spec
+from ansible_collections.community.mysql.plugins.module_utils.mysql import mysql_connect, mysql_driver, mysql_common_argument_spec
 from ansible.module_utils.six.moves import shlex_quote
 from ansible.module_utils._text import to_native
 
@@ -605,9 +605,6 @@ def main():
         supports_check_mode=True,
     )
 
-    if mysql_driver is None:
-        module.fail_json(msg=mysql_driver_fail_msg)
-
     db = module.params["name"]
     if not db:
         module.exit_json(changed=False, db=db, db_list=[])

plugins/modules/mysql_info.py

@@ -268,21 +268,6 @@ slave_hosts:
   type: dict
   sample:
   - { "2": { "Host": "", "Master_id": 1, "Port": 3306 } }
-connector_name:
-  description: Name of the python connector used by the module. When the connector is not identified, returns C(Unknown).
-  returned: always
-  type: str
-  sample:
-  - "pymysql"
-  - "MySQLdb"
-  version_added: '3.6.0'
-connector_version:
-  description: Version of the python connector used by the module. When the connector is not identified, returns C(Unknown).
-  returned: always
-  type: str
-  sample:
-  - "1.0.2"
-  version_added: '3.6.0'
 '''
 
 from decimal import Decimal
@@ -292,9 +277,6 @@ from ansible_collections.community.mysql.plugins.module_utils.mysql import (
     mysql_connect,
     mysql_common_argument_spec,
     mysql_driver,
-    mysql_driver_fail_msg,
-    get_connector_name,
-    get_connector_version,
     get_server_implementation,
 )
 
@@ -739,21 +721,15 @@ def main():
     if exclude_fields:
         exclude_fields = set([f.strip() for f in exclude_fields])
 
-    if mysql_driver is None:
-        module.fail_json(msg=mysql_driver_fail_msg)
-
-    connector_name = get_connector_name(mysql_driver)
-    connector_version = get_connector_version(mysql_driver)
-
     try:
         cursor, db_conn = mysql_connect(module, login_user, login_password,
                                         config_file, ssl_cert, ssl_key, ssl_ca, db,
                                         check_hostname=check_hostname,
                                         connect_timeout=connect_timeout, cursor_class='DictCursor')
     except Exception as e:
-        msg = ('unable to connect to database using %s %s, check login_user '
+        msg = ('unable to connect to database, check login_user '
                'and login_password are correct or %s has the credentials. '
-               'Exception message: %s' % (connector_name, connector_version, config_file, to_native(e)))
+               'Exception message: %s' % (config_file, to_native(e)))
         module.fail_json(msg)
 
     server_implementation = get_server_implementation(cursor)
@@ -765,8 +741,6 @@ def main():
     mysql = MySQL_Info(module, cursor, server_implementation, user_implementation)
 
     module.exit_json(changed=False,
-                     connector_name=connector_name,
-                     connector_version=connector_version,
                      **mysql.get_info(filter_, exclude_fields, return_empty_dbs))
 
 

plugins/modules/mysql_query.py

@@ -26,9 +26,7 @@ options:
       as a formatting character. All literal C(%) characters in the query should be
       escaped as C(%%).
     - Note that if you use the C(IF EXISTS/IF NOT EXISTS) clauses in your query
-      and C(mysqlclient) or C(PyMySQL 0.10.0+) connectors, the module will report
-      that the state has been changed even if it has not. If it is important in your
-      workflow, use the C(PyMySQL 0.9.3) connector instead.
+      the module will report that the state has been changed even if it has not.
     type: raw
     required: true
   positional_args:
@@ -126,7 +124,6 @@ from ansible_collections.community.mysql.plugins.module_utils.mysql import (
     mysql_connect,
     mysql_common_argument_spec,
     mysql_driver,
-    mysql_driver_fail_msg,
 )
 from ansible.module_utils._text import to_native
 
@@ -189,9 +186,6 @@ def main():
     else:
         arguments = None
 
-    if mysql_driver is None:
-        module.fail_json(msg=mysql_driver_fail_msg)
-
     # Connect to DB:
     try:
         cursor, db_connection = mysql_connect(module, login_user, login_password,

plugins/modules/mysql_replication.py

@@ -305,7 +305,6 @@ from ansible_collections.community.mysql.plugins.module_utils.mysql import (
     get_server_implementation,
     mysql_connect,
     mysql_driver,
-    mysql_driver_fail_msg,
     mysql_common_argument_spec,
 )
 from ansible.module_utils._text import to_native
@@ -545,12 +544,6 @@ def main():
     connection_name = module.params["connection_name"]
     channel = module.params['channel']
     fail_on_error = module.params['fail_on_error']
-
-    if mysql_driver is None:
-        module.fail_json(msg=mysql_driver_fail_msg)
-    else:
-        warnings.filterwarnings('error', category=mysql_driver.Warning)
-
     login_password = module.params["login_password"]
     login_user = module.params["login_user"]
 

plugins/modules/mysql_role.py

@@ -305,7 +305,6 @@ from ansible.module_utils.basic import AnsibleModule
 from ansible_collections.community.mysql.plugins.module_utils.mysql import (
     mysql_connect,
     mysql_driver,
-    mysql_driver_fail_msg,
     mysql_common_argument_spec
 )
 from ansible_collections.community.mysql.plugins.module_utils.user import (
@@ -1017,9 +1016,6 @@ def main():
     if priv and isinstance(priv, dict):
         priv = convert_priv_dict_to_str(priv)
 
-    if mysql_driver is None:
-        module.fail_json(msg=mysql_driver_fail_msg)
-
     # TODO Release 4.0.0 : Remove this test and variable assignation
     if column_case_sensitive is None:
         column_case_sensitive = False

plugins/modules/mysql_user.py

@@ -396,7 +396,6 @@ from ansible_collections.community.mysql.plugins.module_utils.database import SQ
 from ansible_collections.community.mysql.plugins.module_utils.mysql import (
     mysql_connect,
     mysql_driver,
-    mysql_driver_fail_msg,
     mysql_common_argument_spec,
     set_session_vars,
 )
@@ -492,9 +491,6 @@ def main():
     if priv and isinstance(priv, dict):
         priv = convert_priv_dict_to_str(priv)
 
-    if mysql_driver is None:
-        module.fail_json(msg=mysql_driver_fail_msg)
-
     if password_expire_interval and password_expire_interval < 1:
         module.fail_json(msg="password_expire_interval value \
                              should be positive number")

plugins/modules/mysql_variables.py

@@ -91,7 +91,7 @@ from re import match
 
 from ansible.module_utils.basic import AnsibleModule
 from ansible_collections.community.mysql.plugins.module_utils.database import SQLParseError, mysql_quote_identifier
-from ansible_collections.community.mysql.plugins.module_utils.mysql import mysql_connect, mysql_driver, mysql_driver_fail_msg, mysql_common_argument_spec
+from ansible_collections.community.mysql.plugins.module_utils.mysql import mysql_connect, mysql_driver, mysql_common_argument_spec
 from ansible.module_utils._text import to_native
 
 executed_queries = []
@@ -205,10 +205,6 @@ def main():
         module.fail_json(msg="Cannot run without variable to operate with")
     if match('^[0-9A-Za-z_.]+$', mysqlvar) is None:
         module.fail_json(msg="invalid variable name \"%s\"" % mysqlvar)
-    if mysql_driver is None:
-        module.fail_json(msg=mysql_driver_fail_msg)
-    else:
-        warnings.filterwarnings('error', category=mysql_driver.Warning)
 
     try:
         cursor, db_conn = mysql_connect(module, user, password, config_file, ssl_cert, ssl_key, ssl_ca, db,