community.general/lib/ansible/modules/network/nxos
Chris Van Heuveln 1554befd95 nxos_vpc:Fix multiple idempotency issues, add missing commands (#55735)
* nxos_vpc:Fix idempotency issues with multiple attributes

Several attributes were causing idempotency problems on various platforms:

- `auto_recovery`
 - This command can be disabled on certain platforms and will nvgen as `no auto-recovery`
 - When enabled it has an additional optional-keyword for changing the `reload-delay` timer value
  - This was addressed by adding a new attribute `auto_recovery_reload_delay` to handle setting the timer value
  - This new attribute is mutually exclusive with `auto_recovery`

- `/show run vpc/show run vpc all/`
 - Changed the command that gets state to `all` so that it could differentiate between `auto-recovery` and `auto-recovery reload-delay`
 - This change resulted in also changing some attribute handling withing `get_vpc`, since some attributes like `peer_gw` relied on presence of the config to determine state true or false. With `all` the config is always there so these attrs must specifically check for `'no '` in the string.

- `delay_restore`
 - This command has two additional, optional keywords that exist on some platforms and not others.
 - New attrs:
  - `delay_restore_interface_vlan`
  - `delay_restore_orphan_port`

- Modified the `sanity` test to include the new attributes and to fix the platform issues.

- Bugfix Pull Request

`modules/network/nxos/nxos_vpc.py`

- Validated `nxos_vpc` `sanity` test on these platforms, all are now 100% Pass: N35, N3K, N3K-F, N6K, N7K, N9K, N9K-F

- TBD: Future work is needed to add support for `peer_gw_exclude_gw` timers. This could be addressed in the same way as the `auto_recovery_reload_delay` changes included here.

* lint fix

* Add 'version_added' tags for new options
2019-05-10 13:17:02 +05:30
..
__init__.py initial add of new nxos_config module 2016-12-08 11:24:02 -05:00
_nxos_ip_interface.py Remove modules which have ended their deprecation cycle 2019-04-12 12:57:35 -07:00
_nxos_mtu.py Fixup removed and deprecated modules 2018-08-24 15:37:13 -07:00
_nxos_portchannel.py Remove modules which have ended their deprecation cycle 2019-04-12 12:57:35 -07:00
_nxos_switchport.py Remove modules which have ended their deprecation cycle 2019-04-12 12:57:35 -07:00
nxos_aaa_server.py fix nxos_aaa_server issues (#38117) 2018-04-02 07:56:06 -04:00
nxos_aaa_server_host.py Update nxos_aaa_server_host.py (#49635) 2019-01-21 10:47:51 -05:00
nxos_acl.py nxos_acl: some platforms/versions raise when no ACLs are present (#55609) 2019-05-02 18:03:27 +05:30
nxos_acl_interface.py Refactor common network shared and platform utils code into package (#33452) 2017-12-03 21:42:30 +05:30
nxos_banner.py fix for banner idempotent issue (#46001) 2018-09-26 15:48:56 +05:30
nxos_bgp.py Replace bogus (but routeable) ip addresses with RFC 5737 example addresses (#40554) 2018-05-30 13:03:20 -04:00
nxos_bgp_af.py fix UnboundLocalError nxos_bgp_af module (#37610) 2018-03-20 01:53:08 +05:30
nxos_bgp_neighbor.py Replace bogus (but routeable) ip addresses with RFC 5737 example addresses (#40554) 2018-05-30 13:03:20 -04:00
nxos_bgp_neighbor_af.py E325 Removal - Part II (#49196) 2018-11-28 13:55:52 +05:30
nxos_command.py Revert nxos, ios, iosxr return_timestamps (#56206) 2019-05-08 20:49:29 +05:30
nxos_config.py Add more return values to *_config modules (#50702) 2019-01-28 20:49:56 +05:30
nxos_evpn_global.py More validate module fixes (#39097) 2018-04-24 18:05:50 +01:00
nxos_evpn_vni.py Fix pycodestyle E117 issues. 2019-02-13 23:35:39 -08:00
nxos_facts.py Remove redundant method (#55566) 2019-04-24 15:29:55 +05:30
nxos_feature.py Handle nxos_feature issue where json isn't supported (#39150) 2018-05-04 12:21:58 +05:30
nxos_file_copy.py Fix passwordless workflow (#55441) 2019-05-02 18:06:25 +05:30
nxos_gir.py Convert to reduced list of known types (#50010) 2018-12-19 07:25:30 +10:00
nxos_gir_profile_management.py Convert to reduced list of known types (#50010) 2018-12-19 07:25:30 +10:00
nxos_hsrp.py Fix typo 2019-03-12 13:34:52 +01:00
nxos_igmp.py fix nxos_igmp issues (#38496) 2018-04-10 00:05:58 -04:00
nxos_igmp_interface.py nxos_igmp_interface: argument_spec for oif_ps breaks when 'default' (#53136) 2019-03-11 10:28:29 +05:30
nxos_igmp_snooping.py nxos_igmp_snooping: more group-timeout fixes (#53553) 2019-03-20 13:08:36 +05:30
nxos_install_os.py Fix regular expression for timeout (#53994) 2019-03-20 13:02:11 +05:30
nxos_interface.py nxos_interface: Fix admin_state check for n6k (#55673) 2019-05-08 21:20:22 +05:30
nxos_interface_ospf.py nxos_interfaces_ospf: fix passive-interface states & check_mode (#54260) 2019-03-27 09:15:50 +05:30
nxos_l2_interface.py fix nxos_vrf and migrate get_interface_type to module_utils (#40825) 2018-05-29 21:06:08 +05:30
nxos_l3_interface.py Add support for multiple IPv6 addresses in nxos_l3_interface module (#50892) 2019-03-27 10:52:42 -04:00
nxos_linkagg.py Add type of group in nxos_linkagg module doc (#54769) 2019-04-03 14:21:12 +05:30
nxos_lldp.py Fixes for the N3500 platform that uses the A8 image (#36261) 2018-02-17 10:16:03 +05:30
nxos_logging.py Module nxos logging fixes (#52883) 2019-03-06 13:55:03 -05:00
nxos_ntp.py Convert to reduced list of known types (#50010) 2018-12-19 07:25:30 +10:00
nxos_ntp_auth.py Surround top-level function and class definitions with two blank lines. 2018-07-31 12:06:56 -07:00
nxos_ntp_options.py fix nxos_ntp_options (#38695) 2018-04-13 06:17:32 -04:00
nxos_nxapi.py Surround top-level function and class definitions with two blank lines. 2018-07-31 12:06:56 -07:00
nxos_ospf.py Remove deprecated params from module argspec nxos modules (#34911) 2018-01-16 18:23:58 +05:30
nxos_ospf_vrf.py Fix nxos_ospf_vrf module auto-cost idempotency and module check mode (#47190) 2018-10-23 14:28:24 +05:30
nxos_overlay_global.py Clean up module documentation (#36909) 2018-03-15 22:15:24 +01:00
nxos_pim.py fix nxos_pim module doc (#36505) 2018-02-21 18:42:37 +05:30
nxos_pim_interface.py Sanity fixes to parameter types (#52325) 2019-02-15 16:58:58 +01:00
nxos_pim_rp_address.py Replace bogus (but routeable) ip addresses with RFC 5737 example addresses (#40554) 2018-05-30 13:03:20 -04:00
nxos_ping.py Add type int for various argument params (#55026) 2019-04-10 16:19:00 -04:00
nxos_reboot.py Convert to reduced list of known types (#50010) 2018-12-19 07:25:30 +10:00
nxos_rollback.py Convert to reduced list of known types (#50010) 2018-12-19 07:25:30 +10:00
nxos_rpm.py fix reload smu issue (#41270) 2018-06-14 09:17:33 +05:30
nxos_smu.py Clean up module documentation (#36909) 2018-03-15 22:15:24 +01:00
nxos_snapshot.py Assorted pylint fixes 2019-02-15 06:54:47 -08:00
nxos_snmp_community.py fix nxos_snmp_community issues (#39258) 2018-04-25 13:16:41 +05:30
nxos_snmp_contact.py Refactor common network shared and platform utils code into package (#33452) 2017-12-03 21:42:30 +05:30
nxos_snmp_host.py Replace bogus (but routeable) ip addresses with RFC 5737 example addresses (#40554) 2018-05-30 13:03:20 -04:00
nxos_snmp_location.py Refactor common network shared and platform utils code into package (#33452) 2017-12-03 21:42:30 +05:30
nxos_snmp_traps.py nxos_snmp_traps: fix 'group: all' for N35 platforms (#55995) 2019-05-07 13:57:55 +05:30
nxos_snmp_user.py nxos_snmp_user: platform fixes for get_snmp_user (#55832) 2019-05-10 13:10:49 +05:30
nxos_static_route.py nxos_static_route: reconcile_candidate fails to remove 'track' routes (#53806) 2019-03-21 18:52:46 +05:30
nxos_system.py E325 Removal - Part II (#49196) 2018-11-28 13:55:52 +05:30
nxos_udld.py Convert to reduced list of known types (#50010) 2018-12-19 07:25:30 +10:00
nxos_udld_interface.py Convert to reduced list of known types (#50010) 2018-12-19 07:25:30 +10:00
nxos_user.py nxos_user: fails to remove usernames with embedded '\' (#53149) 2019-03-07 18:45:26 +05:30
nxos_vlan.py fix nxos_vlan mode idempotence bug (#55144) 2019-05-08 11:19:15 +05:30
nxos_vpc.py nxos_vpc:Fix multiple idempotency issues, add missing commands (#55735) 2019-05-10 13:17:02 +05:30
nxos_vpc_interface.py E325 Removal - Part II (#49196) 2018-11-28 13:55:52 +05:30
nxos_vrf.py Fix module issues (#52209) 2019-02-15 12:57:20 +01:00
nxos_vrf_af.py Remove deprecated options from modules (#50246) 2019-01-22 09:18:26 -05:00
nxos_vrf_interface.py fix nxos_vrf and migrate get_interface_type to module_utils (#40825) 2018-05-29 21:06:08 +05:30
nxos_vrrp.py fix nxos_vrf and migrate get_interface_type to module_utils (#40825) 2018-05-29 21:06:08 +05:30
nxos_vtp_domain.py nxos_vtp_*: Fixes n6k issues (#55737) 2019-05-10 10:54:51 +05:30
nxos_vtp_password.py nxos_vtp_*: Fixes n6k issues (#55737) 2019-05-10 10:54:51 +05:30
nxos_vtp_version.py nxos_vtp_*: Fixes n6k issues (#55737) 2019-05-10 10:54:51 +05:30
nxos_vxlan_vtep.py nxos_vxlan_vtep: Add dependency checks (#53288) 2019-03-08 10:33:54 +05:30
nxos_vxlan_vtep_vni.py Add new configuration for nxos_vxlan_vtep_vni (#47882) 2018-11-02 11:23:23 +05:30