mirror of
				https://github.com/ansible-collections/community.general.git
				synced 2025-10-25 05:23:58 -07:00 
			
		
		
		
	* [WIP] become plugins
Move from hardcoded method to plugins for ease of use, expansion and overrides
  - load into connection as it is going to be the main consumer
  - play_context will also use to keep backwards compat API
  - ensure shell is used to construct commands when needed
  - migrate settings remove from base config in favor of plugin specific configs
  - cleanup ansible-doc
  - add become plugin docs
  - remove deprecated sudo/su code and keywords
  - adjust become options for cli
  - set plugin options from context
  - ensure config defs are avaialbe before instance
  - refactored getting the shell plugin, fixed tests
     - changed into regex as they were string matching, which does not work with random string generation
     - explicitly set flags for play context tests
 - moved plugin loading up front
 - now loads for basedir also
 - allow pyc/o for non m modules
 - fixes to tests and some plugins
 - migrate to play objects fro play_context
 - simiplify gathering
 -  added utf8 headers
 - moved option setting
 - add fail msg to dzdo
 - use tuple for multiple options on fail/missing
 - fix relative plugin paths
 - shift from play context to play
 - all tasks already inherit this from play directly
 - remove obsolete 'set play'
 - correct environment handling
 - add wrap_exe option to pfexec
 - fix runas to noop
 - fixed setting play context
 - added password configs
 - removed required false
 - remove from doc building till they are ready
future development:
  - deal with 'enable' and 'runas' which are not 'command wrappers' but 'state flags' and currently hardcoded in diff subsystems
* cleanup
  remove callers to removed func
  removed --sudo cli doc refs
  remove runas become_exe
  ensure keyerorr on plugin
  also fix backwards compat, missing method is attributeerror, not ansible error
  get remote_user consistently
  ignore missing system_tmpdirs on plugin load
  correct config precedence
  add deprecation
  fix networking imports
  backwards compat for plugins using BECOME_METHODS
* Port become_plugins to context.CLIARGS
This is a work in progress:
* Stop passing options around everywhere as we can use context.CLIARGS
  instead
* Refactor make_become_commands as asked for by alikins
* Typo in comment fix
* Stop loading values from the cli in more than one place
Both play and play_context were saving default values from the cli
arguments directly.  This changes things so that the default values are
loaded into the play and then play_context takes them from there.
* Rename BECOME_PLUGIN_PATH to DEFAULT_BECOME_PLUGIN_PATH
As alikins said, all other plugin paths are named
DEFAULT_plugintype_PLUGIN_PATH.  If we're going to rename these, that
should be done all at one time rather than piecemeal.
* One to throw away
This is a set of hacks to get setting FieldAttribute defaults to command
line args to work.  It's not fully done yet.
After talking it over with sivel and jimi-c this should be done by
fixing FieldAttributeBase and _get_parent_attribute() calls to do the
right thing when there is a non-None default.
What we want to be able to do ideally is something like this:
class Base(FieldAttributeBase):
    _check_mode = FieldAttribute([..] default=lambda: context.CLIARGS['check'])
class Play(Base):
    # lambda so that we have a chance to parse the command line args
    # before we get here.  In the future we might be able to restructure
    # this so that the cli parsing code runs before these classes are
    # defined.
class Task(Base):
    pass
And still have a playbook like this function:
---
- hosts:
  tasks:
  - command: whoami
    check_mode: True
(The check_mode test that is added as a separate commit in this PR will
let you test variations on this case).
There's a few separate reasons that the code doesn't let us do this or
a non-ugly workaround for this as written right now.  The fix that
jimi-c, sivel, and I talked about may let us do this or it may still
require a workaround (but less ugly) (having one class that has the
FieldAttributes with default values and one class that inherits from
that but just overrides the FieldAttributes which now have defaults)
* Revert "One to throw away"
This reverts commit 23aa883cbed11429ef1be2a2d0ed18f83a3b8064.
* Set FieldAttr defaults directly from CLIARGS
* Remove dead code
* Move timeout directly to PlayContext, it's never needed on Play
* just for backwards compat, add a static version of BECOME_METHODS to constants
* Make the become attr on the connection public, since it's used outside of the connection
* Logic fix
* Nuke connection testing if it supports specific become methods
* Remove unused vars
* Address rebase issues
* Fix path encoding issue
* Remove unused import
* Various cleanups
* Restore network_cli check in _low_level_execute_command
* type improvements for cliargs_deferred_get and swap shallowcopy to default to False
* minor cleanups
* Allow the su plugin to work, since it doesn't define a prompt the same way
* Fix up ksu become plugin
* Only set prompt if build_become_command was called
* Add helper to assist connection plugins in knowing they need to wait for a prompt
* Fix tests and code expectations
* Doc updates
* Various additional minor cleanups
* Make doas functional
* Don't change connection signature, load become plugin from TaskExecutor
* Remove unused imports
* Add comment about setting the become plugin on the playcontext
* Fix up tests for recent changes
* Support 'Password:' natively for the doas plugin
* Make default prompts raw
* wording cleanups. ci_complete
* Remove unrelated changes
* Address spelling mistake
* Restore removed test, and udpate to use new functionality
* Add changelog fragment
* Don't hard fail in set_attributes_from_cli on missing CLI keys
* Remove unrelated change to loader
* Remove internal deprecated FieldAttributes now
* Emit deprecation warnings now
		
	
			
		
			
				
	
	
		
			161 lines
		
	
	
	
		
			6.1 KiB
		
	
	
	
		
			Python
		
	
	
	
	
	
			
		
		
	
	
			161 lines
		
	
	
	
		
			6.1 KiB
		
	
	
	
		
			Python
		
	
	
	
	
	
| # Based on the docker connection plugin
 | |
| # Copyright (c) 2017 Ansible Project
 | |
| # GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
 | |
| #
 | |
| # Connection plugin for building container images using buildah tool
 | |
| #   https://github.com/projectatomic/buildah
 | |
| #
 | |
| # Written by: Tomas Tomecek (https://github.com/TomasTomecek)
 | |
| 
 | |
| from __future__ import (absolute_import, division, print_function)
 | |
| __metaclass__ = type
 | |
| 
 | |
| 
 | |
| DOCUMENTATION = """
 | |
|     connection: buildah
 | |
|     short_description: Interact with an existing buildah container
 | |
|     description:
 | |
|         - Run commands or put/fetch files to an existing container using buildah tool.
 | |
|     author: Tomas Tomecek (ttomecek@redhat.com)
 | |
|     version_added: 2.4
 | |
|     options:
 | |
|       remote_addr:
 | |
|         description:
 | |
|             - The ID of the container you want to access.
 | |
|         default: inventory_hostname
 | |
|         vars:
 | |
|             - name: ansible_host
 | |
| #        keyword:
 | |
| #            - name: hosts
 | |
|       remote_user:
 | |
|         description:
 | |
|             - User specified via name or ID which is used to execute commands inside the container.
 | |
|         ini:
 | |
|           - section: defaults
 | |
|             key: remote_user
 | |
|         env:
 | |
|           - name: ANSIBLE_REMOTE_USER
 | |
|         vars:
 | |
|           - name: ansible_user
 | |
| #        keyword:
 | |
| #            - name: remote_user
 | |
| """
 | |
| 
 | |
| import shlex
 | |
| import shutil
 | |
| 
 | |
| import subprocess
 | |
| 
 | |
| import ansible.constants as C
 | |
| from ansible.module_utils._text import to_bytes, to_native
 | |
| from ansible.plugins.connection import ConnectionBase, ensure_connect
 | |
| from ansible.utils.display import Display
 | |
| 
 | |
| display = Display()
 | |
| 
 | |
| 
 | |
| # this _has to be_ named Connection
 | |
| class Connection(ConnectionBase):
 | |
|     """
 | |
|     This is a connection plugin for buildah: it uses buildah binary to interact with the containers
 | |
|     """
 | |
| 
 | |
|     # String used to identify this Connection class from other classes
 | |
|     transport = 'buildah'
 | |
|     has_pipelining = True
 | |
| 
 | |
|     def __init__(self, play_context, new_stdin, *args, **kwargs):
 | |
|         super(Connection, self).__init__(play_context, new_stdin, *args, **kwargs)
 | |
| 
 | |
|         self._container_id = self._play_context.remote_addr
 | |
|         self._connected = False
 | |
|         # container filesystem will be mounted here on host
 | |
|         self._mount_point = None
 | |
|         # `buildah inspect` doesn't contain info about what the default user is -- if it's not
 | |
|         # set, it's empty
 | |
|         self.user = self._play_context.remote_user
 | |
| 
 | |
|     def _set_user(self):
 | |
|         self._buildah(b"config", [b"--user=" + to_bytes(self.user, errors='surrogate_or_strict')])
 | |
| 
 | |
|     def _buildah(self, cmd, cmd_args=None, in_data=None):
 | |
|         """
 | |
|         run buildah executable
 | |
| 
 | |
|         :param cmd: buildah's command to execute (str)
 | |
|         :param cmd_args: list of arguments to pass to the command (list of str/bytes)
 | |
|         :param in_data: data passed to buildah's stdin
 | |
|         :return: return code, stdout, stderr
 | |
|         """
 | |
|         local_cmd = ['buildah', cmd, '--', self._container_id]
 | |
|         if cmd_args:
 | |
|             local_cmd += cmd_args
 | |
|         local_cmd = [to_bytes(i, errors='surrogate_or_strict') for i in local_cmd]
 | |
| 
 | |
|         display.vvv("RUN %s" % (local_cmd,), host=self._container_id)
 | |
|         p = subprocess.Popen(local_cmd, shell=False, stdin=subprocess.PIPE,
 | |
|                              stdout=subprocess.PIPE, stderr=subprocess.PIPE)
 | |
| 
 | |
|         stdout, stderr = p.communicate(input=in_data)
 | |
|         stdout = to_bytes(stdout, errors='surrogate_or_strict')
 | |
|         stderr = to_bytes(stderr, errors='surrogate_or_strict')
 | |
|         return p.returncode, stdout, stderr
 | |
| 
 | |
|     def _connect(self):
 | |
|         """
 | |
|         no persistent connection is being maintained, mount container's filesystem
 | |
|         so we can easily access it
 | |
|         """
 | |
|         super(Connection, self)._connect()
 | |
|         rc, self._mount_point, stderr = self._buildah("mount")
 | |
|         self._mount_point = self._mount_point.strip()
 | |
|         display.vvvvv("MOUNTPOINT %s RC %s STDERR %r" % (self._mount_point, rc, stderr))
 | |
|         self._connected = True
 | |
| 
 | |
|     @ensure_connect
 | |
|     def exec_command(self, cmd, in_data=None, sudoable=False):
 | |
|         """ run specified command in a running OCI container using buildah """
 | |
|         super(Connection, self).exec_command(cmd, in_data=in_data, sudoable=sudoable)
 | |
| 
 | |
|         # shlex.split has a bug with text strings on Python-2.6 and can only handle text strings on Python-3
 | |
|         cmd_args_list = shlex.split(to_native(cmd, errors='surrogate_or_strict'))
 | |
| 
 | |
|         rc, stdout, stderr = self._buildah("run", cmd_args_list)
 | |
| 
 | |
|         display.vvvvv("STDOUT %r STDERR %r" % (stderr, stderr))
 | |
|         return rc, stdout, stderr
 | |
| 
 | |
|     def put_file(self, in_path, out_path):
 | |
|         """ Place a local file located in 'in_path' inside container at 'out_path' """
 | |
|         super(Connection, self).put_file(in_path, out_path)
 | |
|         display.vvv("PUT %s TO %s" % (in_path, out_path), host=self._container_id)
 | |
| 
 | |
|         real_out_path = self._mount_point + to_bytes(out_path, errors='surrogate_or_strict')
 | |
|         shutil.copyfile(
 | |
|             to_bytes(in_path, errors='surrogate_or_strict'),
 | |
|             to_bytes(real_out_path, errors='surrogate_or_strict')
 | |
|         )
 | |
|         # alternatively, this can be implemented using `buildah copy`:
 | |
|         # rc, stdout, stderr = self._buildah(
 | |
|         #     "copy",
 | |
|         #     [to_bytes(in_path, errors='surrogate_or_strict'),
 | |
|         #      to_bytes(out_path, errors='surrogate_or_strict')]
 | |
|         # )
 | |
| 
 | |
|     def fetch_file(self, in_path, out_path):
 | |
|         """ obtain file specified via 'in_path' from the container and place it at 'out_path' """
 | |
|         super(Connection, self).fetch_file(in_path, out_path)
 | |
|         display.vvv("FETCH %s TO %s" % (in_path, out_path), host=self._container_id)
 | |
| 
 | |
|         real_in_path = self._mount_point + to_bytes(in_path, errors='surrogate_or_strict')
 | |
|         shutil.copyfile(
 | |
|             to_bytes(real_in_path, errors='surrogate_or_strict'),
 | |
|             to_bytes(out_path, errors='surrogate_or_strict')
 | |
|         )
 | |
| 
 | |
|     def close(self):
 | |
|         """ unmount container's filesystem """
 | |
|         super(Connection, self).close()
 | |
|         rc, stdout, stderr = self._buildah("umount")
 | |
|         display.vvvvv("RC %s STDOUT %r STDERR %r" % (rc, stdout, stderr))
 | |
|         self._connected = False
 |