mirror of
https://github.com/ansible-collections/community.general.git
synced 2025-10-11 02:44:02 -07:00
Without this patch, the os_keystone_domain module is not idempotent if the description is empty because the description parameter is None in ansible, but the keystone client returns an empty unicode string. Following the example of other OpenStack modules, this patch fixes the issue by checking whether the module parameter is None before going on to check its value.
196 lines
5.4 KiB
Python
196 lines
5.4 KiB
Python
#!/usr/bin/python
|
|
# Copyright (c) 2015 Hewlett-Packard Development Company, L.P.
|
|
#
|
|
# This module is free software: you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation, either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This software is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this software. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
|
|
try:
|
|
import shade
|
|
HAS_SHADE = True
|
|
except ImportError:
|
|
HAS_SHADE = False
|
|
|
|
ANSIBLE_METADATA = {'status': ['preview'],
|
|
'supported_by': 'community',
|
|
'version': '1.0'}
|
|
|
|
DOCUMENTATION = '''
|
|
---
|
|
module: os_keystone_domain
|
|
short_description: Manage OpenStack Identity Domains
|
|
extends_documentation_fragment: openstack
|
|
version_added: "2.1"
|
|
description:
|
|
- Create, update, or delete OpenStack Identity domains. If a domain
|
|
with the supplied name already exists, it will be updated with the
|
|
new description and enabled attributes.
|
|
options:
|
|
name:
|
|
description:
|
|
- Name that has to be given to the instance
|
|
required: true
|
|
description:
|
|
description:
|
|
- Description of the domain
|
|
required: false
|
|
default: None
|
|
enabled:
|
|
description:
|
|
- Is the domain enabled
|
|
required: false
|
|
default: True
|
|
state:
|
|
description:
|
|
- Should the resource be present or absent.
|
|
choices: [present, absent]
|
|
default: present
|
|
requirements:
|
|
- "python >= 2.6"
|
|
- "shade"
|
|
'''
|
|
|
|
EXAMPLES = '''
|
|
# Create a domain
|
|
- os_keystone_domain:
|
|
cloud: mycloud
|
|
state: present
|
|
name: demo
|
|
description: Demo Domain
|
|
|
|
# Delete a domain
|
|
- os_keystone_domain:
|
|
cloud: mycloud
|
|
state: absent
|
|
name: demo
|
|
'''
|
|
|
|
RETURN = '''
|
|
domain:
|
|
description: Dictionary describing the domain.
|
|
returned: On success when I(state) is 'present'
|
|
type: dictionary
|
|
contains:
|
|
id:
|
|
description: Domain ID.
|
|
type: string
|
|
sample: "474acfe5-be34-494c-b339-50f06aa143e4"
|
|
name:
|
|
description: Domain name.
|
|
type: string
|
|
sample: "demo"
|
|
description:
|
|
description: Domain description.
|
|
type: string
|
|
sample: "Demo Domain"
|
|
enabled:
|
|
description: Domain description.
|
|
type: boolean
|
|
sample: True
|
|
|
|
id:
|
|
description: The domain ID.
|
|
returned: On success when I(state) is 'present'
|
|
type: string
|
|
sample: "474acfe5-be34-494c-b339-50f06aa143e4"
|
|
'''
|
|
|
|
def _needs_update(module, domain):
|
|
if module.params['description'] is not None and \
|
|
domain.description != module.params['description']:
|
|
return True
|
|
if domain.enabled != module.params['enabled']:
|
|
return True
|
|
return False
|
|
|
|
def _system_state_change(module, domain):
|
|
state = module.params['state']
|
|
if state == 'absent' and domain:
|
|
return True
|
|
|
|
if state == 'present':
|
|
if domain is None:
|
|
return True
|
|
return _needs_update(module, domain)
|
|
|
|
return False
|
|
|
|
def main():
|
|
|
|
argument_spec = openstack_full_argument_spec(
|
|
name=dict(required=True),
|
|
description=dict(default=None),
|
|
enabled=dict(default=True, type='bool'),
|
|
state=dict(default='present', choices=['absent', 'present']),
|
|
)
|
|
|
|
module_kwargs = openstack_module_kwargs()
|
|
module = AnsibleModule(argument_spec,
|
|
supports_check_mode=True,
|
|
**module_kwargs)
|
|
|
|
if not HAS_SHADE:
|
|
module.fail_json(msg='shade is required for this module')
|
|
|
|
name = module.params['name']
|
|
description = module.params['description']
|
|
enabled = module.params['enabled']
|
|
state = module.params['state']
|
|
|
|
try:
|
|
cloud = shade.operator_cloud(**module.params)
|
|
|
|
domains = cloud.search_domains(filters=dict(name=name))
|
|
|
|
if len(domains) > 1:
|
|
module.fail_json(msg='Domain name %s is not unique' % name)
|
|
elif len(domains) == 1:
|
|
domain = domains[0]
|
|
else:
|
|
domain = None
|
|
|
|
if module.check_mode:
|
|
module.exit_json(changed=_system_state_change(module, domain))
|
|
|
|
if state == 'present':
|
|
if domain is None:
|
|
domain = cloud.create_domain(
|
|
name=name, description=description, enabled=enabled)
|
|
changed = True
|
|
else:
|
|
if _needs_update(module, domain):
|
|
domain = cloud.update_domain(
|
|
domain.id, name=name, description=description,
|
|
enabled=enabled)
|
|
changed = True
|
|
else:
|
|
changed = False
|
|
module.exit_json(changed=changed, domain=domain, id=domain.id)
|
|
|
|
elif state == 'absent':
|
|
if domain is None:
|
|
changed=False
|
|
else:
|
|
cloud.delete_domain(domain.id)
|
|
changed=True
|
|
module.exit_json(changed=changed)
|
|
|
|
except shade.OpenStackCloudException as e:
|
|
module.fail_json(msg=str(e))
|
|
|
|
|
|
from ansible.module_utils.basic import *
|
|
from ansible.module_utils.openstack import *
|
|
|
|
if __name__ == '__main__':
|
|
main()
|