mirror of
https://github.com/ansible-collections/community.general.git
synced 2025-04-30 22:31:25 -07:00
bb50fc3889
* Updates aci.py with the ability to add ACI objects to any depth Changes start at line 411 (construct_deep_url() and supporting functions). One minor change to line 633 (the original construct_url()) to provide for testability: ...join(sorted(self.child_classes)) vs ...join(self.child_classes) I am also attaching two test files. One characterizing the existing construct_url() and the matching test set for construct_deep_url() to support my efforts and proof of parity * Two PyTest files to support construct_deep_url These two files provide testing parity, one characterizing the original construct_url() function and the other proofing construct_deep_url(). The ...deep_url.py test file goes five layers deep to provide better validation for the function * Correcting previous upload to incorrect folder These two files provide testing parity, one characterizing the original construct_url() function and the other proofing construct_deep_url(). The ...deep_url.py test file goes five layers deep to provide better validation for the function * Deleting for file name change per Matt Clay * Deleting for file name change per Matt Clay * Correcting file names per Matt Clay @mattclay Thanks again for your continued guidance and patience. Please cancel the previous (incorrect) request * Wrong location for test file * Wrong location for test file * First attempt to comply with suggestions lib/ansible/module_utils/network/aci/aci.py:517:0: SyntaxWarning: "is not" with a literal. Did you mean "!="? lib/ansible/module_utils/network/aci/aci.py:534:0: SyntaxWarning: "is not" with a literal. Did you mean "!="? lib/ansible/module_utils/network/aci/aci.py:558:161: E501 line too long (210 > 160 characters) * First attempt to comply with suggestions test/units/module_utils/network/aci/test_aci_construct_url.py:1:14: SyntaxError: import pytest test/units/module_utils/network/aci/test_aci_deep_url.py:1:14: SyntaxError: import pytest test/units/module_utils/network/aci/test_aci_construct_url.py:0:0: use "\n" for line endings instead of "\r\n" test/units/module_utils/network/aci/test_aci_deep_url.py:0:0: use "\n" for line endings instead of "\r\n" Shortened test function names (less descriptive) * Second attempt to comply with suggestions * Second attempt to comply with suggestions * Third attempt to comply with suggestions * Third attempt to comply with suggestions * Pro Tip: Convert from 'CRLF' to 'LF' in VSCode It's on the status bar to the right * Added setup() support for tests * Continued corrections to support testing * Added two mocks to support testing I could not find where to place fakes/mocks, so please let me know if the current location is incorrect * Adding tmpdir property to mock_basic.py * Added last blank line to mock_basic.py To pass sanity test * Attempt to correct setup() issues * Attempt to correct setup() issues * Attempt to correct setup() issues * Attempt to correct setup() issues * Withdrawing pending injectability tweak to aci.py * Withdrawing pending injectability tweak to aci.py * Withdrawing pending injectability tweak to aci.py * Withdrawing pending injectability tweak to aci.py |
||
|---|---|---|
| .. | ||
| aws | ||
| common | ||
| compat | ||
| csharp | ||
| distro | ||
| docker | ||
| facts | ||
| k8s | ||
| net_tools | ||
| network | ||
| oracle | ||
| parsing | ||
| podman | ||
| powershell | ||
| remote_management | ||
| six | ||
| source_control | ||
| storage | ||
| __init__.py | ||
| _text.py | ||
| acme.py | ||
| alicloud_ecs.py | ||
| ansible_release.py | ||
| ansible_tower.py | ||
| api.py | ||
| azure_rm_common.py | ||
| azure_rm_common_ext.py | ||
| azure_rm_common_rest.py | ||
| basic.py | ||
| cloud.py | ||
| cloudscale.py | ||
| cloudstack.py | ||
| connection.py | ||
| crypto.py | ||
| database.py | ||
| digital_ocean.py | ||
| dimensiondata.py | ||
| ec2.py | ||
| exoscale.py | ||
| f5_utils.py | ||
| firewalld.py | ||
| gcdns.py | ||
| gce.py | ||
| gcp.py | ||
| gcp_utils.py | ||
| gitlab.py | ||
| hcloud.py | ||
| heroku.py | ||
| hetzner.py | ||
| hwc_utils.py | ||
| ibm_sa_utils.py | ||
| infinibox.py | ||
| influxdb.py | ||
| ipa.py | ||
| ismount.py | ||
| json_utils.py | ||
| keycloak.py | ||
| known_hosts.py | ||
| kubevirt.py | ||
| ldap.py | ||
| linode.py | ||
| lxd.py | ||
| manageiq.py | ||
| memset.py | ||
| mysql.py | ||
| netapp.py | ||
| netapp_elementsw_module.py | ||
| netapp_module.py | ||
| oneandone.py | ||
| oneview.py | ||
| online.py | ||
| opennebula.py | ||
| openstack.py | ||
| ovirt.py | ||
| postgres.py | ||
| pure.py | ||
| pycompat24.py | ||
| rabbitmq.py | ||
| rax.py | ||
| redfish_utils.py | ||
| redhat.py | ||
| scaleway.py | ||
| service.py | ||
| splitter.py | ||
| univention_umc.py | ||
| urls.py | ||
| utm_utils.py | ||
| vca.py | ||
| vexata.py | ||
| vmware.py | ||
| vmware_rest_client.py | ||
| vultr.py | ||
| xenserver.py | ||
| yumdnf.py | ||