community.general/lib/ansible
Chris Van Heuveln 1554befd95 nxos_vpc:Fix multiple idempotency issues, add missing commands (#55735)
* nxos_vpc:Fix idempotency issues with multiple attributes

Several attributes were causing idempotency problems on various platforms:

- `auto_recovery`
 - This command can be disabled on certain platforms and will nvgen as `no auto-recovery`
 - When enabled it has an additional optional-keyword for changing the `reload-delay` timer value
  - This was addressed by adding a new attribute `auto_recovery_reload_delay` to handle setting the timer value
  - This new attribute is mutually exclusive with `auto_recovery`

- `/show run vpc/show run vpc all/`
 - Changed the command that gets state to `all` so that it could differentiate between `auto-recovery` and `auto-recovery reload-delay`
 - This change resulted in also changing some attribute handling withing `get_vpc`, since some attributes like `peer_gw` relied on presence of the config to determine state true or false. With `all` the config is always there so these attrs must specifically check for `'no '` in the string.

- `delay_restore`
 - This command has two additional, optional keywords that exist on some platforms and not others.
 - New attrs:
  - `delay_restore_interface_vlan`
  - `delay_restore_orphan_port`

- Modified the `sanity` test to include the new attributes and to fix the platform issues.

- Bugfix Pull Request

`modules/network/nxos/nxos_vpc.py`

- Validated `nxos_vpc` `sanity` test on these platforms, all are now 100% Pass: N35, N3K, N3K-F, N6K, N7K, N9K, N9K-F

- TBD: Future work is needed to add support for `peer_gw_exclude_gw` timers. This could be addressed in the same way as the `auto_recovery_reload_delay` changes included here.

* lint fix

* Add 'version_added' tags for new options
2019-05-10 13:17:02 +05:30
..
cli Make ansible adhoc work with include_role (#56163) 2019-05-08 09:53:24 -04:00
compat Update bundled copy of selectors2 from 1.1.0 to 1.1.1 (#55457) 2019-04-23 11:52:24 -05:00
config Allow config boolean options to default to None (#55951) 2019-05-02 12:09:14 -07:00
errors Catch sshpass authentication errors and don't retry multiple times to prevent account lockout (#50776) 2019-01-23 11:32:25 -05:00
executor options not optional for callbacks (#55660) 2019-04-25 22:22:06 -04:00
galaxy Update galaxy cli metadata file templates (#51398) 2019-02-22 00:54:02 -05:00
inventory preserve same order as inventory manager when using host lookup (#55331) 2019-04-18 15:54:03 -04:00
module_utils Ensure 'authorize' is always bool, regardless of source (#56271) 2019-05-10 13:13:36 +05:30
modules nxos_vpc:Fix multiple idempotency issues, add missing commands (#55735) 2019-05-10 13:17:02 +05:30
parsing Migrate command line parsing to argparse (#50610) 2019-04-23 13:54:39 -05:00
playbook unite poll defaults (#55470) 2019-05-01 13:47:50 -05:00
plugins Hetzner failover IP: refactoring (#56203) 2019-05-10 08:33:51 +02:00
template fix combine filter using undefined vars (#55840) 2019-04-30 11:10:19 -04:00
utils Fix loading namespaced doc_fragments from collections (#55249) 2019-05-02 21:15:57 -04:00
vars fixes for stripping (#52930) 2019-03-12 18:18:38 -04:00
__init__.py
constants.py Fine tune sanity (#53544) 2019-03-11 15:12:14 -04:00
context.py Become plugins (#50991) 2019-02-11 11:27:44 -06:00
release.py Cleanup the tree for post-2.8-branch 2019-04-12 12:57:35 -07:00