Nathaniel Case
fc0bf87c20
Run save
inside config mode. ( #23977 )
...
* Run `save` before exiting config mode.
* Fix unit tests for `save`
* Allow `save` to be on its own again and introspect success
* Introspecting `compare running` makes this a lot harder.
Move `save` tests to integration tests
2017-04-27 11:08:37 -04:00
Ganesh Nalawade
1f7c2c63c2
Fix python version check issue ( #24063 )
...
Fix python version check issue
2017-04-27 20:10:58 +05:30
Ricardo Carrillo Cruz
2716fad38f
Return commands instead of command ( #24061 )
...
Ok, so for openvswitch_db in particular we just return one command
but in the sake of consistency and code re-use, let's return a list
of "commands", even if it's just one.
2017-04-27 16:36:08 +02:00
Abhijeet Kasurde
9456f93ea8
Pep8 fixes for known_hosts.py ( #24029 )
...
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-04-27 09:21:49 -05:00
Andrea Tartaglia
1d0a629dcc
Fixed docs for cloud modules ( #23745 )
...
* Fixed docs for cloud modules
* removed blank line in ec2_snapshot_facts
2017-04-27 12:01:11 +01:00
Ganesh Nalawade
7d710882a8
Fix exception issue in junos_config ( #24049 )
...
ParseError execption is added to ElementTree
in py2.7. Prior to py2.7 need catch ExpatError
execption
2017-04-27 13:16:40 +05:30
Andrej Svenke
3185ec94c5
ecs_service: add tasks placement constraints and strategy. ( #20503 )
...
ecs_service: documentation fix.
ecs_service: updated version_added.
ecs_service: pep8 fixes.
2017-04-27 08:33:23 +01:00
Nathaniel Case
0d67a49d5a
nxos_bgp fixes ( #23927 )
...
* Pre-emptively fix sanity/pep8
* fix for commands
* Quick unit test
2017-04-26 16:33:54 -04:00
Nathaniel Case
c0ebdf144d
nxos_acl_interface fixes ( #23917 )
...
* Update nxos_acl_interface
* Add basic unit tests to nxos_acl_interface
2017-04-26 16:32:36 -04:00
Nathaniel Case
f0914ee3c2
nxos_acl fixes ( #23915 )
...
* Update nxos_acl
* unit tests for nxos_acl
* Remove nxos_acl from pep8-legacy
2017-04-26 16:29:53 -04:00
Abhijeet Kasurde
86a63cfcd7
Handle fetch_url error gracefully ( #23821 )
...
Fix adds http response code check for fetch_url.
Also, method in fetch_url call.
Fixes https://github.com/ansible/ansible/issues/23800
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-04-26 10:35:40 -05:00
Giuseppe Scrivano
d02a9016a2
Atomic containers ( #21366 )
...
* atomic_image: add support for pull --storage=
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* atomic_container: new module
Manage atomic containers
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2017-04-26 08:21:08 -07:00
Andrea Tartaglia
d1517f997a
fixed RETURN docs for modules ( #24011 )
...
* fixed RETURN docs for remaining modules
* updated proxymysql_mysql_users 'sample' to yaml dict
* fixed whitespace errors
2017-04-26 15:56:13 +01:00
ka7
b11219440b
spelling fixes (non-trivial, might catch a bug) ( #23646 )
2017-04-26 13:14:34 +01:00
Abhijeet Kasurde
d16fe5bef3
Minor typo and PEP8 fixes for dnf module ( #23845 )
...
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-04-26 12:57:49 +01:00
Abhijeet Kasurde
9fbbb5e10f
Pep8 fixes for mysql module ( #23923 )
...
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-04-26 12:56:35 +01:00
cptchips
dde383aea2
[Doc] win_package - product_id is a mandatory parameter ( #24007 )
...
product_id is a mandatory parameter for windows/win_package module.
2017-04-26 12:36:12 +01:00
Brian-Williams
8466c808d9
Change wait_for time to utc ( #23987 )
2017-04-25 17:04:29 -05:00
Ricardo Carrillo Cruz
a3a970180a
Unit tests for openvswitch_db module ( #23974 )
2017-04-25 20:02:55 +02:00
Ganesh Nalawade
09b8badc5e
Minor junos_config module changes ( #23972 )
...
* Minor junos_config module changes
* Add note for json config support
* Add example for lines argument
* Fix future warning for ElementTree
* Remove unwanted space
2017-04-25 23:09:55 +05:30
Chris Madden
8e7c546ef9
Fix name description from lun to volume ( #23964 )
...
Help text stated to manage lun name but this module is for managing volumes. Updated accordingly.
2017-04-25 11:08:43 -04:00
René Moser
3959597f7d
exoscale: fix TXT type records handling ( #23956 )
2017-04-25 13:05:37 +02:00
Indrajit Raychaudhuri
45252b79be
pacman: Fail fast when 'rc != 0'
...
We fail-fast and display 'stderr' in case 'pacman' returns with 'rc != 0'.
There is no point computing 'module._diff' in such case anyway.
Fixes #23910
(cherry picked from commit 8c6a2a848cf6a6d6522c8f5be56decf8df1ed6ab)
2017-04-24 21:12:20 -04:00
Brian Coca
72a4e1cf0d
fixed code to actually check the parameter not key
...
also made rest conditional on unit being provided, previouslly it changed from being always required
fixes #23810 alternate to #23907
2017-04-24 20:54:14 -04:00
Kai
cb13aea88b
Fix systemd in chroot ( #23904 )
...
* Fix systemd in chroot
The 'request ignored' message is in stderr, not stdout.
* Check both stdout and stderr for systemd message
Some versions of systemd report to stderr, others to stdout. Also check
whether output could be a valid normal response to avoid false positives.
2017-04-24 19:53:12 -04:00
Sloane Hertel
d021d8f16b
efs: include name in results ( #23931 )
2017-04-24 17:49:14 -04:00
Sloane Hertel
380ac577c6
[cloud] ec2_facts: make ec2_facts python3 compatible - fixes #23595 ( #23872 )
...
* make ec2_facts python3 compatible
* remove parentheses and use pop() instead of del
2017-04-24 16:09:46 -04:00
Ondra Machacek
80327d9d47
cloud: ovirt: import VM from external source ( #22450 )
2017-04-24 08:59:35 -04:00
Sloane Hertel
00ebd0c89d
make lineinfile docs clearer and make module pep8 ( #23857 )
2017-04-23 09:19:22 +02:00
Ondra Machacek
13c2c292f2
cloud: ovirt: add note that modules works with RHV as well ( #23808 )
2017-04-22 00:20:24 +02:00
Ganesh Nalawade
04ae977f39
Fix display argument defualt value ( #23859 )
2017-04-21 18:58:38 +05:30
Ricardo Carrillo Cruz
d0fd8cefaa
Fix the iosxr_facts mem gathering ( #23850 )
...
We were not calling match.group, plus we were lacking a ':' from
the expected output of 'show memory summary'.
Fixes #23737
2017-04-21 10:41:50 +02:00
Trishna Guha
8ec4882ba0
Add eos_user module to users parameter ( #23847 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-04-21 13:22:59 +05:30
Ganesh Nalawade
01afe12cba
Add doc for display argument of junos_command ( #23804 )
2017-04-21 02:31:51 -04:00
Abhijeet Kasurde
527a7762e1
Use regex variable in eos_user.py ( #23797 )
...
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-04-20 17:04:09 -04:00
Sloane Hertel
91644167c9
improve exception handling ( #23722 )
...
make pep8
2017-04-20 16:40:37 -04:00
Sloane Hertel
11c292bac2
route53_facts: add example for how to use next_marker option - fixes #23625 ( #23802 )
...
* Add example for using route53 next_marker option
* make route53_facts pep8 and remove from legacy files
2017-04-20 16:34:43 -04:00
Matt Babineau
4914164717
Typo ( #23778 )
...
Missed that D...
2017-04-20 10:36:09 -07:00
Trishna Guha
b2129a7d3a
Add eos_banner as module to banner param ( #23789 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-04-20 15:42:40 +05:30
Loïc Blot
504a768636
Show UUID instead of name when using UUID to select snapshot ( #23787 )
2017-04-20 11:11:04 +01:00
Abhijeet
cc745b0224
Minor typo in vmware_guest_facts ( #23791 )
...
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-04-20 11:04:03 +01:00
Toshio Kuratomi
a31e9bd9ea
Really minor optimization and style change for d0e3d75381
...
* Use a generator expression instead of a list comprehension
* Use copy() to create a new set instead of the constructor.
2017-04-19 10:24:42 -07:00
Bart van Bragt
d0e3d75381
Remove whitespace from unix group names
2017-04-19 09:42:00 -07:00
Abhijeet
27f776f97d
Fix for setting values using gconftool-2 ( #23713 )
...
Miscallenous fixes added to make gconftool-2 work.
Fixes https://github.com/ansible/ansible/issues/23670
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-04-19 14:20:21 +01:00
Sloane Hertel
d63af51f90
s3_sync: removing irrelevant s3.list_buckets() call - fixes #23409 ( #23492 )
...
* Removing irrelevant s3 call
Fix exception handling
Make s3_sync pep8 and remove from legacy file
2017-04-18 16:49:10 -04:00
Ganesh Nalawade
bf1a543f06
Make warning logs consistent ( #23666 )
...
* Make warning logs consistent
Arguments outside provider with default
value should not log as warning in case
it is not mentioned in play.
* Make nxos timeout default consistent and add comments
* Make comments more verbose
2017-04-18 21:59:38 +05:30
Daniel Shepherd
698fa37a44
[cloud] Fix #23152 in route53 module and pep8 cleanup ( #23156 )
...
update module to support more standard state=present/absent syntax
update module to use required_if, required_together, mutually_exclusive functions where possible
per ryansb review: make documentation section more clear, fix some extra quotes, remove FIXME comment
pre willthames review: force private_zone to True if vpc_id is set and fix word wrap
2017-04-18 11:49:25 -04:00
Nathaniel Case
0b4cebfb8b
nxos_vlan tweaks ( #23194 )
...
* Remove commented code
Remove a lot of unnecessary output
* Tests
* Sort vlan ids _after_ running set operations, so order is not lost
2017-04-18 10:49:47 -04:00
Yanis Guenane
fdce6484ec
crypto/openssl_csr: Specify proper Ansible version
...
The commit was started before 2.3 was branched, but was only merged once
2.3 was actually branched. This leads to documentation stating this
module is new in 2.3 when it will be actually new in 2.4
2017-04-18 15:46:07 +02:00
Kevin Brebanov
5775bb2a4e
apk: Fix regex search patterns
...
Regex patterns were not being escaped properly so package names
containing characters that could be interpreted as regex symbols
were causing failures.
Fixes : #19714
2017-04-18 15:07:55 +02:00