Commit graph

523 commits

Author SHA1 Message Date
Abhijeet Kasurde
98692ab350
VMware: Add check for valid VLAN id range (#55023)
Check allows vmware_dvs_portgroup to fail early if user
specified invalid range in VLAN id(s).

Fixes: #54927

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-04-10 08:09:21 +05:30
Gonéri Le Bouder
bda0687d28 vmware_host: ensure idempotency with state=absent (#54608)
If a host is already missing, `self.host_update` is `None`. With
this change,`state_exit_unchanged()` won't try anymore to access
`self.host_update.runtime`.
2019-04-09 01:04:47 -04:00
Gonéri Le Bouder
ee10551c7d VMware: properly format the Jinja2 of the vmware example (#54526) 2019-03-28 22:15:33 +05:30
Ludovic Rivallain
cf2f13e05d Securize the index based lookup of dict.keys() (#54452) 2019-03-27 08:02:41 -04:00
William Leemans
34868f07d5 VMware: return facts depending upon backing type (#52638)
* Not all Backings are equal

The class used for the backing is not identical in all cases, and do not have the same properties/methods.
Following backings exists at the time of this writing:
vim.vm.device.VirtualDisk.FlatVer1BackingInfo
vim.vm.device.VirtualDisk.FlatVer2BackingInfo
vim.vm.device.VirtualDisk.LocalPMemBackingInfo
vim.vm.device.VirtualDisk.PartitionedRawDiskVer2BackingInfo
vim.vm.device.VirtualDisk.RawDiskMappingVer1BackingInfo
vim.vm.device.VirtualDisk.RawDiskVer2BackingInfo
vim.vm.device.VirtualDisk.SeSparseBackingInfo
vim.vm.device.VirtualDisk.SparseVer1BackingInfo
vim.vm.device.VirtualDisk.SparseVer2BackingInfo
2019-03-26 12:43:13 +05:30
Fabian Becker
73faa376ad VMware: Add check for custom attribute type before removal (#53632) 2019-03-26 10:43:50 +05:30
Gonéri Le Bouder
8aec69dd89 VMware: vmware_guest_snapshot: fix the syntax of the example (#54362) 2019-03-26 10:10:12 +05:30
Abhijeet Kasurde
5db7501ebd
VMware: Change in update tag API (#54304)
Changed update tag API as per new changes.

Fixes: #53060

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-03-25 21:50:46 +05:30
Frederic
5feadbef4a VMware: Tag various VMware objects (#54033)
* tag portgroups and dvs
* Add support for datacenter tagging
* Support for tagging clusters
* Hostsystem tag option
* pep recommendations
* Remove Vmware from VmwareDistributedSwitch object type
* Fix typos in example tasks of vmware_tag_manager
2019-03-25 19:59:15 +05:30
Abhijeet Kasurde
636e2bc10a
Minor fix in vmware_export_ovf module (#54121)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-03-22 13:39:58 +05:30
Sam Doran
ff88bd82b5
Move type checking methods out of basic.py and add unit tests (#53687)
* Move check_type_str() out of basic.py

* Move check_type_list() out of basic.py

* Move safe_eval() out of basic.py

* Move check_type_dict() out of basic.py

* Move json importing code to common location

* Move check_type_bool() out of basic.py

* Move _check_type_int() out of basic.py

* Move _check_type_float() out of basic.py

* Move _check_type_path() out of basic.py

* Move _check_type_raw() out of basic.py

* Move _check_type_bytes() out of basic.py

* Move _check_type_bits() out of basic.py

* Create text.formatters.py

Move human_to_bytes, bytes_to_human, and _lenient_lowercase out of basic.py into text.formatters.py
Change references in modules to point to function at new location

* Move _check_type_jsonarg() out of basic.py

* Rename json related functions and put them in common.text.converters

Move formatters.py to common.text.formatters.py and update references in modules.

* Rework check_type_str()

Add allow_conversion option to make the function more self-contained.
Move the messaging back to basic.py since those error messages are more relevant to using this function in the context of AnsibleModule and not when using the function in isolation.

* Add unit tests for type checking functions

* Change _lenient_lowercase to lenient_lowercase per feedback
2019-03-21 09:40:19 -04:00
Abhijeet Kasurde
866f934044
vcenter_license: Fix fail_json call (#53933)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-03-18 12:12:27 +05:30
Diane Wang
0ed7484216 VMware: vcenter_license module support add ESXi license (#53742)
* vcenter_license module support add ESXi license

* add version added

* add query license before assign
2019-03-14 10:47:05 -04:00
Fedor V
8ac6145180 vmware_vm_facts: custom attributes support (#45773)
* Add toggle to attribute facts gathering

Signed-off-by: Fedor V <f.vompe@comptek.ru>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-03-13 09:49:20 +05:30
UnknownGnome
b03b951789 Update vmware_vmkernel.py (#53084) 2019-03-11 17:15:19 -05:00
mtward
73ba6a9bc8 VMware: return failure when shutdownguest fails with timeout (#52952)
If the state_change_timeout was exceeded in shutdownguest, there was no failure.  This adds a failure in that case.
2019-03-11 13:07:27 +05:30
thefaftek
b9ec7bb253 VMware: fail module when unable to find the user specified folder (#53474) 2019-03-08 09:39:55 +05:30
Abhijeet Kasurde
70f6cdb814
VMware: add cluster name in facts (#53056)
Fixes: #45280

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-03-06 10:15:26 +05:30
Abhijeet Kasurde
bf8ada0eb5 VMware: Fail when unable to find managed object (#53158)
Fixes: #52119

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-03-04 11:48:57 -05:00
Joseph Andreatta
3fb383b1ae VMware: Update vmware_object_role_permission to allow permissions at root folder (#50465)
* Update vmware_object_role_permission to allow permissions at root folder
* Add example for adding to root folder
2019-03-04 14:49:56 +05:30
Abhijeet Kasurde
c3777a6e54
VMware: add missing fact about IP network in firewall facts (#52554)
Fixes: #52526

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-02-25 22:43:25 +05:30
James E. King III
f2495ef0d3 Add ability to get vmware_guest_facts using vsphere schema output (#47446) 2019-02-25 06:03:40 -05:00
Abhijeet Kasurde
46d869e7bd VMware: new module: vmware_dvs_portgroup_facts (#45116)
* VMware: new module: vmware_dvs_portgroup_facts

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

* Review comments

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-02-25 05:47:09 -05:00
Abhijeet Kasurde
1a8332d2cd VMware: new module: vmware_guest_customization_facts (#38588)
This module gathers facts about customization specification created
for virtual machine.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-02-25 04:32:56 -05:00
Jose Angel Munoz
e729ad56a0 Fixing VMWare Guest Disk Creation when Using Template (#52676) 2019-02-25 14:43:53 +05:30
Christian Kotte
2f44ac4edc VMware: Fix module vmware_host (#46225)
* Add folder_name alias

The parameter should be named folder_name instead of folder to be
consistent with the other parameters cluster_name and datacenter_name.

* Fix 'A specified parameter was not correct: cnxSpec' error

The play fails when re-connecting a host with the cnxSpec argument
defined.

Just remove the cnxSpec argument definition. It isn't necessary when
re-connecting an existing host in vCenter (6.5).

* Fix ESXi host add/remove/re-connect errors

An ESXi host cannot be added, removed, or re-connected under a folder.

ESXi hosts connected under a folder, instead of a cluster, have an
object type of ComputeResource instead of HostSystem and the HostSystem
object is the first entry in the host parameter list of the
ComputeResource object.

Separate between cluster and folder actions.
2019-02-25 14:08:33 +05:30
Jake Hill
e18d5ea8b3 VMware: Add support in VMWare modules for BIOS and instance UUID's (#44399)
* Add support for changing UUID type referenced
* Update all appropriate VMware modules to include UUID type
* Add integration test for filtering on instance UUID
2019-02-25 14:07:07 +05:30
Mario Lenz
bcd6702b8a VMware: Fix KeyError in vmware_host_config_manager (#52736)
* Bug fix for vmware_host_config_manager

* Update changelogs/fragments/44561-vmware_host_config_manager-fix_key_error.yml

Co-Authored-By: mariolenz <m@riolenz.de>
2019-02-25 13:27:49 +05:30
Diane Wang
4f8cd6bf96 VMware: add new module vmware_export_ovf (#50589) 2019-02-25 09:29:45 +05:30
Michael Eaton
c5e3c80800 VMware: New Module: vmware_host_scanhba (#51440) 2019-02-22 16:45:53 +05:30
Diane Wang
d6ef07ca45 modify doc description of disk.datastore (#52695) 2019-02-20 23:35:34 -05:00
Christian Kotte
bd0cad6ed7 Improve vmware_vmkernel module (#47270)
* update description and examples
* show updated settings
* add check mode support
* Remove unused option `vlan_id`
* add vDS support
* add TCP/IP stack support
2019-02-20 21:27:35 +05:30
Abhijeet Kasurde
e8b3adeb2b
VMware: add new module vmware_host_kernel_manager (#52503)
Signed-off-by: Aaron Longchamps <a.j.longchamps@gmail.com>
2019-02-18 21:57:49 +05:30
Sayed Anisul Hoque
7d6a94e7dc Fixed typos (#52426) 2019-02-17 22:49:40 +01:00
Dag Wieers
f9ab9b4d68 Assorted pylint fixes 2019-02-15 06:54:47 -08:00
Dag Wieers
203caf2570
Fix module issues (#52209) 2019-02-15 12:57:20 +01:00
Matt Clay
3e778d3f8f Fix pycodestyle E117 issues. 2019-02-13 23:35:39 -08:00
Amol Kahat
563725ba98 Fixed typo from adress to address (#52143)
Signed-off-by: Amol Kahat <akahat@redhat.com>
2019-02-13 13:57:13 +05:30
Abhijeet Kasurde
47e1bf1862
VMware: Tag management to VMware object (#46945)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-02-12 16:53:33 +05:30
Abhijeet Kasurde
fab815fc3b
VMware: Handle duplicate VM names in vmware_vm_facts (#45412)
This fix changes facts returned from vmware_vm_facts to list of dict from
dict of dict.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-02-12 16:31:42 +05:30
Dag Wieers
031a1a5cc2 vsphere_file: New module to manage files on datastores (#48180) 2019-02-11 21:26:12 +01:00
gyorgypeter
7fa5694975 VMware: Module for managing mirroring sessions. (#50338)
This module manages the mirroring sessions, and the necessary port settings.

* Correct Documentation and CS
* PEP8, YAML, Documentation Error Fix
* Added empty return statement

Co-Authored-By: gyorgypeter <32464524+gyorgypeter@users.noreply.github.com>
2019-02-08 10:16:57 +05:30
Abhijeet Kasurde
851d248096
VMware: do create VMDK for new VMs (#51753)
While creating new VM, don't assume the VMDKs are present,
create them as we attache the disk to VM.

Possible regression fix for introduced via #45953

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-02-08 10:14:04 +05:30
Abhijeet Kasurde
d8d4dc3f52
VMware: Check for category id before assigning (#51684)
Check if user specified category exists in environment,
before assigning it to the tag creation operation.

Fixes: #51381

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-02-05 11:50:15 +05:30
Jimmy Conner
41ccc2ee26 Update vmware_guest docs about resizing disks (#51496)
vmware_guest allows the expanding of disks, but not the shrinking of disks. Saying that "resizing" is not supported is a little misleading.
2019-02-04 14:43:10 -05:00
Diane Wang
60e37c54cc VMware: add support for customize existing VM directly (#51215)
* add support for customize existing VM

* modify space issue

* move customize existing vm after reconfigure

* delete one debug line
2019-02-04 00:08:35 -05:00
mrmagooey
8eff4cae10 VMware: vmware_guest - allow existing vmdk files to be attached to guest (#45953) 2019-01-30 15:35:24 +01:00
Matt Martz
134b77961b
Add inject_ovf_env functionality for vmware_deploy_ovf (#51074)
* Add functionality to set hidden properties. Fixes #50299

* Add inject_ovf_env functionality

* Add xml declaration

* Revert "Add functionality to set hidden properties. Fixes #50299"

This reverts commit 4b41bb75207b5f88573df556cf94cfd64c843e56.

* Add changelog fragment

* Minor changes

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-01-28 09:55:21 -06:00
Karsten Jakobsen
99a4a3dc33 VMware: New module vmware_vm_host_drs_rule (#50651)
* Added new vmware module for creating DRS VM-HOST rules Host groups in a given cluster
* Fixing punctuation in lib/ansible/modules/cloud/vmware/vmware_vm_host_drs_rule.py
* Added better Docstring
* Better messaging and documentation. Removed unused lib
* Added operation to determine create or update msg
* Fixed class params to only take module. This is less error prone
* Bugfix, undefined names
2019-01-28 06:15:45 +01:00
James E. King III
9b3e74fe91 vmware_guest: improve task error handling (#49960) 2019-01-21 10:37:45 +05:30