Tomas Tomecek
30026cfb84
[cloud] module docker_image: print output on failure ( #20757 )
...
Fixes https://github.com/ansible/ansible-modules-core/issues/5161
Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
2017-02-16 09:47:18 -05:00
Matt Martz
7c00346714
Validate EXAMPLES as YAML
2017-02-15 13:01:43 -08:00
Matt Clay
cb76200c7d
PEP 8 E111 & E114 cleanup. ( #20838 )
2017-01-30 15:01:47 -08:00
Matt Clay
95789f3949
PEP 8 whitespace cleanup. ( #20783 )
...
* PEP 8 E271 whitespace cleanup.
* PEP 8 W293 whitespace cleanup.
* Fix whitespace issue from recent PR.
2017-01-27 15:45:23 -08:00
dariko
e2a1ce2916
[docker] Add compatibility with docker-py v2.0
2017-01-18 14:39:18 -05:00
Jun Guo
31526595c5
docker_image: docs: won't be pushed to private registry without push parameter. ( #19691 )
2016-12-27 08:15:12 +01:00
Andrea Tartaglia
ef391a11ec
Removed dict.iteritems() in modules. ( #18859 )
...
This is for py3 compatibility, addressed in #18506
2016-12-12 15:16:23 -08:00
Toshio Kuratomi
7319104552
Refreshed metadata for core modules
2016-12-08 11:25:35 -05:00
Asara
dddf810a19
Fixed typo in docker_image.py docs ( #5764 )
2016-12-08 11:25:34 -05:00
Patrick F. Marques
dc4cff7350
Remove duplicated option from examples
2016-12-08 11:25:28 -05:00
Chris Houseknecht
0e4b470ee2
Let docker-py handle decoding and JSON parsing of stream data. Fixes #4930 .
2016-12-08 11:25:14 -05:00
Chris Houseknecht
2514ec5056
Add buildargs parameter to support Dockerfile ARG directive. ( #4349 )
...
* Add buildargs parameter to support Dockerfile ARG directive.
* Fix doc_strings. Doc string for load_path was completely missing.
2016-12-08 11:24:48 -05:00
chouseknecht
f6b126d412
Default repository tag value to tag parameter value or 'latest'.
2016-12-08 11:24:48 -05:00
chouseknecht
3dab1785ba
Always returns changed when state present and name includes :tag.
2016-12-08 11:24:48 -05:00
Chris Houseknecht
1cf9d3e68e
Add *build* to state parameter choices. Updated deprecation message. Will be deprecated in release 2.3. Removed ( #4342 )
...
mention of *tagged* state in the force parameter doc strings. There is no *tagged* state.
2016-12-08 11:24:48 -05:00
chouseknecht
2ea29fee3f
Fix image tag operation. Allows repository in form of repo:tag. If no tag value, defaults to 'latest'.
2016-12-08 11:24:48 -05:00
Chris Houseknecht
7ffa6a43c5
Add push parameter. Let API handle registry authentication check.
2016-12-08 11:24:43 -05:00
Rodríguez, Jorge
82c26ad2d7
Do not forcibly push when building, either.
2016-12-08 11:24:39 -05:00
Rodríguez, Jorge
89e8787d65
Don't forcibly push loaded images to registry. Fixes #3763
2016-12-08 11:24:39 -05:00
Stefan Hajnoczi
38013de366
Stream image data in load_image() to avoid out-of-memory
...
Reading the entire tar file into memory can result in out-of-memory
conditions such as this traceback:
Traceback (most recent call last):
File "/tmp/ansible_YELTSu/ansible_module_docker_image.py", line 486, in load_image
self.client.load_image(image_data)
File "/usr/local/lib/python2.7/dist-packages/docker/api/image.py", line 147, in load_image
res = self._post(self._url("/images/load"), data=data)
...
File "/usr/lib/python2.7/httplib.py", line 997, in endheaders
self._send_output(message_body)
File "/usr/lib/python2.7/httplib.py", line 848, in _send_output
msg += message_body
MemoryError
Luckily docker-py's load_image(), which calls requests post(), accepts a
file-like object instead of a string. Pass in the file object to avoid
reading the full file into memory. This allows larger tar files to load
succesfully.
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
2016-12-08 11:24:36 -05:00
chouseknecht
d5b82d67b8
Fail gracefully when build path is not found.
2016-12-08 11:24:27 -05:00
chouseknecht
1d6517489b
Add doc string for container_limits. Fixed push fail message. Use path type.
2016-12-08 11:24:25 -05:00
chouseknecht
a67e9f3122
Updated version_added on options to reflect options added for 2.1.
2016-12-08 11:24:24 -05:00
chouseknecht
f2e7f1935b
Clean up and fixes post API version 1.20 testing.
2016-12-08 11:24:24 -05:00
chouseknecht
6f122bdc88
Fix github credentials
2016-12-08 11:24:24 -05:00
chouseknecht
f257fb3efa
Fix unfriendly exeption handling.
2016-12-08 11:24:23 -05:00
chouseknecht
6aa76b835a
Updater per PR comments
2016-12-08 11:24:23 -05:00
chouseknecht
fd0554c67e
Adding refactored docker_image module.
2016-12-08 11:24:23 -05:00
Andrey Gubarev
edde3b49cf
update docker_image's path param type to 'path'. Fixes #3175
2016-12-08 11:24:10 -05:00
Toshio Kuratomi
2619ec5321
Fix issues version_added and chaged => changed typo
2016-12-08 11:23:45 -05:00
Michael Schuett
e61a4f2fb5
Fix message
...
Previous fix did not actual work. This fix does however.
2016-12-08 11:23:45 -05:00
Michael Schuett
0cefc2358b
Handle connection error
...
Try and help when mac hits a connection error.
2016-12-08 11:23:45 -05:00
Michael Schuett
536bfb521a
remove .geturl()
...
Can't call geturl on a string.
2016-12-08 11:23:45 -05:00
Michael Schuett
6ff693f975
Remove faulty logic
...
Update logic after splitting the error into two separate messages.
2016-12-08 11:23:45 -05:00
Michael Schuett
5a20bb473b
Documentation Fix
...
Updated documentation to match current module state.
2016-12-08 11:23:44 -05:00
Michael Schuett
8d1f8dacba
Improve Message
...
Give user a course of action in the case where the suggestions do not
work. This will hopefully allow us to work through any further issues
much faster.
2016-12-08 11:23:44 -05:00
Michael Schuett
53294dbaaa
Improve Error Reporting
...
This will hopefully help mac users be able to quickly resolve any issues
they may find when trying to use this module.
2016-12-08 11:23:44 -05:00
Michael Schuett
75a61ae6e1
docker_image TLS
...
Check commit enables using tls when using the docker_image module. It
also removes the default for docker_url which doesn't allow us to check
for DOCKER_HOST which is a more sane default. This allows you to use
docker_image on OSX but more documentation is needed.
2016-12-08 11:23:44 -05:00
Toshio Kuratomi
98e600961f
Set a default value for DEFAULT_DOCKER_API_VERSION so we can create the AnsibleModule without docker-py
2016-12-08 11:23:29 -05:00
Greg DeKoenigsberg
18ca7aee07
Updating cloud modules with proper github author information
2016-12-08 11:23:07 -05:00
Andrew Pashkin
a960caae96
Add 'docker_api_version' to docker_image
...
By default docker-py uses latest version of Docker API. This is not
always desireable, and this patch adds option to specify version, that
should be used.
2016-12-08 11:23:02 -05:00
Pierre Baillet
eba0f12769
Support optional dockerfile name
2016-12-08 11:22:59 -05:00
Toshio Kuratomi
5336217649
Several cleanups to many modules:
...
* Fix docs to specify when python2.6+ is required (due to a library
dep). This helps us know when it is okay to use python2.6+ syntax in
the file.
* remove BabyJson returns. See #1211 This commit fixes all but the
openstack modules.
* Use if __name__ == '__main__' to only run the main part of the module
if the module is run as a program. This allows for the potential to
unittest the code later.
2016-12-08 11:22:58 -05:00
Brian Coca
018b0118dc
removed deprecated docs, not true anymore
2016-12-08 11:22:56 -05:00
Brian Coca
5c90040626
undeprecated docker_image until replacement actually arives
2016-12-08 11:22:45 -05:00
Michael DeHaan
98fdc389d0
Deprecate docker_image, use the docker module to deploy docker images, or shell out to docker to call docker build if you want from a playbook.
2016-12-08 11:22:25 -05:00
Brian Coca
32e85c0944
made subcategories for cloud modules for better organization
2016-12-08 11:22:24 -05:00