John R Barker
52a1e4a599
Fix some module author names ( #55770 )
...
* Fix some module author names
During some data analysis we noticed some typos in author lines.
2019-04-26 16:11:35 +01:00
linnil1
e9816e10bc
junos_user add condition when user = root ( #53111 )
...
* junos_user add condition when user = root
* Modify the failure message. Thanks NilashishC.
2019-03-14 23:04:47 +05:30
Trishna Guha
a41028244d
Add platform facts in network facts modules ( #51434 )
...
* Add platform facts in network facts modules
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Add nxos
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Add vyos
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Add iosxr
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Add junos
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fix pep8
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* update unit test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fix vyos_facts unittest
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fix ios_facts unittest
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fix iosxr unittests
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fix CI failure
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fix junos test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-03-11 10:56:39 +05:30
Sebastian
48107ac212
junos_config documentation missing "update" choice ( #51299 )
...
* Update junos_config.py
The current junos_config module documentation only lists "merge","override" and "replace" as update parameter choices. Looking into junos_python.py "update" is another option which is really helpful and in my opinion the most needed option.
'''
update=dict(default='merge', choices=['merge', 'override', 'replace', 'update'])
'''
+label: docsite_pr
* Fixup Update junos_config.py
The current junos_config module documentation only lists "merge","override" and "replace" as update parameter choices. Looking into junos_python.py "update" is another option which is really helpful and in my opinion the most needed option.
'''
update=dict(default='merge', choices=['merge', 'override', 'replace', 'update'])
'''
Co-Authored-By: crab86 <sgesenhoff@gmail.com>
2019-01-30 10:12:17 -05:00
Nilashish Chakraborty
77303d72ab
Add new module - junos_ping ( #50711 )
...
* WIP junos_ping
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* Added junos_ping module
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* Minor changes
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* Minor changes - 2
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* Fix CI
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* Initial tests
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* WIP tests
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* Fix spaces
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* Fixed unit tests
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* Removed unused print statements
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* Removed unused print statements
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* Update license template
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* Fixed Review Comments
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-01-29 15:36:12 +05:30
Nilashish Chakraborty
92b0cd8e0e
Add more return values to *_config modules ( #50702 )
...
* Add more return values to *_config modules
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* Add more rv
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* Exclude from cli_config docs for now
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* Add new rv docs for junos_config
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* Fix CI errors
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* Support date time for configurable backup path
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* Change logic based on configurable path
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* Remove unwanted import
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* Fix docs
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* Add filename rv
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* Change dosc filename rv
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* Make new rv code more readable
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-01-28 20:49:56 +05:30
Ganesh Nalawade
70bf9b9919
Add backup filename and dir path option for config network modules ( #50801 )
...
* Add configurable backup path option for network config modules
Fixes #50283
Fixes #32724
* Add back_options in network config module argspec
* Handle backup path options in network action plugin
* Fix review comments
* Add integration tests
* Update changelog
2019-01-24 09:36:16 +05:30
linnil1
dabdf171c5
Feature junos filter ( #44703 )
...
* Add filter in l3_interface
* Add filter in vlan
* Add filter in l2_interface
* Update version to 2.8
2019-01-23 09:36:24 +05:30
Dag Wieers
05c6ff79f9
Convert to reduced list of known types ( #50010 )
2018-12-19 07:25:30 +10:00
Ganesh Nalawade
3163780829
Add force_host and issu options support in junos_package module ( #50018 )
...
Fixes #48171
Fixes #33742
Add force_host and issu options support in junos_package module
* Add force_host option to ignore warnings while installing package
* Add issu option to enable issu feature from Ansible
2018-12-18 10:51:29 +05:30
Toshio Kuratomi
3fba006207
Update bare exceptions to specify Exception.
...
This will keep us from accidentally catching program-exiting exceptions
like KeyboardInterupt and SystemExit.
2018-12-16 15:03:19 -08:00
linnil1
8de46f5cf7
[Junos] Fix bug of setting user password ( #44660 )
...
* Add encrypted_password for junos
* Add readme for Junos user encrypted_password
* encrypted_password added in 2.8
2018-12-04 15:49:13 +00:00
Abhijeet Kasurde
bc3e7bbeba
E325 Removal - Part II ( #49196 )
...
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-11-28 13:55:52 +05:30
Sumit Jaiswal
991a9dfa12
PR to support commit check to confirm commits with JunOS ( #49054 )
...
* commit check support
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
* fixed review comments
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
* fixed review comments
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
* fixed shippable
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2018-11-28 11:27:46 +05:30
vanyasvl
80d57ece7b
Fix junos_command.py network module to support spaces in rpc args ( #48343 )
...
* Fix junos_command.py network module to support spaces in rpc args
* Fix junos_command.py network module to support spaces in rpc args
2018-11-13 10:33:48 +05:30
Brendan Jurd
ab96bbdef9
Clean up Vault docs in User Guide. ( #46188 )
...
* Fix spelling of 'separate' throughout.
* Various cleanups in the User Guide for Vault.
- Fix spelling of 'algorithm'
- Fix indentation of nested list in payload format
- Fix mysterious refernce to 'b_pkey1'.
- Fix reference to newline as '\n': the backslash is lost when rendered
to the docs website. Specify the hex value for newline instead of the
backslash escape.
* Fix formatting
* Update vault.rst
2018-09-28 10:16:58 -04:00
Nathaniel Case
285b927889
network command modules cleanup ( #45242 )
...
* Standardize _command modules
* Centralize command transformation process
* Fix check mode error test
2018-09-13 08:55:35 -04:00
linnil1
d89a1be011
Fix bug of interface-mode in Junos ( #44380 )
...
* Fix bug of interface-mode in Junos
* Fix typo. Thanks webknjaz.
2018-08-30 18:10:58 +05:30
linnil1
1651483e44
[Junos] Add l3-interface option for vlan ( #43863 )
...
* [Junos] Add l3-interface option for vlan
* Add version_added for new option
2018-08-24 18:06:27 +05:30
sward1557
e24c036057
Added junos_config note about override set format ( #43608 )
2018-08-08 15:58:28 +02:00
rmudingay
7feef1b64b
junos_user: additonal sshkey types added ( #43685 )
2018-08-06 10:20:27 +05:30
Ganesh Nalawade
35adc12c38
Update junos cliconf plugin ( #43643 )
...
* Update junos cliconf plugin
Fixes #39056
Refactor junos cliconf plugin api and other
minor changes
* Fix CI issue
* Fix CI failure
2018-08-06 10:08:05 +05:30
Jackson Isaac
f968fcd288
junos_vlan: Add Vlan ID Range in description ( #41855 )
2018-08-01 15:41:22 -04:00
Joren Vrancken
b954917761
Surround top-level function and class definitions with two blank lines.
2018-07-31 12:06:56 -07:00
Ganesh Nalawade
21dcaa4349
Handle ConnectionError exception in network modules ( #43353 )
...
* Handle ConnectionError exception in network modules
* Catch ConnectionError expection and fail module in case
expection is raised.
* Fix CI failure
2018-07-30 10:24:58 +05:30
Ganesh Nalawade
5e44189a36
Update junos_netconf module documentation ( #43291 )
...
Fixes #42719
* Add module documentation to reflect that when netconf
port is not mentioned the module by default enables
netconf on port 830 only.
2018-07-26 10:52:25 +05:30
Ganesh Nalawade
6a94090e7f
Fix junos facts integration test failures ( #42623 )
...
* Make fetching old style facts optional
and try to fetch the old style facts only when
`ofacts` value is present in `gather_facts`
* Fix in junos_facts integration test
2018-07-12 09:53:03 +05:30
Jackson Isaac
39ec12f395
junos/junos_config.py: Add RVI Example ( #41867 )
2018-07-06 14:33:16 -05:00
Jackson Isaac
0cced31795
junos_config: Add VLAN trunking example ( #41972 )
2018-07-06 14:31:15 -05:00
Ganesh Nalawade
31dd41e4c5
Fix fetching old style facts in junos_facts module ( #42336 )
...
* Fix fetching old style facts in junos_facts module
Fixes #42298
* To fetch old style facts from junos device it requires
login credentials in provider, hence while using
connection=nectonf do not delete provider values
as it might not be ignored
* Add `ofacts` as one of the options in `gather_subset`
* Minor update in documentation
* Fix CI failure
2018-07-05 18:21:44 +05:30
Ganesh Nalawade
88b966e23b
Fix junos_config confirm commit issue ( #41527 )
...
* Fix junos_config confirm commit issue
Fixes #40626
* Due to issue in ncclient commit() method for Juniper
device (ncclient/ncclient#238 )
add a workaround in junos netconf plugin to generate proper
commit-configuration xml and execute it using ncclient
generic `rpc()` method.
* Update junos_config doc
2018-06-29 15:09:55 +05:30
Nathaniel Case
9aa8c652ba
Netconf bytes fixes ( #41607 )
...
* Solve some bytes issues on iosxr
* Solve some bytes issues in junos
* Do the correct thing with tostring based on lxml or not
2018-06-22 11:50:44 -04:00
Nathaniel Case
82dfa542c2
Replace bogus (but routeable) ip addresses with RFC 5737 example addresses ( #40554 )
...
* Remove 1.1.1.1 from *_config tests
* remove from *_smoke and *_system
* Miscellaneous other tests
* Remove from module documentation as well
* Remove from unit tests as well
* Remove accidental duplication from rebase
2018-05-30 13:03:20 -04:00
Ganesh Nalawade
865f2c5990
Fix junos_config confirm timeout issue ( #40238 )
...
* Fix junos_config confirm timeout issue
* Fix unit test
2018-05-16 18:14:23 +05:30
John R Barker
7c4b91844d
More validate module fixes ( #39097 )
...
* Fix type bool DOCUMENTATION issues
2018-04-24 18:05:50 +01:00
Alicia Cozine
0ebc0b9e5a
adds FAQ TOC entry, links & examples to modules ( #38706 )
...
* adds FAQ TOC entry, links & examples to modules
* moves link to Notes, corrects examples
2018-04-18 11:41:54 -07:00
Ganesh Nalawade
67d561b0c8
Add supported connection in junos module documentation ( #38813 )
...
* Add supported connection in junos module documentation
Add supported connection type in junos module doucmentation.
* adds link to platform docs
* makes recommended connection a code snippet
* does this fix banner and command?
* does this fix the rest of the errors?
2018-04-17 10:27:29 +05:30
Deepak Agrawal
6de49f084c
doc for _config backup argument ( #38650 )
2018-04-13 12:48:49 +05:30
Dag Wieers
cdd21e2170
Clean up module documentation ( #36909 )
...
* Clean up module documentation
This PR includes:
- Removal of `default: None` (and variations)
- Removal of `required: false`
- Fixing booleans and `type: bool` where required
* Fix remaining (new) validation issues
2018-03-15 22:15:24 +01:00
John R Barker
ebc71bcb16
Network modules to link to network guide ( #37033 )
...
* Network modules to link to network guide
* Make it clear what's deprecated
* enable -> become
* Detail when provider is still needed (eAPI/NX-API)
* Link to specific sections
* rx_rate & tx_rate to link to conditional docs
2018-03-06 12:01:07 +00:00
Ganesh Nalawade
41d75783b5
Fix junos_command py3 related issues ( #36782 )
...
Fixes #36204
* tostring() input string shoulb be in byte string format
* to_ele() input is required in unicode format
2018-03-01 12:09:11 +05:30
Lindsay Hill
f207897f32
fixed conditional error message ( #36476 )
2018-02-21 11:44:18 +05:30
Nathaniel Case
dfcae9fc8e
Remove potentially confusing provider from module documentation ( #35851 )
2018-02-07 16:33:11 -05:00
Abhijeet Kasurde
1119709b56
Remove get_exception from modules
...
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-02-06 07:49:24 -08:00
Abhijeet Kasurde
6bd0fbb63c
Remove deprecated get_exception API
...
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-02-05 23:39:56 -05:00
Ganesh Nalawade
e8dd01fa5b
Add junos_l2_interface module ( #35123 )
...
* Add junos_l2_interface module
* Implementation for junos_l2_interface module
* Integration test
* Fix CI issues
* Fix review comments
2018-01-22 20:38:07 +05:30
Christian Giese
2697c0e237
junos scp module ( #31950 )
...
* junos_scp module
This module transfers files via SCP from or to remote devices running Junos.
* fix version
* add return documentation
* updated return documentation
* docu, renamed args and exceptions
+ update docu
+ rename arg download to remote_src (simitlar to copy module)
+ exception handling for transfer errors
* add tests
* add test_junos_scp_all
* update to reorganized module utils
* fix unit tests
2018-01-19 11:07:47 -05:00
John R Barker
9a32f5c889
Add missing extends_documentation_fragment ( #35013 )
...
NXOS modules need more work, though that will all be in
module_docs_fragments/nxos.py
2018-01-17 16:31:53 -05:00
John R Barker
195beebcb4
Module DOCUMENTATION should match argspec ( #34895 )
...
* Module DOCUMENTATION should match argspec
Large update of many modules so that DOCUMENTATION option name and
aliases match those defined in the argspec.
Issues identified by https://github.com/ansible/ansible/pull/34809
In addition to many typos and missing aliases, the following notable
changes were made:
* Create `module_docs_fragments/url.py` for `url_argument_spec`
* `dellos*_command` shouldn't have ever had `waitfor` (was incorrectly copied)
* `ce_aaa_server_host.py` `s/raduis_server_type/radius_server_type/g`
* `Junos_lldp` enable should be part of `state`.
2018-01-16 12:18:51 +00:00
Abhijeet Kasurde
807bebaa1f
Add missing msg in fail_json ( #33543 )
...
This fix adds msg keyword in fail_json in aws_acm_facts,
cs_host, junos_package module.
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-12-04 21:57:58 +05:30