Commit graph

586 commits

Author SHA1 Message Date
Kairo Araujo
55f0cfb2b8 New module: installp for AIX packages (#30238)
* Included module installp for AIX packages

This module works with installp AIX packages.
With this module is possible manage (install and remove) native
AIX packages using simple playbooks.

* Included module installp for AIX packages

This module works with installp AIX packages.
With this module is possible to manage (install and remove) native
AIX packages using simple playbooks.

* Fixed variable for installp parameters and docs

Followed the comments for merge
- changed variable for installp params
- doc for name and multiple packges using comma

* Replaced manual split to a list according argument_spec

Changed manual split for module.params["name"] to argument_spec

* Fixed PEP8 space after operator

Fixed PEP8 space after operator

* improved package verification and pep8

- improved package/fileset verification on AIX before to take
actions to remove or install
- Applied PEP8 and non-written conventions
- better comments and documentation

note: even If the package is already installed, even the
package/fileset is new, the module will not install it.
On AIX it is not recommended because it can break your
OS version with missen filesets.

* applied single/double quotes convention.

applied single/double quotes convention.

* Package name 'all' allowed as AIX command line

- Allowed use 'name'  as all such as AIX allows
- Removed 'global' varible regarding licence that is used
only by install()

* Documentation format issue

E302 DOCUMENTATION is not valid YAM

* Required (cosmetic) changes and improvements

* Small changes

* Silly PEP8 fixes

* Fix underscore variable
2019-01-28 16:29:46 +01:00
Dag Wieers
d2c739e9e7 A few small cosmetic changes 2019-01-22 20:03:03 -05:00
Julian Paul Dasmarinas
0622f387c4 Provide a boolean switch to enable/disable publisher refresh 2019-01-22 20:03:03 -05:00
Martin Krizek
9ec9f18b13 dnf: allow to operate on file paths (#51080)
Fixes #50843
2019-01-21 17:20:27 -05:00
Daniel Jaouen
c9bc47b354 homebrew_cask - add sudo_password parameter(#46471)
* Fixes #29403: homebrew_cask: Add SUDO_ASKPASS to module.run_command

* homebrew_cask: refactor sudo_password code

* homebrew_cask: more refactoring

* homebrew_cask: use %s instead of string addition
2019-01-21 10:15:40 -05:00
Manuel Molina Cuberos
3b5ac77a16 Preventing '/dev/tty not found' problems (#49950)
* Preventing '/dev/tty not found' problems when ' apt_repository` calls GPG in order to import keys.
2019-01-14 15:38:54 -05:00
Jordan Borean
b967f4dcc1 dnf/yum - added install_weak_deps option (#50525)
* dnf/yum - added install_weak_deps option

* skip creating weak dep packages if rpm doesn't support it

* fix rpm check for older hosts
2019-01-04 11:37:59 -05:00
Jordan Borean
63e454a4b2 dnf - fix conf_file loading (#50515) 2019-01-03 15:25:58 -05:00
Adam Miller
ca084889c7 fix order of dnf api operations so transactions don't fail (#50038)
* fix order of dnf api operations so transactions don't fail

Previously dnf.base.fill_sack() was called before
dnf.base.update_cache() which apparently breaks dnf transaction
logic as per https://bugzilla.redhat.com/show_bug.cgi?id=1658694

Fixes #49060

Signed-off-by: Adam Miller <admiller@redhat.com>

* add changelog and test case

Signed-off-by: Adam Miller <admiller@redhat.com>
2019-01-02 17:50:06 -05:00
Dag Wieers
84210e6b17
Fix typo 2018-12-21 22:49:08 +01:00
John R Barker
69abf984a1 Remove incorect author (#50191) 2018-12-20 07:22:30 -05:00
Dag Wieers
05c6ff79f9 Convert to reduced list of known types (#50010) 2018-12-19 07:25:30 +10:00
Michael Scherer
2734895c48 Do switch to apt if aptitude is not installed (#30738)
Trying to use the apt module on a freshly install 16.04 Ubuntu VM with
"ansible -m apt -a 'name=* state=latest' all" fail with this backtrace:

  Traceback (most recent call last):
    File \"/tmp/ansible_2inxygge/ansible_module_apt.py\", line 1055, in <module>
      main()
    File \"/tmp/ansible_2inxygge/ansible_module_apt.py\", line 998, in main
      upgrade(module, 'yes', force_yes, p['default_release'], use_apt_get, dpkg_options)
    File \"/tmp/ansible_2inxygge/ansible_module_apt.py\", line 759, in upgrade
      apt_cmd_path = m.get_bin_path(apt_cmd, required=True)
    File \"/tmp/ansible_2inxygge/ansible_modlib.zip/ansible/module_utils/basic.py\", line 2182, in get_bin_path
    File \"/usr/lib/python3.5/posixpath.py\", line 89, in join
      genericpath._check_arg_types('join', a, *p)
    File \"/usr/lib/python3.5/genericpath.py\", line 143, in _check_arg_types
      (funcname, s.__class__.__name__)) from None
    TypeError: join() argument must be str or bytes, not 'NoneType'

It seems that since aptitude is not installed on Xenial, so APTITUDE_CMD is None
and we later hit the bug in the upgrade function since it assume APTITUDE_CMD
is set.
2018-12-18 12:48:11 -05:00
Toshio Kuratomi
3fba006207 Update bare exceptions to specify Exception.
This will keep us from accidentally catching program-exiting exceptions
like KeyboardInterupt and SystemExit.
2018-12-16 15:03:19 -08:00
Adam Miller
0eabb8097b
Fix yum/dnf handling of URIs that don't end in .rpm (#49912)
Fixes #49727

Signed-off-by: Adam Miller <admiller@redhat.com>
2018-12-14 13:44:40 -06:00
Giuseppe Mancuso
d29f647f09 issue with activation_key and proxy on subscription-manager (#42624)
* Update redhat_subscription.py

I need to use a proxy server/user/password also if I user an activation_key

* remove spaces
2018-12-14 12:27:58 -05:00
Greg Hellings
af5d84b70b Properly report install failures from dnf module (#49760)
Reporting of install failures was improperly guarded behind a list of
packages to install when the first element changed in a list was found.
This lead to the dnf module silently failing at times when it should not
fail.

Fixes issue 49759
2018-12-13 05:22:53 -05:00
Richlv
46d2a3eddc Update rhsm_repository.py (#49480)
typo fixes
2018-12-12 13:37:11 -06:00
WhyIsThisOpen
7bdca72713 rhn_register fixes for username and password when unregistering
- Require username and password for unregistering and avoid "cannot marshal None unless allow_none is enabled" error when using an activation key and no channels specified.
- Update test fixtures and add changelog


Co-authored-by: WhyIsThisOpen <WhyIsThisOpen@users.noreply.github.com>
2018-12-12 11:32:48 -05:00
James Tanner
b6220ce16a rhn_channel lacks sufficient testing and supportability 2018-12-07 11:13:19 -08:00
Sam Doran
3d5d0d355f Add purge feature to rhsm_repository (#48123)
This feature makes it easy to enforce exactly which repos are enabled on a managed system without the need for multiple tasks.
2018-12-07 11:53:42 -05:00
Alexander Bethke
27fd8e4dc6 Fix two regressions in flatpak and flatpak_remote modules (#49651)
* Fix python 3 compatibility in flatpak_remote module

* Fix flatpak module for recent versions of flatpak

* Add reminder for contributors to run integration tests manually

There has been several Python version compatibility regressions
introduced into the module which could have been avoided by the
integration tests.
2018-12-07 11:38:42 -05:00
Jordan Borean
198f1e1bea
Revert "Fixes #49362 module dnf: install python3-dnf preferably over python2-dnf. (#49402)" (#49633)
This reverts commit 3247eec97a.
2018-12-07 08:29:12 +10:00
Sean Myers
9434f8608a Add rhsm_repository_release module (#43211)
* Add rhsm_repository_release module

* bump ansible version_added

* Fix imports in rhsm_repository_release unit test
2018-12-06 20:16:18 +00:00
Robert de Bock
3247eec97a Fixes #49362 module dnf: install python3-dnf preferably over python2-dnf. (#49402)
* Create python3and2

Adding tests to see if dnf still works when python-2 and python-3 are installed.

* Update main.yml

Include the tests that run on python 2 and python 3, based on the package manager.

* Update dnf.py

Use python3-dnf by default, otherwise python2-dnf.

* Rename python3and2 to python3and2.yml

Rename.
2018-12-04 16:43:45 -05:00
Mikhail
2f8d235ce5 Add apt_repo module (#49187) 2018-12-04 16:37:42 +00:00
Adam Miller
378cc9668c dnf module load/init dnf pkg mgr plugins properly (#49278)
* dnf module load/init dnf pkg mgr plugins properly

Fixes #45940

Signed-off-by: Adam Miller <admiller@redhat.com>
2018-11-30 10:00:33 -08:00
Abhijeet Kasurde
bc3e7bbeba
E325 Removal - Part II (#49196)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-11-28 13:55:52 +05:30
tchernomax
d14dee9ceb pacman: if 'upgrade' is used, 'name' isn't apply (#48854)
fix #31713
2018-11-27 14:36:25 +00:00
ivovangeel
e7104a445b Fix incorrect 'installed' status setting in dnf.py (#48931) 2018-11-26 18:08:36 -05:00
John R Barker
ba3f512d8a updated version_added 2018-11-24 12:54:15 -05:00
Derek Ditch
29041f89e2 Removed choices for boolean options, as requested 2018-11-24 12:54:15 -05:00
Derek Ditch
48c5930836 Adds support for proxy authentication and repoview enablement. 2018-11-24 12:54:15 -05:00
Arnaud Venturi
ad1180b22f Replace some likely forgotten yum by dnf (#48988)
I'm not 100% certain this change is relevant for the filename, but it would make sense, so I'll let you confirm.

+label: docsite_pr
2018-11-23 16:10:28 +00:00
Christopher Brown
7f7062580e Update docs with rhsm note (#48928)
* Update docs with rhsm note

redhat_subscription is the module for handling registration of modern Red Hat systems. This commit adds a note indicating that unless people are using RHEL 5 etc, they probably want that module instead.

+label: docsite_pr

* Make redhat_subscription a link to the module docs
2018-11-23 15:48:08 +00:00
John R Barker
8f41270a01
Bulk fix DOCUMENTATION.author (Part 3) (#48990) 2018-11-21 15:10:41 +00:00
John R Barker
3fcc564bbb
Bulk fix DOCUMENTATION.author (Part 1) (#48934)
* Bulk fix DOCUMENTATION.author
2018-11-20 19:31:35 +00:00
Adam Miller
41176b5e0f fix group-missing/invalid-group detection
Signed-off-by: Adam Miller <admiller@redhat.com>
2018-11-19 10:13:07 -08:00
Adam Miller
23b60035a1 fix up sanity tests and with_modules conditional
Signed-off-by: Adam Miller <admiller@redhat.com>
2018-11-19 10:13:07 -08:00
Adam Miller
4a06e95671 dnf to support modularity module appstream specs
Fixes #48743

Signed-off-by: Adam Miller <admiller@redhat.com>
2018-11-19 10:13:07 -08:00
tchernomax
943edb3319 apt: add policy_rc_d option (#47191) 2018-11-19 14:45:48 +00:00
Maciej Delmanowski
c7e2226035 Do not require TTY for 'apt-key' operations (#48580)
The 'gpg' command supports the '--no-tty' option, which disables any use
of a TTY during its execution. This parameter is sometimes required for
non-interactive operation to avoid any questions for the user.

The 'apt-key adv' command can pass additional parameters to the
underlying 'gpg' command. This patch adds the '--no-tty' option to avoid
issues with APT key imports when Ansible pipelining active, which
disables the use of a dedicated TTY.
2018-11-19 12:40:06 +00:00
Pilou
7f98a8db12 BOTMETA.yml and module metadata: fix case authors (#46051)
* botmeta: fix GitHub ID case

* module authors: fix GitHub ID case

* replace CloudEngine-Ansible by submitter GitHub ID
2018-11-19 11:47:14 +00:00
Eric P
6800559d61 Fix a part of the example (#48851)
<!--- Your description here -->

+label: docsite_pr
2018-11-19 09:33:20 +01:00
tchernomax
bf2ef364b7 pacman: add & deprecate options (#30482)
Add:

 * extra_args
 * update_cache_extra_args
 * upgrade_extra_args

which add flexibility.

Deprecate `recurse` which is redundant with extra_args.

`force` is also redundant but is kept for module ergonomics.
2018-11-16 12:27:28 -05:00
Adam Miller
34fc66185e make yum update_only option actually work (#47942)
* make yum update_only option actually work

Fixes #40615

Signed-off-by: Adam Miller <admiller@redhat.com>

* fix changlog fragment for sanity check

Signed-off-by: Adam Miller <admiller@redhat.com>

* only attempt an update when there are packages to update

Signed-off-by: Adam Miller <admiller@redhat.com>

* fix logic to properly handle the precedent of operations

Signed-off-by: Adam Miller <admiller@redhat.com>

* remove q debug statements

Signed-off-by: Adam Miller <admiller@redhat.com>
2018-11-13 15:04:19 -05:00
Jason Walsh
96cdc9ec06 Add release argument for redhat_subscription (#47888) 2018-11-09 17:19:06 -05:00
Sam Doran
1e3b704ff1
Prevent duplicate entries in rhsm_repository module (#48107)
* Complie regular expressions for better performance

* Skip on empty lines

This fixes a bug where the previous repo would be inserted in the result twice since an empty line did not match any of the conditions that would exit the loop iteration.
2018-11-07 17:49:12 -05:00
AndyG
20e1a33959 Update yum.py (#47749)
add explanation why you must use "shell: yum clean all" and why it won't be included in the yum module as per https://github.com/ansible/ansible/pull/31450#issuecomment-352889579
2018-11-07 09:27:31 -06:00
Adam Miller
091fb1dc3f yum also parse obsolete package output (#45365)
* yum also parse obsolete package output

This is a rebase of the patch originally proposed in
https://github.com/ansible/ansible/pull/40001 by machacekondra

Fixes #39978

Signed-off-by: Adam Miller <admiller@redhat.com>

* properly parse the obsoletes, provide a new output entry, add changelog

Signed-off-by: Adam Miller <admiller@redhat.com>

* make pep8 happy

Signed-off-by: Adam Miller <admiller@redhat.com>

* remove q debugging output

Signed-off-by: Adam Miller <admiller@redhat.com>
2018-11-06 16:07:50 -05:00