Matt Clay
442af3744e
Miscellaneous pylint fixes.
...
The following rules are no longer disabled:
- bad-format-string
- duplicate-key
- lost-exception
- trailing-newlines
- unexpected-keyword-arg
- useless-suppression
- using-constant-test
2017-09-13 01:53:08 -07:00
Mike Wiebe
cef7ed0310
Fix nxos_mtu nxapi failure ( #30153 )
2017-09-13 10:51:46 +05:30
Mike Wiebe
f973f93963
Fix nxos_smu error ( #30157 )
2017-09-12 22:17:07 +01:00
Trishna Guha
5b1c91bf19
nxos_system parse name_servers fix ( #29944 )
...
* nxos_system parse name_servers fix
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fix nxos_system tests
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-09-12 13:25:01 +05:30
Trishna Guha
588bddbc35
nxos_banner CI fix ( #29134 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-09-08 19:33:41 +05:30
Nathaniel Case
f84ff216b6
Generalize nxos_bgp event-history detection ( #28890 )
...
* More general handling of event-history
* Update unit tests
2017-09-06 17:37:44 -04:00
Nathaniel Case
8bfdbd0f73
nxos_bgp_neighbor: Fix regex &report warnings ( #28888 )
...
* Fix over-detection of log-neighbor-as
* Report nxos warnings
* Update nxos_bgp_neighbor unit tests to test remove-private-as
2017-09-01 15:17:42 -04:00
Mike Wiebe
fb1aa54341
Rel240/fix nxos interface ospf ( #28898 )
...
* Fixes 28897 nxos_interface_ospf idempotence
* Handle all characters upper or lower with tests
2017-09-01 11:07:18 -04:00
Nathaniel Case
ae6d27fa29
Revert "Bring nxos_snmp_host in line"
...
This reverts commit 43247c8dfe
.
Revert "Bring nxos_snmp_community in line"
This reverts commit 0df77408d7
.
Revert "Clean up nxos_snmp_contact & nxos_snmp_location"
This reverts commit 9e4cdd2fce
.
I should probably not be up this early
2017-09-01 08:00:00 -04:00
Nathaniel Case
43247c8dfe
Bring nxos_snmp_host in line
2017-09-01 07:43:05 -04:00
Nathaniel Case
0df77408d7
Bring nxos_snmp_community in line
2017-09-01 07:15:24 -04:00
Nathaniel Case
9e4cdd2fce
Clean up nxos_snmp_contact & nxos_snmp_location
2017-09-01 07:12:49 -04:00
rahushen
07c1d7e1ca
update nxos_facts to handle n3k power table ( #28891 )
...
* handle power table for n3k
2017-08-31 14:59:14 -04:00
Nathaniel Case
74daf2381b
Fix nxos_config save
parameter ( #28838 )
...
Also fix saving in general
2017-08-31 10:01:19 -04:00
Mike Wiebe
d9fc3def94
Fixes #28779 eth_mode key error ( #28782 )
...
* Fixes #28779 eth_mode key error
* Remove unused get_config references
* Addressed PR comment
2017-08-29 17:07:46 -04:00
Nathaniel Case
64dac346c9
Fix nxos_pim_interface dr-priority handling ( #28472 )
...
* Fix nxos_pim_interface dr-priority handling
* Prefer execute_show over `| json`
* Mock get_config
* Fix sparse-mode detection
2017-08-29 14:42:09 -04:00
rahushen
2cf836772d
Add passive_interface property to nxos_ospf_vrf module ( #28288 )
...
* add passive_interface property to nxos_ospf_vrf module
* Add version_added for
2017-08-29 11:31:11 -04:00
Nathaniel Case
40907d7db2
Fix detection of associate-vrf parameter ( #28725 )
2017-08-29 09:47:27 -04:00
Nathaniel Case
862cde5e82
[WIP] Fix nxos_banner ( #28607 )
...
* Fix `'state': 'absent'`
* Replace idempotence tests with references
* Fix issues with nxos_banner
2017-08-28 17:09:54 -04:00
Trishna Guha
0a8ec4ddef
fix nxos_igmp_interface output ( #28735 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-08-28 17:06:30 -04:00
Mike Wiebe
3d46258cff
Refactor/fix nxos_nxapi to use show run ( #28675 )
...
* Refactor/fix nxos_nxapi to use show run
* Fix unit tests
* Python 3 compatibility
2017-08-28 15:00:56 -04:00
Nathaniel Case
fbeb3b9ac5
Nxos ping ( #28665 )
...
* Update documentation & results, clean up code
* Change numeric results to int/float
2017-08-25 11:45:46 -04:00
Nathaniel Case
ada7f248c0
Add 'Tested on' string to NX-OS modules ( #28531 )
2017-08-24 08:27:39 -04:00
Nathaniel Case
e1def05ba2
fix networking *_command check_mode ( #28407 )
...
* Fix check_mode in nxos_command
* Fix check_mode for ios_command
* fix check_mode for iosxr_command
* Fix check_mode in vyos_command
* Fix check_mode in eos_command
* Fix check_mode in junos_config
2017-08-22 14:02:55 -04:00
Nathaniel Case
96abfde189
Fix idempotence for nxos_vrf_af ( #28419 )
2017-08-22 14:02:01 -04:00
Mike Wiebe
ec11cd2696
nxos_bgp_neighbor_af fix problem with advertise-map properties ( #28413 )
...
* Fix problem with advertise-map properties
* Change limit_to back to run all tests
* Fix unit tests
* Move advertise_map out of get_custom_value
2017-08-21 15:28:02 -04:00
David Kretch
beed59f303
Fix trailing space in ec2_vol example, fix 'the the' typos ( #28440 )
...
* Fix 'the the' typos, fix 'pahting' filename typo
* Change 'the the' typos to a single 'the'.
* Change `playbook_pahting.rst` to `playbook_pathing.rst`.
* Delete trailing space in ec2_vol example
Delete the trailing space in `instance: "{{ item.id }} "`, which makes the
example fail when run because it looks for instance "i-xxxx ".
2017-08-19 23:00:51 +02:00
Nathaniel Case
33f342435a
Attempt to detect and abort when 'fex-fabric' is present ( #28342 )
2017-08-18 16:13:12 -04:00
Nathaniel Case
db5d799122
Fix nxos_pim idempotence ( #28348 )
2017-08-18 09:47:41 -04:00
David Newswanger
b818e986b6
Change network *_user modules to use configured_password to set a users password ( #28187 )
...
* WIP, update eos_user args
* refactor password for ios_user
* add eos tests, fix ios tests
* fixed password check
* refactor iosxr_user password
* fixed password arg for nxos
* [WIP] fix vyos_user password
* fix vyos tests
* update docs for net_user
* fix typo
* fix eos tests
* add warning when attempting to use password arg
* fix sanity/unit tests
* fix eos unit tests
* fix vyos_user aggregate
* fix typo in eos documentation string
* re add configured_password to vyos tests after rebase
2017-08-17 19:06:44 +05:30
Peter Sprygada
6886153b54
refactors nxos_vrf_af module ( #28208 )
...
* refactors nxos_vrf_af module
fixes #27595
* fix up unit test cases
* add commands to result dict
* add route-target on afi create
* adds deprecation note to safi argument
2017-08-16 10:11:12 -04:00
Toshio Kuratomi
d8b1cb9a63
Assign network modules maintained by the network team the network metadata
2017-08-15 23:12:08 -07:00
Toshio Kuratomi
f203ca7907
Update metadata to 1.1
2017-08-15 23:12:08 -07:00
David Newswanger
b7d886840b
standardized agreggate as arg, and collection and users as aliases for user modules ( #28244 )
2017-08-16 09:31:25 +05:30
saichint
064ab7a92d
fix for remove idempotent issue ( #28226 )
2017-08-15 13:14:40 -04:00
saichint
d69440c4ef
Fix nxos_vpc issues ( #28188 )
...
* fix for nxos_vpc issues
* fix unit tests
* clean documentation
2017-08-15 12:08:55 -04:00
Nathaniel Case
1d13624eae
Clean up nxos_aaa_server ( #28177 )
...
* cleanup nxos_aaa_server
* Specify nxos_aaa_server output format
Fixes #27289
2017-08-15 12:08:03 -04:00
saichint
9d84a4e530
fix for nxos_ospf_vrf invalid cmd and ntp errors ( #27977 )
...
* fix for nxos_ospf_vrf invalid cmd
* fix for nxos_ntp issues
2017-08-14 16:09:16 -04:00
Nathaniel Case
19a6000d97
Fix nxos_bgp_af networks parameter ( #28169 )
...
* Split 'networks' and 'redistribute' in get_value
* Add missing `'` in docs
2017-08-14 15:18:10 -04:00
rahushen
b74300b657
Additional fix for #27167 : port-channel interface idempotence ( #27979 )
2017-08-14 11:44:12 -04:00
Nathaniel Case
820d7e805a
Streamline nxos_smu ( #28030 )
2017-08-14 10:54:50 -04:00
rahushen
b9c3329950
nxos_ip_interface: Fixes for #27170 , #27172 ( #27935 )
...
* Fixes for #27170 , #27172
* Add nxos_ip_interface IT tests
* For ipv6 check if ip address configured before doing a no ip address
2017-08-14 10:16:08 -04:00
David Newswanger
cfda267b2b
fixes pipe issue ( #28127 )
2017-08-14 17:21:32 +05:30
Trishna Guha
60ce6438e3
fix nxos_overlay_global idempotence ( #28150 )
...
* fix nxos_overlay_global idempotence
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* modify nxos_overlay_global unittest
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-08-14 16:09:53 +05:30
David Newswanger
a01aa6e9df
Fix structured output not supported in nxos_pim_interface ( #28125 )
...
* fixed unstructured error
* fix unit tests so they accept commands in dictionary form
2017-08-14 12:34:05 +05:30
Trishna Guha
aef4e3d8fa
fix nxos_snapshot ( #27993 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-08-11 12:16:37 -04:00
Peter Sprygada
17a259a163
fixes command to be sent over nxapi for nxos_file_copy ( #28029 )
...
fixes #27347
2017-08-11 12:14:52 -04:00
Nathaniel Case
0464a21a85
Fix nxos_snmp_contact, others ( #28000 )
...
* Fix nxos_snmp_contact
Fixes #27714
* Fix nxos_snmp_community
Fixes #27711
* Fix nxos_install_os
Fixes #27604
* Update nxos_ntp_auth
Fixes #27521
* Fix nxos_igmp_snooping
Fixes #27501
2017-08-11 10:12:43 -04:00
David Newswanger
d0485779e8
nxos_smu: fix Structured output unsupported error in nxapi ( #27976 )
...
* fixed structured output unsupported error
2017-08-10 14:12:15 -04:00
Nathaniel Case
ed8a5af3dc
nxos_bgp: Fix idempotence for event-history ( #27329 )
...
* Fix idempotence for event-history
* `event-history detail` defaults to `False`, the rest to `size_small`
2017-08-10 08:55:43 -04:00