James Cassell
bc4ef99533
standardize TLS connection properties ( #54315 )
...
* openstack: standardize tls params
* tower: tower_verify_ssl->validate_certs
* docker: use standard tls config params
- cacert_path -> ca_cert
- cert_path -> client_cert
- key_path -> client_key
- tls_verify -> validate_certs
* k8s: standardize tls connection params
- verify_ssl -> validate_certs
- ssl_ca_cert -> ca_cert
- cert_file -> client_cert
- key_file -> client_key
* ingate: verify_ssl -> validate_certs
* manageiq: standardize tls params
- verify_ssl -> validate_certs
- ca_bundle_path -> ca_cert
* mysql: standardize tls params
- ssl_ca -> ca_cert
- ssl_cert -> client_cert
- ssl_key -> client_key
* nios: ssl_verify -> validate_certs
* postgresql: ssl_rootcert -> ca_cert
* rabbitmq: standardize tls params
- cacert -> ca_cert
- cert -> client_cert
- key -> client_key
* rackspace: verify_ssl -> validate_certs
* vca: verify_certs -> validate_certs
* kubevirt_cdi_upload: upload_host_verify_ssl -> upload_host_validate_certs
* lxd: standardize tls params
- key_file -> client_key
- cert_file -> client_cert
* get_certificate: ca_certs -> ca_cert
* get_certificate.py: clarify one or more certs in a file
Co-Authored-By: jamescassell <code@james.cassell.me>
* zabbix: tls_issuer -> ca_cert
* bigip_device_auth_ldap: standardize tls params
- ssl_check_peer -> validate_certs
- ssl_client_cert -> client_cert
- ssl_client_key -> client_key
- ssl_ca_cert -> ca_cert
* vdirect: vdirect_validate_certs -> validate_certs
* mqtt: standardize tls params
- ca_certs -> ca_cert
- certfile -> client_cert
- keyfile -> client_key
* pulp_repo: standardize tls params
remove `importer_ssl` prefix
* rhn_register: sslcacert -> ca_cert
* yum_repository: standardize tls params
The fix for yum_repository is not straightforward since this module is
only a thin wrapper for the underlying commands and config. In this
case, we add the new values as aliases, keeping the old as primary,
only due to the internal structure of the module.
Aliases added:
- sslcacert -> ca_cert
- sslclientcert -> client_cert
- sslclientkey -> client_key
- sslverify -> validate_certs
* gitlab_hook: enable_ssl_verification -> hook_validate_certs
* Adjust arguments for docker_swarm inventory plugin.
* foreman callback: standardize tls params
- ssl_cert -> client_cert
- ssl_key -> client_key
* grafana_annotations: validate_grafana_certs -> validate_certs
* nrdp callback: validate_nrdp_certs -> validate_certs
* kubectl connection: standardize tls params
- kubectl_cert_file -> client_cert
- kubectl_key_file -> client_key
- kubectl_ssl_ca_cert -> ca_cert
- kubectl_verify_ssl -> validate_certs
* oc connection: standardize tls params
- oc_cert_file -> client_cert
- oc_key_file -> client_key
- oc_ssl_ca_cert -> ca_cert
- oc_verify_ssl -> validate_certs
* psrp connection: cert_trust_path -> ca_cert
TODO: cert_validation -> validate_certs (multi-valued vs bool)
* k8s inventory: standardize tls params
- cert_file -> client_cert
- key_file -> client_key
- ca_cert -> ca_cert
- verify_ssl -> validate_certs
* openshift inventory: standardize tls params
- cert_file -> client_cert
- key_file -> client_key
- ca_cert -> ca_cert
- verify_ssl -> validate_certs
* tower inventory: verify_ssl -> validate_certs
* hashi_vault lookup: cacert -> ca_cert
* k8s lookup: standardize tls params
- cert_file -> client_cert
- key_file -> client_key
- ca_cert -> ca_cert
- verify_ssl -> validate_certs
* laps_passord lookup: cacert_file -> ca_cert
* changelog for TLS parameter standardization
2019-03-28 00:19:28 -05:00
Richlv
9093ca1f3b
Improve style and fix typos in the Zabbix module titles and descriptions ( #50575 )
2019-01-06 01:33:54 +01:00
John R Barker
75407d3e43
Validate DOCUMENTATION.author ( #48993 )
...
* Validate DOCUMENTATION.author
Ensure that author line includes a GitHub account
2018-11-21 17:29:29 +00:00
John R Barker
3fcc564bbb
Bulk fix DOCUMENTATION.author (Part 1) ( #48934 )
...
* Bulk fix DOCUMENTATION.author
2018-11-20 19:31:35 +00:00
Yixin Xu
5a35907b71
zabbix_host: fix link template error ( #46521 )
...
* add host interface before link template
2018-10-05 10:40:30 -04:00
Dag Wieers
b6b36276a4
Clean up BOTMETA.yml ( #44574 )
...
This PR includes:
- Removal of maintainers that are listed as author in the module
- Removal of entries that do not extend the original author list
- Move ignored-statement to namespace/directory (where useful)
- In some cases, fix the authors-list or add missing github id
We end up with a list of exceptions/additions and a large set of
namespace/directory maintainers or team of maintainers.
Some entries could be further improved by discussing with some
maintainers.
2018-08-24 19:43:35 -04:00
Dusan Matejka
d43b2b54d5
Fixed incompatible unicode and int comparison in zabbix_host module when using proxy option ( #43097 )
2018-07-22 07:19:21 -04:00
Selivanov Pavel
b47c04a70e
Fixes #38985 ( #39070 )
...
Changing interface dictionary while iterating over interface.keys() produced "RuntimeError: dictionary changed size during iteration"
2018-04-22 04:03:31 -04:00
Gaudenz Steinlin
0ea7329553
Fix zabbix_host for Zabbix Server versions < 3.0 ( #38665 )
...
The tls_* parameters are not present in Zabbix Server versions prior to
3.0. Thus the API response does not contain these keys and the
zabbix_host module failed. This commit adds checks if the parameters are
present in the API response and otherwise just completely ignores these
parameters. The documentation already states that they are not supported
for Zabbix Server versions below 3.0.
2018-04-16 17:57:57 -04:00
Dag Wieers
cdd21e2170
Clean up module documentation ( #36909 )
...
* Clean up module documentation
This PR includes:
- Removal of `default: None` (and variations)
- Removal of `required: false`
- Fixing booleans and `type: bool` where required
* Fix remaining (new) validation issues
2018-03-15 22:15:24 +01:00
Richlv
4a5809f111
Update zabbix_host.py ( #36127 )
...
fix tls documentation; minor style fixes
2018-02-19 11:25:38 -05:00
Eike Frost
eeeea1406b
zabbix_host: add interface definition error checking / defaults ( #35366 )
...
* add checking of interfaces, providing defaults or errors if required keys are not defined
* fix so that iteration of interfaces only happens if defined
2018-01-27 05:06:13 -05:00
Eike Frost
bf8439e2a0
Zabbix host ipmi ( #33718 )
...
* Update zabbix_host documentation (extend ipmi_-documentation, and update style to be consistent on the rest while we are at it)
* Remove ipmi_parameters being added to the API call when not required
* remove optional parameters from add_host, as well
2017-12-11 08:41:35 -05:00
Kirill German
4e9aa8bea2
Adding ipmi settings for zabbix host ( #33435 )
...
* adding ipmi settings zabbix host
* adding ipmi settings zabbix host
* adding ipmi settings zabbix host
fix misspelling
* ipmi settings for zabbix host
add newline at eof
* update documentation and example section
* fix documentation
* fix documentation
delete 'choises'
* delete whitespaces
* fix default ipmi settings
2017-12-07 18:47:33 +00:00
Eike Frost
9b5bd4094f
zabbix_host: fix various idempotency problems ( #33138 )
...
* reorder interfaces handling for force=no, making sure it works when no interfaces are specified in the module parameters
when no interfaces are specified on update, use existing interfaces obtained from API.
check whether visible_name is set in check_all_properties; if not set as module parameter, no comparison is necessary.
Check if description is set as module parameter before comparing as well
* link_templates need the same treatment
* add inventory update checks and simplify update procedure
* make specifying proxy optional on update (keeping it as is when not specified), as well
* pep8 fixes
* add tls_*-checks for updates and make tls_*-options actually optional
2017-11-28 09:37:50 -05:00
Eike Frost
50c9f91060
zabbix_host: make host_groups actually optional on update ( #33099 )
...
* When updating a host, host_groups need not necessarily be specified.
* Also set host_groups for later equivalency tests
2017-11-21 07:19:01 +01:00
Eike Frost
560a3c3681
zabbix_host: Fix doc implying creation would work when in reality only an update does ( #33095 )
2017-11-20 17:34:13 +01:00
Eike Frost
74bd13727a
move zabbix modules into their own namespace below monitoring/ ( #31992 )
2017-10-21 10:07:51 +02:00
