James Cassell
bc4ef99533
standardize TLS connection properties ( #54315 )
...
* openstack: standardize tls params
* tower: tower_verify_ssl->validate_certs
* docker: use standard tls config params
- cacert_path -> ca_cert
- cert_path -> client_cert
- key_path -> client_key
- tls_verify -> validate_certs
* k8s: standardize tls connection params
- verify_ssl -> validate_certs
- ssl_ca_cert -> ca_cert
- cert_file -> client_cert
- key_file -> client_key
* ingate: verify_ssl -> validate_certs
* manageiq: standardize tls params
- verify_ssl -> validate_certs
- ca_bundle_path -> ca_cert
* mysql: standardize tls params
- ssl_ca -> ca_cert
- ssl_cert -> client_cert
- ssl_key -> client_key
* nios: ssl_verify -> validate_certs
* postgresql: ssl_rootcert -> ca_cert
* rabbitmq: standardize tls params
- cacert -> ca_cert
- cert -> client_cert
- key -> client_key
* rackspace: verify_ssl -> validate_certs
* vca: verify_certs -> validate_certs
* kubevirt_cdi_upload: upload_host_verify_ssl -> upload_host_validate_certs
* lxd: standardize tls params
- key_file -> client_key
- cert_file -> client_cert
* get_certificate: ca_certs -> ca_cert
* get_certificate.py: clarify one or more certs in a file
Co-Authored-By: jamescassell <code@james.cassell.me>
* zabbix: tls_issuer -> ca_cert
* bigip_device_auth_ldap: standardize tls params
- ssl_check_peer -> validate_certs
- ssl_client_cert -> client_cert
- ssl_client_key -> client_key
- ssl_ca_cert -> ca_cert
* vdirect: vdirect_validate_certs -> validate_certs
* mqtt: standardize tls params
- ca_certs -> ca_cert
- certfile -> client_cert
- keyfile -> client_key
* pulp_repo: standardize tls params
remove `importer_ssl` prefix
* rhn_register: sslcacert -> ca_cert
* yum_repository: standardize tls params
The fix for yum_repository is not straightforward since this module is
only a thin wrapper for the underlying commands and config. In this
case, we add the new values as aliases, keeping the old as primary,
only due to the internal structure of the module.
Aliases added:
- sslcacert -> ca_cert
- sslclientcert -> client_cert
- sslclientkey -> client_key
- sslverify -> validate_certs
* gitlab_hook: enable_ssl_verification -> hook_validate_certs
* Adjust arguments for docker_swarm inventory plugin.
* foreman callback: standardize tls params
- ssl_cert -> client_cert
- ssl_key -> client_key
* grafana_annotations: validate_grafana_certs -> validate_certs
* nrdp callback: validate_nrdp_certs -> validate_certs
* kubectl connection: standardize tls params
- kubectl_cert_file -> client_cert
- kubectl_key_file -> client_key
- kubectl_ssl_ca_cert -> ca_cert
- kubectl_verify_ssl -> validate_certs
* oc connection: standardize tls params
- oc_cert_file -> client_cert
- oc_key_file -> client_key
- oc_ssl_ca_cert -> ca_cert
- oc_verify_ssl -> validate_certs
* psrp connection: cert_trust_path -> ca_cert
TODO: cert_validation -> validate_certs (multi-valued vs bool)
* k8s inventory: standardize tls params
- cert_file -> client_cert
- key_file -> client_key
- ca_cert -> ca_cert
- verify_ssl -> validate_certs
* openshift inventory: standardize tls params
- cert_file -> client_cert
- key_file -> client_key
- ca_cert -> ca_cert
- verify_ssl -> validate_certs
* tower inventory: verify_ssl -> validate_certs
* hashi_vault lookup: cacert -> ca_cert
* k8s lookup: standardize tls params
- cert_file -> client_cert
- key_file -> client_key
- ca_cert -> ca_cert
- verify_ssl -> validate_certs
* laps_passord lookup: cacert_file -> ca_cert
* changelog for TLS parameter standardization
2019-03-28 00:19:28 -05:00
Matt Clay
02c9f70898
Fix sanity test failures (pep8).
2019-02-15 09:25:20 -08:00
Dag Wieers
677c04c01d
Sanity fixes to parameter types ( #52325 )
2019-02-15 16:58:58 +01:00
Matt Clay
0a461380a3
Fix incorrect use of is
for comparisons.
...
See https://bugs.python.org/issue34850 for details.
2019-02-12 16:33:13 -08:00
Daniel Speichert
d34cf93f1a
Migrate from MySQLdb to PyMySQL ( #40123 )
...
* Migrate from MySQLdb to PyMySQL
* Deduplicate driver loading and failure message
* Explain requirements
* Apply requirements docs change to proxysql too
* Add changelog
2018-09-19 08:44:05 -07:00
Toshio Kuratomi
f203ca7907
Update metadata to 1.1
2017-08-15 23:12:08 -07:00
Will Thames
dbf9a65c05
Improve error messages when MySQLdb is not installed ( #27871 )
...
The python package is called MySQL-python in pypi, and
reporting this rather than mysqldb makes resolving the
problem far easier.
2017-08-08 12:59:51 -04:00
Toshio Kuratomi
0b9a78f0b3
Remove wildcard, add boilerplate and get rid of get_exception
...
* smaller collections of database modules
* Some of the smaller collections of network modules
2017-07-31 13:51:38 -07:00
Abhijeet Kasurde
9fbbb5e10f
Pep8 fixes for mysql module ( #23923 )
...
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-04-26 12:56:35 +01:00
Matt Martz
3164e8b561
E501 fixes ( #22879 )
2017-03-22 20:50:28 -05:00
Toshio Kuratomi
eb1214baad
New metadata 1.0 ( #22587 )
...
Changes to the metadata format were approved here:
https://github.com/ansible/proposals/issues/54
* Update documentation to the new metadata format
* Changes to metadata-tool to account for new metadata
* Add GPL license header
* Add upgrade subcommand to upgrade metadata version
* Change default metadata to the new format
* Fix exclusion of non-modules from the metadata report
* Fix ansible-doc for new module metadata
* Exclude metadata version from ansible-doc output
* Fix website docs generation for the new metadata
* Update metadata schema in valiate-modules test
* Update the metadata in all modules to the new version
2017-03-14 09:07:22 -07:00
Matt Clay
10d9318de7
PEP 8 indent cleanup. ( #20800 )
...
* PEP 8 E121 cleanup.
* PEP 8 E126 cleanup.
* PEP 8 E122 cleanup.
2017-01-29 07:28:53 +00:00
Toshio Kuratomi
7319104552
Refreshed metadata for core modules
2016-12-08 11:25:35 -05:00
Sam Doran
e0cfe14901
Change examples syntax on mysql_variables module
2016-12-08 11:25:28 -05:00
Michael Scherer
09066f1518
Convert all databases modules to python3 and 2.4 syntax ( #3688 )
2016-12-08 11:24:29 -05:00
Rene Moser
6a7682c7ea
mysql_variables: fix inconsistent params, fixes ubuntu 16.04 support
...
In the mysql_user module, login_host is defined as "localhost". Setting this to localhost also fixes Ubuntu 16.04 support.
To make it more consistent in the future, the params in all mysql modules should move to module utils. I'll take care.
Also fixed a few other things along.
2016-12-08 11:24:26 -05:00
Matt Clay
b7a5e1e0c8
Add optional connect timeout to mysql* modules.
2016-12-08 11:24:12 -05:00
Matt Martz
aaf762573e
Various simple linting type cleanups on modules
2016-12-08 11:24:06 -05:00
Jonathan Mainguy
0cdb2719e5
Unify all 3 mysql modules.
...
Use same connection method, use config_file, and add ssl support
2016-12-08 11:23:53 -05:00
Jonathan Mainguy
346c9ab80e
Update error message to be more explicit
2016-12-08 11:23:44 -05:00
Jesse Sandberg
807feb3ac4
Validate variable, return only the found variable value instead of tuple
...
Docs imply the mysql_variables is used to operate a single variable therefore
- fail before making any db connections if variable is not set
- validate chars for mysql variable name with re.match(^[a-z0-9_]+)
- use "SHOW VARIABLE WHERE Variable_name" instead of LIKE search
- getvariable() returns only the value or None if variable is not found
- the module returns only the found variable value instead of tuple for easier operation eg. as registere variable in tasks
2016-12-08 11:23:24 -05:00
acaveroc
dda41fd95a
Add version_added and type of parameter
2016-12-08 11:23:19 -05:00
acaveroc
2c6f69c95e
Assorted minor bug fixes
...
- Modified data type for port definition from string to integer
- Modified login_host default value for compatibilize with port definition according with MySQL Documentation (https://dev.mysql.com/doc/refman/5.0/en/connecting.html )
2016-12-08 11:23:19 -05:00
acaveroc
1283fdd118
Add port definition support for mysql_vars module
2016-12-08 11:23:19 -05:00
Greg DeKoenigsberg
eb881d7d5d
Proper author info for all remaining modules
2016-12-08 11:23:07 -05:00
Toshio Kuratomi
bed60553ca
Escape mysql identifiers
2016-12-08 11:22:28 -05:00
Michael DeHaan
5d814d9fb2
Some more module categorization.
2016-12-08 11:22:25 -05:00