Brian Coca
fdb56e4bad
avoid bad path entries
2016-03-23 09:30:48 -07:00
Toshio Kuratomi
917da92e2b
Get rid of extra trailing space in log messages
2016-03-23 08:01:21 -07:00
Matthew Gamble
197e590d7c
Small comment improvement in AnsibleModule class
2016-03-23 19:22:18 +11:00
Peter Sprygada
5bb876b0e2
fixes issue with getting value with . (dot) in key in netcfg
...
This commit addresses a problem when attempting to retrieve a value from
the result that includes a dict key using . (dot).
2016-03-23 02:36:48 -04:00
Brian Coca
b4b44b2708
Merge pull request #15086 from robinro/patch-2
...
remove double read of "path" (/etc/SuSE-release) in facts.py
2016-03-22 16:14:51 -07:00
Robin Roth
2c28dcc5cb
break after parsing SuSE-release in facts.py
...
All sections that lead to succesful parsing of the version break afterwards, for SuSE-release this break was missing, potentiall causing #14837
2016-03-22 08:12:17 +01:00
Robin Roth
fea5500605
remove double read of "path"
...
path is already read in line 444, don't reread the file here, but use the existing content
2016-03-22 07:50:04 +01:00
RNanney
8bceff5136
Update nxos.py
2016-03-18 15:55:41 -05:00
Abhijit Menon-Sen
efdac490ff
Merge pull request #14924 from mvgrimes/patch-1
...
Dynamically add ssl key to the mysql config hash iff needed
2016-03-18 20:38:33 +05:30
Brian Coca
d43fc631dd
mount facts now include network mounts (nfs)
2016-03-18 07:28:53 -07:00
Abhijit Menon-Sen
e5460d6a6e
Merge pull request #15002 from camradal/devel
...
add find_host_portgroup_by_name function to vmware utils
2016-03-18 19:32:17 +05:30
James Cammarata
0e68c6d6fe
Cleaning up use of literal_eval in basic.py AnsibleModule.safe_eval
2016-03-17 02:02:15 -04:00
Brian Coca
0cb804f0c2
fix lsb fact gathering
...
was erroring out when rc !=0 also fixed redundant paths
fixes #14965
2016-03-16 17:00:17 -07:00
Alexey Kalinin
9763e76f6f
add find_host_portgroup_by_name function to vmware utils
2016-03-16 11:24:42 -07:00
Daniel Kempkens
696b68f07a
Check return value of get_distribution()
...
On none-Linux systems `get_distribution()` returns `None`, which fails in `fetch_url`, because the return value of `get_distribution()` is not checked before calling `lower()` on the result.
2016-03-16 10:49:21 +01:00
Toshio Kuratomi
66328e5200
Merge pull request #14967 from ansible/facts-subset-and-cleanup
...
Facts subset and cleanup
2016-03-15 07:17:58 -07:00
Brian Coca
f3b9449e07
don't raise exceptoins on bad hosts files
...
fixes #14969
2016-03-14 20:13:23 -07:00
Peter Sprygada
ace0c9c5c2
fixes ansible-modules-code#3250
...
Sets the default value for transport to 'cli'
2016-03-14 18:49:51 -07:00
Peter Sprygada
c039ac524d
updates to nxos shared module
...
This commit address a number of minor updates the nxos shared module
* connect() is now lazy loaded
* parse inner output messages when errored
* code syntax cleanup
2016-03-14 15:21:05 -07:00
Toshio Kuratomi
512825455e
Make ohai and facter work via module_utils Fact classes rather than in the setup module
2016-03-14 14:53:29 -07:00
Toshio Kuratomi
5a1e35224b
Make changes proposed during review of restrict fact gathering feature:
...
* Make documentation examples into code blocks
* Make code to call the subsets more general.
* Made min subset always execute (cannot disable it).
* Use a passed in modules parameter rather than global modules. This is needed for ziploader
* Remove unneeded __init__()
* Remove uneeded multiple inheritance from a base class
* gather_facts is now a list type
2016-03-14 14:53:29 -07:00
Yannig Perré
88772b6003
Add a way to restrict gathered facts in Ansible:
...
- Using gather_subset options
- By ignoring ohai/chef or facter/puppet facts
2016-03-14 14:53:28 -07:00
Peter Sprygada
d211b4c962
feature to implement localized cli prompts to eos
...
This change localizes the cli prompt regexps to the eos shared module
instead of the common prompts implemented in shell
2016-03-13 16:08:55 -07:00
Peter Sprygada
5338d6af28
feature in ios to tell shell not to kickstart
...
This commit is necessary to tell shell not to kickstart the cli session as
it causes problems in IOS to recognize the prompt.
2016-03-13 16:08:47 -07:00
Peter Sprygada
249caac0d3
feature to allow prompts to be configured at instatiation
...
This commit adds a new feature to allow implementations of shell to
specify the command prompt regexp to be used. It allows adds a new
kwarg at instantiation to kick the remote device with a carriage return.
By default the kickstart flag is true but can be disabled by passing
kickstart=False.
2016-03-13 16:08:40 -07:00
Peter Sprygada
c55d1c55af
Merge pull request #14906 from devananda/fix-shell-for-junos
...
Send empty command before recv
2016-03-11 22:49:28 -05:00
Brian Coca
00b8b49112
Merge pull request #14873 from bcoca/paging_aws
...
paging for amazon modules
2016-03-11 22:23:18 -05:00
Brian Coca
fdcd80bf87
Merge pull request #13339 from bcoca/retry_rate
...
draft of common retry and rate limiting decorators for api based modules
2016-03-11 22:23:07 -05:00
Peter Sprygada
e3671a8a83
bugfix for eos shared module and new optimization
...
This commit address to issues in the eos shard module. The first one
is a bug fix for returning the running config when the transport is eapi.
The shared module will now return config text instead of an object. The
second is a optimization that delays when the eos module connects to the
remote devices. This provies a performance enhancement when using
ssh since the module doesn't default to connecting immediately
2016-03-11 22:18:15 -05:00
mvgrimes
e613737b80
Dynamically add ssl key to the mysql config hash iff needed
...
Just including the `ssl` key in the config for MySQLdb.connect, causes it to check for the existence of SSL support. This patch only adds the key if one of the ssl configuration options is included.
2016-03-11 11:14:48 -05:00
David Shrewsbury
336d19d3b0
Set type for OpenStack 'verify' param
...
The 'verify' param is a bool, so we don't want it to be an assumed
str.
2016-03-11 08:07:30 -05:00
Peter Sprygada
a59fe25bb1
bugfix for shared module shell.py
...
removes get_cli_connection function which was left over from a refactor
but was no longer in use
2016-03-10 21:16:57 -05:00
James Cammarata
16f107a491
Add mysql connection_timeout param to module_utils/mysql.py
2016-03-10 15:06:50 -05:00
Devananda van der Veen
08f270ad71
Send empty command before recv
...
On some switches, starting an SSH connection and immediately calling
recv() will result in a connection timeout. The switch requires some
input on the channel before it provides any prompt.
As such, this patch sends an empty command immediately upon connection,
triggering the switch to send a prompt which the shell can then
interpret.
Signed-off-by: Devananda van der Veen <devananda.vdv@gmail.com>
2016-03-10 11:11:18 -08:00
Peter Sprygada
ca2871de20
Merge pull request #14697 from privateip/shared_module_openswitch
...
bugfixes for openswitch shared module
2016-03-09 22:15:35 -05:00
Brian Coca
18e9bc9753
common retry and rate limiting decorators for apis
...
allows modules to wrap their request functions in common retry and rate limiting
decorators or functions
2016-03-09 16:55:47 -05:00
Brian Coca
33b550fc76
paging for amazon modules
...
this adds a decorator for use in amazon modules so retrieval functions
can page using the 'marker' that most boto functions return
2016-03-09 00:53:33 -05:00
Matt Martz
2f90a4f4e2
Strip proc_1 before testing it. Fixes #14858
2016-03-08 07:42:42 -06:00
Matt Martz
098333b2ec
Fix redirects for get_url
...
* fetch_url shouldn't both accept follow_redirects and support follow_redircts via module.params
* Default follow_redirects for open_url should be 'urllib2'
* Add redirect test for get_url
2016-03-07 15:44:31 -06:00
Brian Coca
5aab158987
removed unused imports
2016-03-06 09:14:25 -05:00
Jay Jahns
3a1944edc1
add find_vm_by_name function to vmware utils
2016-03-05 11:50:51 -08:00
Brian Coca
62ac5c047e
clarified message
2016-03-04 14:44:03 -05:00
Brian Coca
8867d73420
reject extraneous data passed to mode
...
strictly permissions are allowed, file type info should not be passed in
alternate fixes #14771
2016-03-04 14:42:29 -05:00
Brian Coca
27a33a6f18
dont erase previous nameservers in fact gathering
...
fixes #14806
2016-03-04 11:34:44 -05:00
Brian Coca
13282e29a8
Merge pull request #14500 from yfried-redhat/fix_os_auth
...
Fix openstack auth type
2016-03-03 18:16:56 -05:00
Toshio Kuratomi
468eea82bd
Merge pull request #14765 from sivel/redirect-ssl-validation
...
Support SSL validation with redirect control for python versions without ssl context
2016-03-03 07:06:34 -08:00
Matt Martz
6ff0b079b4
Support SSL validation with redirect control for python versions without ssl context
2016-03-02 16:30:16 -06:00
James Cammarata
2c7a33f71d
Fixing bug in setup related to StringIO fixes
2016-03-02 08:05:43 -05:00
James Cammarata
9acb5aa176
Changing location of reduce import to not use six.moves
2016-03-01 17:06:46 -05:00
James Cammarata
b559d0e6ee
Adding py3 stub for reduce from six.moves
2016-03-01 16:55:01 -05:00