Commit graph

8707 commits

Author SHA1 Message Date
Tim Rupp
888c8614fb Removes expanduser calls
The usage of type='path' includes the expanduser call itself. This
patch removes its duplicate usage. Related to #12263
2017-02-27 09:22:48 -05:00
Peter Sprygada
f95a11a9db fixes eos_eapi to error on wrong transport (#21993) 2017-02-27 09:20:08 -05:00
rollerwhrtn
e8ef826976 Changed datacenter Required to False since default is set. Fixes 'required and default are mutually exclusive for datacenter' error. Fixes 21076 (#21492) 2017-02-27 09:15:06 -05:00
John R Barker
05d719a9f1 Empty init file (#21991) 2017-02-27 13:14:05 +00:00
John R Barker
7891859051 Create __init__.py 2017-02-27 13:00:36 +00:00
Slezhuk Yevgeniy
ea2b27f931 jira: (#21701)
- Add timeout param.
 - Some improvement on params description.
2017-02-27 11:56:58 +00:00
Dag Wieers
2cd6e56dc2 hponcfg: Configure HP iLO mgmt board (in-band) (#21677)
This is the original `hponcfg` module that was once accepted in
Ansible but had been removed subsequently because it could not be tested
by the Ansible project.

Since then it was moved to the ansible-provisioning project and
maintained by HP engineers going forward.

Now we are trying to get it upstreamed again.
2017-02-27 11:44:09 +00:00
Dag Wieers
a66d5dcc43 win_chocolatey: Add integration tests (#21930)
And also fix a known issue.
2017-02-27 11:36:52 +00:00
Peter Sprygada
ebc2716be7 removes old module.connected property from result (#21977) 2017-02-26 23:14:56 -05:00
Peter Sprygada
216877c6ca adds system_mtu argument to nxos_system (#21970)
* updates argument_spec
* adds unit test case
2017-02-26 11:33:58 -05:00
Peter Sprygada
4c354c9c70 adds integration tests cases for nxos_feature (#21966) 2017-02-26 08:12:57 -05:00
Peter Sprygada
10b23f3a00 adds unit test cases for nxos_command (#21959) 2017-02-26 07:38:08 -05:00
Peter Sprygada
0cb2019293 roll up of bug fixs for nxos_evpn_global (#21961)
* updates nxos_evpn_global module
* adds integration test cases
* adds unit test cases
2017-02-26 06:45:26 -05:00
René Moser
06acf8ac2e nginx_status_facts: fix pep8 (#21963)
* nginx_status_facts: fix pep8

* remove from legacy files
2017-02-26 11:25:09 +01:00
René Moser
cecf22039d cs_vpc: fix pep8 (#21964) 2017-02-26 10:21:12 +01:00
Nathaniel Case
9b9ed59d98 Vyos config fixes (#21862)
* Fix vyos signatures to match new versions

* Fix test cases referring to 'updates' instead of 'commands'

* I think this is an artifact of `connection: network_cli`?
2017-02-25 21:14:40 -05:00
Peter Sprygada
a284c3f7ea roll up of fixes for nxos_facts (#21954)
* fixes commands to work with nxapi
* updates test case timeouts
2017-02-25 17:48:09 -05:00
Peter Sprygada
16a39639f5 fixes minor bugs in eos_eapi module (#21925)
* module will now check protocol running state before return
* warns on config argument no longer being needed
* lots of integration test cases updated
* updates unit and integration test cases for state check

fixes #21908
2017-02-25 17:18:46 -05:00
Peter Sprygada
1f9b503e89 fixes issue with config parents on eos modules (#21923)
eos_config module wasn't respecting config block path (parents).  This
patch fixes that problem.  Also fixes a number of integration tests
cases

fixes #21903
2017-02-25 16:40:13 -05:00
Peter Sprygada
14c05d9e2b roll up of fixes for nxos_config (#21949)
* fixes provider to not log entries
* fixes nxapi send_request with config statements
* fixes nxapi get_config()
* updates nxos_config integration tests
2017-02-25 16:36:00 -05:00
Peter Sprygada
01ac1bc6e5 roll up of fixes from nxos integration tests (#21948)
* now fails nxos_nxapi if the transport=nxapi
* fixes typos in nxos_nxapi integration tests cases
2017-02-25 13:17:04 +00:00
René Moser
d26c57f938 exoscale: pep8 and python3 fixes (#21821)
* exoscale: pep8 fixes

* exo_dns_record: remove from pep8 test legacy

* exoscale: fix python3 support
2017-02-25 10:32:39 +01:00
Barry Peddycord III
2ca5719168 Deprecating old cumulus modules (#21726)
* deprecating old nclu modules

* adding deprecated cl_ moduels to changelog

* renaming deprecated modules
2017-02-25 08:01:04 +00:00
Dag Wieers
98934939af win_copy: Add force parameter and check-mode support (#20405)
* win_copy: Add force parameter and check-mode support

The rationale behind this is that if you're working with +3GB files,
creating the checksum takes a lot of time, which we can avoid by simply
testing if the file exists.

I also took the liberty to put the various parameters together. It
probably takes a (neglible) performance hit but makes the code a bit
easier to inspect/work with, as its closer to all other windows modules.

On a normal run, the action plugin does a local checksum of the source
and a remote checksum of the destination. And afterwards, the module
will do another remote checksum of the copied source, a remote checksum
of the original destination, and another remote checksum of the copied
destination.

On a very huge file (think 4GB) that means 5x reading the complete file
(if you have a large cache you may get away with it, otherwise you're
doomed !).

This patch will ensure with `force: no` that not checksums are being
performed.

* Moving presence check before remote checksum

* Adapted to wishes

* Even more performance improvements
2017-02-24 18:10:09 -08:00
Matt Martz
305c88700d PEP8 E712 fixes (#21916) 2017-02-24 16:49:43 -06:00
John R Barker
1d2349872a RETURN block is broken, so delete it 2017-02-24 20:44:48 +00:00
Adrian Likins
78c4f03e50 Fix firewalld get_masquerade_enabled_permanent error (#21693)
get_masquerade_* functions only take one arg. The action_handler
wrapper function expected a tuple, but was being passed (zone)
instead of (zone,) making for an ambiquous tuple. The
(zone) arg was being treated as a tuple/list of six chars
(the zone name) instead of a tuple of one string.

This would cause errors like:

        get_masquerade_enabled_permanent() takes exactly 1 argument (6 given)

Fixes #21632
2017-02-24 12:32:28 -05:00
Ricardo Carrillo Cruz
e6a78b38d3 Remove check_args import (#21905)
It is defined in the file, thus no point in importing it.
2017-02-24 17:41:53 +01:00
Gaurav Rastogi
436095f576 New module for setting up Avi Pool (#21241)
* New module for setting up Avi Pool

* Fixed inconsistency between argspec and documentation regarding defaults and required attributes

* Added support for module_check
2017-02-24 16:38:16 +00:00
Gaurav Rastogi
055f2c29a5 New module to setup Avi VirtualService (#21170)
* Added new module to setup Avi VirtualService

* Fixed the documentation error where [] brackets where used making it incompatible with yaml

* Fixed inconsistency between argspec and documentation regarding defaults and required attributes

* Added support for check mode
2017-02-24 16:38:02 +00:00
Gaurav Rastogi
de841a6429 New module for setting up Avi SSL Key and Certificates for Virtual Se… (#21242)
* New module for setting up Avi SSL Key and Certificates for Virtual Services

* Fixed inconsistency between argspec and documentation regarding defaults and required attributes

* Added support for module_check
2017-02-24 16:37:51 +00:00
Gaurav Rastogi
39a93eb357 New module for setting up Avi Pool Group settings. (#21243)
* New module for setting up Avi Pool Group settings.

* Fixed inconsistency between argspec and documentation regarding defaults and required attributes

* Added support for module_check
2017-02-24 16:37:13 +00:00
Gaurav Rastogi
51718fd32b New module for setting up Avi Pool Health Monitors (#21240)
* New module for setting up Avi Pool Health Monitors

* Fixed inconsistency between argspec and documentation regarding defaults and required attributes

* Added support for module_check
2017-02-24 16:36:18 +00:00
Pavel Malyshev
7063db64c2 redhat_subcription module accepts id in the pool argument [#3898] 2017-02-24 10:38:46 -05:00
Simon Li
ef7dd0cb2c Set os_server metadata on existing instances (#19318)
* Update metadata on existing openstack instances

This adds or updates existing keys, but doesn't remove them
Fixes #5500

* Set meta to {} if None

* Move common metadata parsing into a method
2017-02-24 12:46:03 +01:00
Dag Wieers
581bf7bb97 win_environment: Clean up, check-mode and diff support (#21356)
* win_environment: Clean up, check-mode and diff support

Changes include:

- Remove trailing semi-colons
- Replaced PSObjects into normal hashes
- Make use of Get-AnsibleParam and types
- Added check-mode support
- Added diff support

* Improve diff-support by using standard naming

I started to use the variable $diff_support for the boolean that takes
care of diff output support.
2017-02-24 10:34:05 +00:00
Dag Wieers
b1f6344ecb win_chocolatey: Clean up parameter handling (#21533)
Changes include:

- Use Get-AnsibleParam with -type/-validateset
- Replace $result PSObject with normal hash
- Deprecate 'upgrade' parameter by using state=latest
2017-02-24 10:09:11 +00:00
Dag Wieers
78c300412d win_user: Clean up parameter handling and $result hash (#21375)
* win_user: Clean up parameter handling and $result hash

Changes include:
- Use of Get-AnsibleParam and parameter types/validateset
- Removed parameter validation
- Replace $result PSObject with normal hash

* Revert to original formatting

* Parameter "groups" is a list
2017-02-24 10:08:15 +00:00
Dag Wieers
70336c63c9 win_uri: Replace -type "string" with -type "str" (#21373)
Type "string" does not exist.
2017-02-23 23:35:52 -08:00
Dag Wieers
582557bc09 win_file_version: Clean up and check-mode support (#21379)
* win_file_version: Clean up parameter handling and $result hash

Changes include:
- Replacing $result PSObject with hash
- Use Gt-AnsibleParam using -type

* Revert to original formatting
2017-02-23 23:35:19 -08:00
Dag Wieers
69ac88176d win_group: Clean up and check-mode support (#21384)
* win_group: Clean up and check-mode support

Changes include:
- Use Get-AnsibleParam with -type/-validateset support
- Replace $result PSObject with normal hash
- Add check-mode support

* Revert to original formatting
2017-02-23 23:34:33 -08:00
Dag Wieers
928880c639 win_owner: Clean up and check-mode support (#21385)
* win_owner: Clean up and check-mode support

Changes include:
- Use Get-AnsibleParam with -type/-validateset
- Replace $result PSObject with normal hash
- Add check-mode support

* Implemented -WhatIf:$check_mode support

* Revert to original formatting
2017-02-23 23:33:35 -08:00
Dag Wieers
313a9d3845 win_share: Clean up parameter handling (#21386)
* win_share: Clean up parameter handling

Changes include:
- Use Get-AnsibleParam with -type/-validateset
- Replace $result PSObject with normal hash

* Revert to original formatting
2017-02-23 23:31:09 -08:00
Dag Wieers
cb78262c18 win_lineinfile: Clean up and check-mode support (#21503)
* win_lineinfile: Clean up and check-mode and diff support

Changes include:
- Use Get-AnsibleParam with -type support
- Replace $result PSObject with normal hash
- Remove trailing semi-colons
- Fix indentation (majority is tabs, few lines using spaces)
- Add check-mode support
- Support `r and `n for CR and LF
- Add diff support

* Implement -WhatIf:$check_mode support

* Keep original formatting as requested
2017-02-23 23:29:11 -08:00
Dag Wieers
d239adb5e5 Improve diff-support and use Add-Warning() (#21519)
I started to use the variable $diff_support for the boolean that takes
care of diff output support.
2017-02-23 23:22:39 -08:00
Dag Wieers
ff1efb2c1c win_nssm: Clean up parameter handling + docs (#21625) 2017-02-23 23:14:12 -08:00
Dag Wieers
58cbf1bfe0 Implemented -WhatIf:$check_mode support (#21628) 2017-02-23 23:10:25 -08:00
Dag Wieers
01afed4dc5 win_stat: Module cleanup (#20672)
* win_stat: Clean up and bugfixes

- Fix an issue where LastWriteTime was actually LastAccessTime
- Return lnk_source = $null for a broken link
- Remove a useless -Replace '\\','\\'
- Make use of new parameter options (-type and -aliases)

* Deprecate get_md5 with checksum_algorithm: md5

As suggested in comments we deprecate get_md5 and internally
replace it with `get_checksum` and `checksum_algorithm: md5`.

We show a warning to the user about this change.

Also remove empty warnings output. This simplifies modules code
(e.g. standard empty list is provided and snippets can add items).

* Adapted to use the new Add-DeprecationWarning() mechanism

* Revert to original formatting
2017-02-23 22:58:51 -08:00
Dag Wieers
371f9fa90d win_slurp: Small cleanup (#21363)
* win_slurp: Small cleanup

Included changes:
- Rewriting the parameter handling (aliases and type)
- Modified the $result hash for both Exit-Json and Fail-Json
- Changed the Test-Path statement

* Revert to original formatting
2017-02-23 22:38:17 -08:00
Dag Wieers
a64fb3eebf win_get_url: Clean up and check-mode support (#21381)
* win_get_url: Clean up and check-mode support

Changes include:
- Clean up parameter handling
- Replace $result PSObject with hash

* Revert to original formatting
2017-02-23 22:26:01 -08:00