Commit graph

570 commits

Author SHA1 Message Date
Joseph Callen
0aa4f867de Resolves issue with vmware_dvs_host module for v2.0
When this module was written back in May 2015 we were using 1.9.x. Being lazy I added to param the objects that the other functions would need. What I have noticed is in 2.0 exit_json is trying to jsonify those complex objects and failing. This PR resolves that issue with the vmware_dvs_host module.

@kamsz reported this issue in https://github.com/ansible/ansible-modules-extras/pull/1568

Playbook
```
- name: Add Host to dVS
      local_action:
        module: vmware_dvs_host
        hostname: "{{ mgmt_ip_address }}"
        username: "{{ vcsa_user }}"
        password: "{{ vcsa_pass }}"
        esxi_hostname: "{{ hostvars[item].hostname }}"
        switch_name: dvSwitch
        vmnics: "{{ dvs_vmnic }}"
        state: present
      with_items: groups['foundation_esxi']
```
Module Testing
```
TASK [Add Host to dVS] *********************************************************
task path: /opt/autodeploy/projects/emmet/site_deploy.yml:234
ESTABLISH LOCAL CONNECTION FOR USER: root
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454694039.6-259977654985844 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454694039.6-259977654985844 )" )
localhost PUT /tmp/tmpGrHqbd TO /root/.ansible/tmp/ansible-tmp-1454694039.6-259977654985844/vmware_dvs_host
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454694039.6-259977654985844/vmware_dvs_host; rm -rf "/root/.ansible/tmp/ansible-tmp-1454694039.6-259977654985844/" > /dev/null 2>&1
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454694058.76-121920794239796 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454694058.76-121920794239796 )" )
localhost PUT /tmp/tmpkP7DPu TO /root/.ansible/tmp/ansible-tmp-1454694058.76-121920794239796/vmware_dvs_host
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454694058.76-121920794239796/vmware_dvs_host; rm -rf "/root/.ansible/tmp/ansible-tmp-1454694058.76-121920794239796/" > /dev/null 2>&1
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454694090.2-33641188152663 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454694090.2-33641188152663 )" )
localhost PUT /tmp/tmp216NwV TO /root/.ansible/tmp/ansible-tmp-1454694090.2-33641188152663/vmware_dvs_host
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454694090.2-33641188152663/vmware_dvs_host; rm -rf "/root/.ansible/tmp/ansible-tmp-1454694090.2-33641188152663/" > /dev/null 2>&1
changed: [foundation-vcsa -> localhost] => (item=foundation-esxi-01) => {"changed": true, "invocation": {"module_args": {"esxi_hostname": "cscesxtmp001", "hostname": "172.27.0.100", "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "state": "present", "switch_name": "dvSwitch", "username": "root", "vmnics": ["vmnic2"]}, "module_name": "vmware_dvs_host"}, "item": "foundation-esxi-01", "result": "None"}
changed: [foundation-vcsa -> localhost] => (item=foundation-esxi-02) => {"changed": true, "invocation": {"module_args": {"esxi_hostname": "cscesxtmp002", "hostname": "172.27.0.100", "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "state": "present", "switch_name": "dvSwitch", "username": "root", "vmnics": ["vmnic2"]}, "module_name": "vmware_dvs_host"}, "item": "foundation-esxi-02", "result": "None"}
changed: [foundation-vcsa -> localhost] => (item=foundation-esxi-03) => {"changed": true, "invocation": {"module_args": {"esxi_hostname": "cscesxtmp003", "hostname": "172.27.0.100", "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "state": "present", "switch_name": "dvSwitch", "username": "root", "vmnics": ["vmnic2"]}, "module_name": "vmware_dvs_host"}, "item": "foundation-esxi-03", "result": "None"}
```
2016-12-08 11:33:52 -05:00
Rene Moser
fb4c299f13 cloudstack: new module cs_zone 2016-12-08 11:33:52 -05:00
Rene Moser
3a6fd536ab cloudstack: new module cs_cluster 2016-12-08 11:33:52 -05:00
Rene Moser
2b21212dc6 cloudstack: new module cs_pod 2016-12-08 11:33:52 -05:00
Rene Moser
7d1a4db9ee cloudstack: new module cs_instance_facts 2016-12-08 11:33:52 -05:00
Rene Moser
b609250cfd cloudstack: add new module cs_resourcelimit 2016-12-08 11:33:52 -05:00
Rene Moser
595eb1f8f1 cloudstack: new module cs_configuration 2016-12-08 11:33:52 -05:00
Matt Martz
4842758fd1 Choices should be a list of true/false not the string BOOLEANS 2016-12-08 11:33:51 -05:00
Matt Martz
402a996430 Don't call sys.exit in sns_topic, use HAS_BOTO to fail 2016-12-08 11:33:51 -05:00
Matt Martz
27be34ef9d DOCUMENTATION fixes for a few modules 2016-12-08 11:33:51 -05:00
Joseph Callen
9ab5b367bd Resolves issue with vmware_dvswitch module for v2.0
When this module was written back in May 2015 we were using 1.9.x. Being lazy I added to param the objects that the other functions would need. What I have noticed is in 2.0 exit_json is trying to jsonify those complex objects and failing. This PR resolves that issue with the vmware_dvswitch module.

@kamsz reported this issue in https://github.com/ansible/ansible-modules-extras/pull/1568

Playbook
```
- name: Create dvswitch
      local_action:
        module: vmware_dvswitch
        hostname: "{{ mgmt_ip_address }}"
        username: "{{ vcsa_user }}"
        password: "{{ vcsa_pass }}"
        datacenter_name: "{{ mgmt_vdc }}"
        switch_name: dvSwitch
        mtu: 1500
        uplink_quantity: 2
        discovery_proto: lldp
        discovery_operation: both
        state: present
```
Module Testing
```
TASK [Create dvswitch] *********************************************************
task path: /opt/autodeploy/projects/emmet/tasks/deploy/dvs_network.yml:3
ESTABLISH LOCAL CONNECTION FOR USER: root
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454693792.01-113207408596014 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454693792.01-113207408596014 )" )
localhost PUT /tmp/tmptb3e2c TO /root/.ansible/tmp/ansible-tmp-1454693792.01-113207408596014/vmware_dvswitch
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454693792.01-113207408596014/vmware_dvswitch; rm -rf "/root/.ansible/tmp/ansible-tmp-1454693792.01-113207408596014/" > /dev/null 2>&1
changed: [foundation-vcsa -> localhost] => {"changed": true, "invocation": {"module_args": {"datacenter_name": "Test-Lab", "discovery_operation": "both", "discovery_proto": "lldp", "hostname": "172.27.0.100", "mtu": 1500, "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "state": "present", "switch_name": "dvSwitch", "uplink_quantity": 2, "username": "root"}, "module_name": "vmware_dvswitch"}, "result": "'vim.dvs.VmwareDistributedVirtualSwitch:dvs-9'"}
```
2016-12-08 11:33:51 -05:00
Rene Moser
5344701557 cloudstack: cs_instance: implement updating security groups
ACS API implemented in 4.8, has no effect < 4.8.
2016-12-08 11:33:51 -05:00
Rene Moser
51393a0e0f cloudstack: use CS_HYPERVISORS from cloudstack utils 2016-12-08 11:33:51 -05:00
Joseph Callen
750f6f35ed Fixed documentation 2016-12-08 11:33:51 -05:00
Joseph Callen
e4d7af368b Resolves issue with vmware_vswitch module for v2.0
When this module was written back in May 2015 we were using 1.9.x. Being lazy I added to param the objects that the other functions would need. What I have noticed is in 2.0 exit_json is trying to jsonify those complex objects and failing.

Playbook
```yaml
   - name: Add a temporary vSwitch
      local_action:
        module: vmware_vswitch
        hostname: "{{ inventory_hostname }}"
        username: "{{ esxi_username }}"
        password: "{{ site_passwd }}"
        switch_name: temp_vswitch
        nic_name: "{{ vss_vmnic }}"
        mtu: 1500
```

Module Testing
```bash
TASK [Add a temporary vSwitch] *************************************************
task path: /opt/autodeploy/projects/emmet/tasks/deploy/esxi_network.yml:13
ESTABLISH LOCAL CONNECTION FOR USER: root
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454342817.37-180776062017566 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454342817.37-180776062017566 )" )
ESTABLISH LOCAL CONNECTION FOR USER: root
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454342817.41-201974997737598 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454342817.41-201974997737598 )" )
ESTABLISH LOCAL CONNECTION FOR USER: root
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454342817.44-148446986849801 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454342817.44-148446986849801 )" )
localhost PUT /tmp/tmpLLExSG TO /root/.ansible/tmp/ansible-tmp-1454342817.37-180776062017566/vmware_vswitch
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454342817.37-180776062017566/vmware_vswitch; rm -rf "/root/.ansible/tmp/ansible-tmp-1454342817.37-180776062017566/" > /dev/null 2>&1
localhost PUT /tmp/tmpyoAaHt TO /root/.ansible/tmp/ansible-tmp-1454342817.41-201974997737598/vmware_vswitch
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454342817.41-201974997737598/vmware_vswitch; rm -rf "/root/.ansible/tmp/ansible-tmp-1454342817.41-201974997737598/" > /dev/null 2>&1
localhost PUT /tmp/tmpPcmaMZ TO /root/.ansible/tmp/ansible-tmp-1454342817.44-148446986849801/vmware_vswitch
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454342817.44-148446986849801/vmware_vswitch; rm -rf "/root/.ansible/tmp/ansible-tmp-1454342817.44-148446986849801/" > /dev/null 2>&1
changed: [foundation-esxi-01 -> localhost] => {"changed": true, "invocation": {"module_args": {"hostname": "foundation-esxi-01", "mtu": 1500, "nic_name": "vmnic1", "number_of_ports": 128, "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "state": "present", "switch_name": "temp_vswitch", "username": "root"}, "module_name": "vmware_vswitch"}}
changed: [foundation-esxi-02 -> localhost] => {"changed": true, "invocation": {"module_args": {"hostname": "foundation-esxi-02", "mtu": 1500, "nic_name": "vmnic1", "number_of_ports": 128, "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "state": "present", "switch_name": "temp_vswitch", "username": "root"}, "module_name": "vmware_vswitch"}}
changed: [foundation-esxi-03 -> localhost] => {"changed": true, "invocation": {"module_args": {"hostname": "foundation-esxi-03", "mtu": 1500, "nic_name": "vmnic1", "number_of_ports": 128, "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "state": "present", "switch_name": "temp_vswitch", "username": "root"}, "module_name": "vmware_vswitch"}}

```

Documentation fix
2016-12-08 11:33:51 -05:00
Joel Thompson
8539d6f502 Fix documentation for sns_topic module
Currently the documentation does not correspond to the Ansible standards
for module documentation. This should bring it into compliance.
2016-12-08 11:33:50 -05:00
Brian Coca
c7108db1a0 merged duplicate entries for vdc_name 2016-12-08 11:33:49 -05:00
Michael Baydoun
221d1b7744 Update ec2_vpc_net_facts.py
Corrected version_added
2016-12-08 11:33:49 -05:00
Alex Kalinin
126f8b709f Fix opening libvirt esx connection 2016-12-08 11:33:49 -05:00
Brian Coca
c7f4fbb8a7 corrected parameter name and added missing description 2016-12-08 11:33:49 -05:00
Brian Coca
e25032cc86 fixed misppelled description 2016-12-08 11:33:49 -05:00
Matt Martz
78759c667a Fix DOCUMENTATION for ec2_vpc_dhcp_options.py and add missing RETURN to ec2_vol_facts.py 2016-12-08 11:33:48 -05:00
Sumit Roy
8eeb30da3d Ensure that port_path is split into at most 2 components.
cloudstack: cs_instance: fix do not require name to be set to avoid clashes

Require one of display_name or name. If both is given, name is used as identifier.

cloudstack: fix name is not case insensitive

cloudstack: cs_template: implement state=extracted

Update f5 validate_certs functionality to do the right thing on multiple python versions

This requires the implementation in the module_utils code here
https://github.com/ansible/ansible/pull/13667 to funciton

fixed domain_id to actually be supported

also added domain as an alias
alt fixes #1437

Simplify the code and remove use_unsafe_shell=True

While there is no security issue with this shell snippet, it
is better to not rely on shell and avoid use_unsafe_shell.

Fix for issue #1074. Now able to create volume without replica's.

Improved fix for #1074. Both None and '' transform to fqdn.

Fix for ansible-modules-extras issue #1080
2016-12-08 11:33:48 -05:00
Joel Thompson
bace230f25 Add new ec2_vpc_dhcp_options module
This module manages EC2 DHCP options for a given VPC. It allows you to
specify all the options which AWS allows you to set in a DHCP option
set.
2016-12-08 11:33:47 -05:00
Shawn Siefkas
7cf0f8a7f6 Fixing check mode support for vpc route tables
Loop compatibility for dry run exception handling

Route table deletion dry run handler

Fixing regression in propagating_vgw_ids default value

Adjusting truthiness of changed attribute for route manipulation

Updating propagating_vgw_ids default in docstring
2016-12-08 11:33:47 -05:00
wimnat
6d239c6a3f New module - ec2_vol_facts 2016-12-08 11:33:47 -05:00
Baptiste Mille-Mathias
06b3d39076 fix typo
conainerization => containerization
2016-12-08 11:33:46 -05:00
Toshio Kuratomi
255c4b01a8 Remove duplicate documentation fields 2016-12-08 11:33:46 -05:00
RajeevNambiar
77ca6641cb Update sts_assume_role.py for showing the correct example syntax role_session_name instead of session_name
Update sts_assume_role.py for showing the correct example syntax role_session_name instead of session_name. session_name is not a valid property.
2016-12-08 11:33:46 -05:00
Robb Wagoner
f7c044badf InService percent key as literal percent (i.e 50, not .5) 2016-12-08 11:33:46 -05:00
Robb Wagoner
8f2eff6ca8 Include instance states (InService or OutOfService) as ELB facts 2016-12-08 11:33:46 -05:00
Rob White
d608dee29f Add missing doc fragments 2016-12-08 11:33:45 -05:00
David Shrewsbury
ccee183143 Fix exception output for os_keystone_domain.
The message attribute of a shade exception is not very helpful.
Converting to a full string will contain many more details.
2016-12-08 11:33:45 -05:00
Rene Moser
10be5eb908 cloudstack: cs_portforward: fix missing return and remove unused arg 2016-12-08 11:33:45 -05:00
David Shrewsbury
17e9b85228 Update Keystone Domain module for latest shade 2016-12-08 11:33:45 -05:00
Monty Taylor
072cf69cc1 Extract module for keystone domain management 2016-12-08 11:33:45 -05:00
Haneef Ali
e4e88807e8 Ansible module for Keystone V3 API
Change-Id: I9db323cc9e5a42353cab5cf4be6e22449cef8542
2016-12-08 11:33:45 -05:00
Charles Paul
8e0d982204 use doc fragments 2016-12-08 11:33:45 -05:00
Constantin07
e20317b3be Print explicit error cause when no ELBs are found in AWS 2016-12-08 11:33:44 -05:00
Stepan Stipl
9bba1b66c5 Fix: route53_facts hosted_zone_id boto error
Boto is expecting parameter called "Id", not "HostedZoneId".
See
http://boto3.readthedocs.org/en/latest/reference/services/route53.html#Route53.Client.get_hosted_zone

Fixes ansible/ansible-modules-extras/#1465
2016-12-08 11:33:44 -05:00
Toshio Kuratomi
ad0d2c1747 Update for modules which import json.
Some do not use the json module directly so don't need import json.
Some needed to fallback to simplejson with no traceback if neither was installed

Fixes #1298
2016-12-08 11:33:44 -05:00
Rob
2916a8bf5d Add secondary addresses to facts 2016-12-08 11:33:43 -05:00
Brian Coca
a57da4e329 added version info on autodetection feature 2016-12-08 11:33:43 -05:00
Łukasz Proszek
d2f060f278 add lxc support, without dropping openvz 2016-12-08 11:33:43 -05:00
Toshio Kuratomi
0501a18608 Really disable RETURN 2016-12-08 11:33:43 -05:00
Toshio Kuratomi
c98db451ac Disable RETURNS because the approved module doesn't have a RETURNS that is buildable 2016-12-08 11:33:43 -05:00
Mark Chance
ac86f8f0ad fix, update the documentation of the modules 2016-12-08 11:33:42 -05:00
Mark Chance
00bd01c293 WIP documentation update 2016-12-08 11:33:42 -05:00
Mark Chance
7634539da7 add author tag in doc 2016-12-08 11:33:42 -05:00
Mark Chance
a1429f868b update version, fix fail msgs 2016-12-08 11:33:42 -05:00