ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-04-24 19:31:26 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 9
22186 commits 11 branches 190 tags 299 MiB
Commit graph

172 commits

Author SHA1 Message Date
James Cammarata
ccf646665b Revert "Removing explicit setting of failed/failed_when" 
This reverts commit 4e528e9535.
 2016-03-10 08:01:54 -05:00
James Cammarata
4e528e9535 Removing explicit setting of failed/failed_when 2016-03-10 07:42:16 -05:00
nitzmahone
dbff3a6bbc Fix blind override in failed_when 
caused all task failures to be success
 2016-03-09 17:48:59 -08:00
Brian Coca
9318727021 corrected changed_when handling 2016-03-09 16:09:05 -05:00
Brian Coca
7067bb32b8 make all conditionals lists 
this brings them to equivalence with when:
fixes #13905
 2016-03-09 09:33:59 -05:00
Brian Coca
71402abf21 only do squash when 'squashable field' present 2016-03-01 15:11:34 -05:00
Brian Coca
67d5b77898 added package to special 'squashable' fields 
apt has it as alias, this should fix https://github.com/ansible/ansible-modules-core/issues/3145
 2016-02-29 15:21:17 -05:00
Brian Coca
512d3dd621 with_ loops always should want a list 2016-02-26 14:56:54 -05:00
Brian Coca
34541b4e5e preserve no_log for async also 2016-02-23 15:37:39 -05:00
James Cammarata
e02b98274b issue callbacks per item and retry fails 
- now workers passes queue to task_executor so it can send back events per item and on retry attempt
- updated result class to pass along events to strategy
- base strategy updated to forward new events to callback
- callbacks now remove 'items' on final result but process them directly when invoked per item
- new callback method to deal with retry attempt messages (also now obeys nolog)
- updated tests to match new signature of task_executor

fixes #14558
fixes #14072
 2016-02-23 15:07:06 -05:00
James Cammarata
6cf6130468 Fixing/cleaning up do/until logic in TaskExecutor 
* Fixes bug where the task was not marked as failed if the number of
  retries were exceeded (#14461)
* Reorganizing logic to be a bit cleaner, and so retrie messages are
  shown before sleeping (which makes way more sense)

Fixes #14461
Fixes #14580
 2016-02-23 13:17:51 -05:00
Brian Coca
d54d9dabe9 added specific info to deprecation message 
should now show actual variable that is undefined
fixes #14526
 2016-02-18 02:21:58 -08:00
Brian Coca
347b28252a allow skipping tasks due to undefined var 
mimic 1.x behaviour but give out big deprecation message, not only
for missing attribute but any undefined error.
 2016-02-11 14:16:38 -05:00
James Cammarata
2adddac94c Catch exceptions during module execution so they don't fail the worker 
Fixes #14120
 2016-02-10 09:22:57 -05:00
Toshio Kuratomi
0e410bbc8a Squashing was occuring even though pkgs didn't have a template that would be affected by squash 
This broke other uses of looping (looping for delegate_to in the
reported bug)

Fixes #13980
 2016-01-27 21:55:00 -08:00
James Cammarata
1733d434d1 Fix with loop + delegate issues 
* Don't re-use the existing connection if the remote_addr field of
  the play context has changed
* When overriding variables in PlayContext (from task/variables),
  don't set the same attribute based on a different variable name
  if we had already previously set it from another variable name

Fixes #13880
 2016-01-18 17:35:00 -05:00
James Cammarata
c42484a029 Minor cleanup when reassigning play context to reused connections 
* Relocate the assignment of the host address to the remote_addr field
  in the play context, which was only done when the connection was created
  (it's now done after the post_validate() is called on the play context)
* Make the assignment of the play context to the connection an else, since
  it's not required if the connection is not reused
 2016-01-18 13:36:40 -05:00
Karthik T
c4cbeeffa8 Fixes #13763 Update connections _play_context on every iteration 
If this isnt updated, the _connection is reused, and thus has an outdated _play_context
This results in outdated `success_key` and `prompt` causing issues if sudo is run in a loop
Refer to the issue #13763 for more debugging and details
 2016-01-11 16:30:52 +08:00
Brian Coca
d3deb24ead output color is now configurable 2015-12-29 17:40:47 -05:00
James Cammarata
3ec0104128 Fixing bugs in conditional testing with until and some integration runner tweaks 2015-12-19 21:14:48 -05:00
James Cammarata
a3dcb910b8 Fixing bugs with {changed,failed}_when and until with registered vars 
* Saving of the registered variable was occuring after the tests for
  changed/failed_when.
* Each of the above fields and until were being post_validated too early,
  so variables which were not defined at that time were causing task
  failures.

Fixes #13591
 2015-12-18 10:58:55 -05:00
James Cammarata
e546219426 Revert "Enable host_key checking at the strategy level" 
This reverts commit 1a6d660d7e285cceec474952a33af4d8dffd0a8d.
 2015-12-17 12:43:47 -05:00
James Cammarata
e5c2c03dea Enable host_key checking at the strategy level 
Implements a new method in the ssh connection plugin (fetch_and_store_key)
which is used to prefetch the key using ssh-keyscan.
 2015-12-16 21:41:07 -05:00
Toshio Kuratomi
0434644d12 Transform exceptions into ansible messages via to_unicode instead of str to avoid tracebacks. 
Fixes #13385
 2015-12-04 11:50:39 -08:00
James Cammarata
65747285a4 Properly check for prompting state when re-using ssh connection 
Fixes #13278
 2015-11-24 09:09:54 -05:00
Chris Church
272778f732 Modify task executor to reuse connection inside a loop. Fix WinRM connection to set _connected properly and display when remote shell is opened/closed. Add integration test using raw + with_items. 2015-11-23 11:53:05 -05:00
Brian Coca
478c6c756a marked spot that should send per item reulsts 2015-11-22 14:44:51 -08:00
James Cammarata
78e4f176e6 Return skipped/failed async results directly 
Fixes #13205
 2015-11-19 08:30:00 -05:00
Marius Gedminas
66347c9449 Fix NameError when using loops 
vars_copy disappeared in 3d1255d190.

Fixes #13213.
 2015-11-19 09:21:06 +02:00
James Cammarata
3d1255d190 Don't update job vars too early when getting loop items in TaskExecutor 
Fixes #13113
 2015-11-18 19:12:38 -05:00
James Cammarata
b2b0fa8d13 Changed do/until failed color 
Fixes #13130
 2015-11-11 14:43:15 -05:00
James Cammarata
94c20c9ac6 Cleanup failed/changed logic in TaskExecutor 
Fixes #12980
 2015-11-11 14:23:37 -05:00
Toshio Kuratomi
62979efa14 Finish up plugin porting to global display 
Also remove display = display which does nothing
 2015-11-11 10:44:23 -08:00
Toshio Kuratomi
186e034515 Move the rest of executor code to global display 2015-11-11 10:44:22 -08:00
Toshio Kuratomi
e45ce871a7 Fix for traceback when neither name nor pkg are in the module params 2015-11-11 07:32:21 -08:00
James Cammarata
a99f2fd52f Save delegated vars in result for use in callback methods 
Fixes #13014
 2015-11-10 10:14:30 -05:00
Yannig Perré
0c360d17cb New parameter for template method. 
We do not compute hash when we know that the result does not need to be cached (like with_items loop).
It also result in a small speed improvement.
 2015-11-10 07:19:19 +01:00
Toshio Kuratomi
1a04f354f3 For with_first_found loops, set undefined variables to fall through rather than failing the task 2015-11-09 10:51:54 -08:00
James Cammarata
63c47fb271 Fixing up performance 2015-11-05 16:22:37 -05:00
Toshio Kuratomi
4f6d4c6bf6 Set task_action when the action does not need to be templated 
Fixes #13042
 2015-11-05 08:38:21 -08:00
Toshio Kuratomi
483491ddfb template the task_action before checking whether to optimize with_item loops for it. 
Fixes the second problem discovered in #12976
 2015-11-04 19:41:55 -08:00
Toshio Kuratomi
9e758d3d97 Do not optimize with_items loop if the items are not strings 
The code isn't sophisticated enough to understand lists and dicts yet.
This mirrors how 1.9.x handled non-string items so its not a regression.

One portion of a fix for #12976
 2015-11-04 18:48:41 -08:00
James Cammarata
a5bd92ca4b Merge branch 'devel_fix_debug_var' of https://github.com/Yannig/ansible into Yannig-devel_fix_debug_var 2015-10-30 08:37:03 -04:00
James Cammarata
479cbfc63c Don't immediately fail on PlayContext setup 
As we may end up skipping the task due to conditionals.

Fixes #12774
 2015-10-29 19:23:42 -04:00
Yannig Perré
1febf7cb88 Fix for issue #12952: this code interfere with debug+var and seems to be unnecessary. 2015-10-28 22:09:13 +01:00
James Cammarata
3fc2209ca0 Fixing retry/until logic and default value for retries 
Fixes #12928
Fixes #12929
 2015-10-27 15:37:48 -04:00
Toshio Kuratomi
92dd563a75 Fix invocation from bad merge and note where it would need to go to keep 
it out of registered vars as well.
 2015-10-24 07:29:42 -07:00
James Cammarata
86de1429e5 Cleaning up FIXMEs 2015-10-22 16:03:50 -04:00
Brian Coca
fc3a44485b skip errors on conditional if task is include 
fixes #12843
 2015-10-22 07:50:43 -04:00
James Cammarata
ec56b29ba4 Fix setting of interpreter values for delegated hosts 
Fixes #12772
 2015-10-21 11:05:45 -04:00