Commit graph

18 commits

Author SHA1 Message Date
Patrik Lundin
896dec44a6 openbsd_pkg: Use correct part of name in match. (#3151)
* openbsd_pkg: Use correct part of name in match.

Previously this part of the code could assume that the name was a stem
with nothing else attached (like "autoconf"). With the introduction of the
branch syntax ("autoconf%2.13") this is no longer true.

Check if the package name was identified as using a "branch" style name,
and base the match on the leading part of the name if that is the case.

While here remove unnecessary "pass" and tidy up debug log message.

Problem reported by @jasperla.

* openbsd_pkg: Add missing "." in comment.
2016-12-08 11:34:58 -05:00
Patrik Lundin
dc4914bd19 Improve debug log some more. 2016-12-08 11:34:28 -05:00
Patrik Lundin
108205ffc6 Make fail messages all use lowercase messages. 2016-12-08 11:34:28 -05:00
Patrik Lundin
3ac32cf365 Improve debug logging some more. 2016-12-08 11:34:28 -05:00
Patrik Lundin
89c5cddda1 No support for build=true with 'branch' syntax. 2016-12-08 11:34:28 -05:00
Patrik Lundin
04409cc214 Improve debug logging for build code. 2016-12-08 11:34:28 -05:00
Patrik Lundin
09b0871f17 Add a break and extra debug log for clarity. 2016-12-08 11:34:28 -05:00
Patrik Lundin
e8b1d27057 openbsd_pkg: no need to call .rstrip. 2016-12-08 11:34:28 -05:00
Patrik Lundin
24eab14695 openbsd_pkg: fix build=true corner case.
* Fix bug where we were actually checking for the availability of the
  requested package name and not 'sqlports' even if that was the goal.

* Add check that the sqlports database file exists before using it.

* Sprinkle some debug messages for an easier time following the code when
  developing.
2016-12-08 11:34:27 -05:00
Patrik Lundin
f686994af6 openbsd_pkg: support "pkgname%branch" syntax.
* Such package names requires at least OpenBSD 6.0.

* Rework get_package_state() to use 'pkg_info -Iq inst:' instead of 'pkg_info -e'
  because it understands the branch syntax. It also means we can get rid of
  some additional special handling.

  This was suggested by Marc Espie:
  http://marc.info/?l=openbsd-tech&m=146659756711614&w=2

* Drop get_current_name() because the use of 'pkg_info -Iq inst:' in
  get_package_state() means we already have that information available without
  needing to do custom parsing. This was also necessary because a name such as
  "postfix%stable" does not in itself contain the version information necessary
  for the custom parsing. pkg_info -Iq translates such a name to the actual
  package name seamlessly.

* Add support for finding more than one package for the supplied package name
  which may happen if we only supply a stem.
2016-12-08 11:34:27 -05:00
Daniel Jakots
ffc291bc9a fix the spelling of vim's flavor in the example 2016-12-08 11:33:46 -05:00
Scott Bonds
7f1ccad39b add python 2.5 requirement and ansible 2.1 version_added 2016-12-08 11:33:45 -05:00
Scott Bonds
056a532d75 add ports support in openbsd_pkg 2016-12-08 11:33:45 -05:00
Brian Coca
ae84177514 switched to use module loggigng 2016-12-08 11:33:24 -05:00
Patrik Lundin
e5b975a472 openbsd_pkg: Update author mail address. 2016-12-08 11:32:55 -05:00
Greg DeKoenigsberg
c65a612d1f Changes to author formatting, remove emails 2016-12-08 11:32:51 -05:00
Brian Coca
d344a3fde3 more string corrections 2016-12-08 11:32:39 -05:00
Michael DeHaan
7d6ceb4f06 Reorganization. 2016-12-08 11:32:19 -05:00
Renamed from lib/ansible/modules/extras/packaging/openbsd_pkg.py (Browse further)