Commit graph

211 commits

Author SHA1 Message Date
Dag Wieers
a417a4f4b3 Performance improvement using in-operator on dicts
Just a small cleanup for the existing occurrences.

Using the in-operator for hash lookups is faster than using .keys()
http://stackoverflow.com/questions/29314269/why-do-key-in-dict-and-key-in-dict-keys-have-the-same-output
2016-12-08 11:35:09 -05:00
René Moser
72eb8c7be9 ipify_facts: implement timeout (#3369) 2016-12-08 11:35:08 -05:00
Andrew Gaffney
a8d80f7165 Fix bare variable references in docs 2016-12-08 11:35:06 -05:00
Christophe Biocca
55130b960b haproxy: Fix compatibility when map is actually imap. (#3350)
While I still have no idea why or how the `map` call is being swapped out while still running in python 2.7, this change will fix the following error, as well as improve py3 compatibility.
2016-12-08 11:35:06 -05:00
jctanner
b3795322e9 More isinstance fixes (#3405)
* More isinstance fixes
* Use double types
2016-12-08 11:35:06 -05:00
Kei Nohguchi
cc95bc4935 openvswitch_bridge: Check VLAN ID only under fake bridge (#3374) 2016-12-08 11:35:06 -05:00
Tim Rupp
9efcfaff48 Adds bigip_sys_global module (#3271)
This module can be used to change a variety of system parameters
typically used for bootstrapping.

Tests for this module can be found here

https://github.com/F5Networks/f5-ansible/blob/master/roles/bigip_sys_global/tasks/main.yaml

Platforms this was tested on are

12.1.0-hf1
2016-12-08 11:35:02 -05:00
Tim Rupp
10697854e0 Adds route_domain parameter to the selfip module. (#3272)
This patch allows one to specify a route_domain to create the
selfip in.
2016-12-08 11:35:02 -05:00
Tim Rupp
a27de3adcc Adds route advertisement state to the bigip_virtual_server module (#3273) 2016-12-08 11:35:02 -05:00
Ryan Conway
15f32cf3d5 Adds support for setting a virtual server's "source address translation" policy to a specific SNAT pool, in addition to the 'None' or 'Automap' options. (#3158) 2016-12-08 11:35:02 -05:00
John R Barker
9fa1afc39f a10 - Use docs_fragments (#3281)
Remove duplicated documentation (common options defined in module_utils/a10.py).
Also tidy up formatting.
2016-12-08 11:35:02 -05:00
Tim Rupp
0055360315 Make irules module idempotent (#3175)
The irules module was failing to strip whitespace that is, for some
reason, automatically inserted by BIG-IP. This patch adds necessary
strips
2016-12-08 11:35:02 -05:00
Rene Moser
960f28692e docs: adjust version_added 2016-12-08 11:35:02 -05:00
Thierno IB. BARRY
60a32ba77f openvswitch_bridge: add fake bridge support (#3054)
* openvswitch_bridge: add fake bridge support

* openvswitch_bridge: check if vlan is between 0 and 4095
2016-12-08 11:35:02 -05:00
Rowan
713b9bbdf3 Added proxied option to cloudflare_dns (#2961) 2016-12-08 11:35:02 -05:00
John Barker
7b94e3de38 Conditional main()
This is needed to allow the debugger work
2016-12-08 11:35:02 -05:00
Toshio Kuratomi
ea05c56a41 Fix remaining python3 compile problems 2016-12-08 11:35:01 -05:00
Michael Scherer
9bdb567c56 Make netscaler pass python3 sanity check 2016-12-08 11:35:00 -05:00
Michael Scherer
04996c3720 Make nmcli pass py3 sanity check
Cleanup include, do not use '*' for future refactoring.

Since nmcli is not present on EL5, we can safely use python
2.6 syntax only.
2016-12-08 11:35:00 -05:00
Tim Rupp
56147c3771 Adds module to manage SNAT pools on a BIG-IP (#3217)
This module adds the ability to manage the lifecycle of SNAT pools on a BIG-IP.

Tests for this module can be found here

https://github.com/F5Networks/f5-ansible/blob/master/roles/bigip_snat_pool/tasks/main.yaml

Platforms this was tested on are

12.1.0 HF1
2016-12-08 11:35:00 -05:00
Tim Rupp
7bfb491ba5 Adds the bigip_hostname module (#3216)
This module can be used to change the hostname on a bigip. The
hostname must be set via the tmsh or API methods or else it will
not reflect properly in the config.

Tests for this module can be found here

https://github.com/F5Networks/f5-ansible/blob/master/roles/bigip_hostname/tasks/main.yaml

Platforms this was tested on are

12.0.0
12.1.0 HF1
2016-12-08 11:35:00 -05:00
Tim Rupp
5d3dafc02e Adds bigip_gtm_facts module (#3232)
This patch adds support for querying the GTM(DNS) facts from a
BIG-IP. This completes a previous PR that was requested but not
finished.

Tests for this module can be found here

https://github.com/F5Networks/f5-ansible/blob/master/roles/bigip_gtm_facts/tasks/main.yaml

Platforms this was tested on are

11.6.0
12.1.0 HF1
2016-12-08 11:35:00 -05:00
Michael Scherer
7f4fdba0c6 Make openvswitch* pass py3 sanity check 2016-12-08 11:35:00 -05:00
Michael Scherer
2ceb672016 Fix dnsmadeeasy module to pass py3 sanity check 2016-12-08 11:34:59 -05:00
Michael Scherer
adc62226d4 Make dnssimple compile on python 3 2016-12-08 11:34:58 -05:00
Ivan Bojer
3c06e2585a PanOS module for admin password change using PanOS API as the transport (#2930)
* PanOS module that allows admin password change.

* fixed a typo

* empty __init__.py

* added require ansible Python extension .py

* added version string

* added return docstring

* changed version to 2.2

* - changes to the format and module as requested by @privateip

* changed version back to 2.2 as 2.3 was failing automated tests

* Revert "changed version back to 2.2 as 2.3 was failing automated tests"

reverting version info

This reverts commit 71d520f3b4b69eb017c2b9f287a74cb77fae9d1c.
2016-12-08 11:34:57 -05:00
Tim Rupp
79895061b4 Fixes broken documentation in two modules (#3150)
The modules listed in this PR were using YAML that resulted in
blockquote tages being inserted into the generated RestructedText.

This PR fixes that so that the documentation once again looks correct
2016-12-08 11:34:57 -05:00
Peter Sprygada
00cc7c03fa Revert "update mask_passwords argument to be more descriptive in asa_config (#3109)" (#3110)
This reverts commit 271e300745b7200fc57383916d87efd6640d093e.
2016-12-08 11:34:56 -05:00
Peter Sprygada
1b6a424375 update mask_passwords argument to be more descriptive in asa_config (#3109)
This changes the passwords argument to mask_passwords to make the
argument more descriptive of its intended function
2016-12-08 11:34:56 -05:00
Peter Sprygada
d698a9b5f7 fixes asa_config to allow config to include passwords, defaults or none (#3102)
The fix allows the asa_config module to request the config to contain
all default statements or password information necessary for vpn
tunnel endpoints
2016-12-08 11:34:56 -05:00
Peter Sprygada
817881d64f fixes problem where wrong ACL could be selected (#3099)
This fixes a bug where the wrong acl name could be matched in the running
config if the desired acl name is a starting subset.
2016-12-08 11:34:56 -05:00
Tim Rupp
6f0477a780 Fixes the enabled_vlans argument (#3061)
This argument had a couple of issues with it. First, as it was
being interpreted in the code, it did not check for idempotency.

Second, the model of having the parameters be "all_*" is going to
hinder the ability to "undo", so-to-speak, what the user did while
maintaining legibility.

Consider if the user specified "all_enabled_vlans='net1'" and then
decided they wanted to backout of this decision. What is the proper
argument to fulfill this wish? "all_enabled_vlans='...?'

This patch changes the all_enabled_vlans argument to be "enabled_vlans",
ensures that idempotency works, and also provides for a way to "undo" a
change to the enabled VLANs by allowing the user to specify the special
case VLAN named "ALL" (all capitals).

This makes the parameter more intuitive because the users will specify
which vlans they want to make the virtual available on

  * enabled_vlans="net1"

but also allows them to "undo" what they did by setting it back with
the case of all

  * enabled_vlans="ALL"
2016-12-08 11:34:56 -05:00
Tim Rupp
223d5cc7ee Adds copyright line for F5 contributed modules (#3081)
I was asked to do this as part of the contribution effort in house
2016-12-08 11:34:56 -05:00
Tim Rupp
de08965ab3 Corrects the required SDK version (#3095)
The SDK version that was mentioned originally was incorrect
2016-12-08 11:34:56 -05:00
John R Barker
66eaa464ee Typos in doc's strings (#3071) 2016-12-08 11:34:55 -05:00
John R Barker
3a3612f57b asa_template is now deprecated (#2992)
* asa_template is now deprecated

* Delete asa_template

Since asa_template was added during 2.2 development, rather than
deprecate them
2016-12-08 11:34:55 -05:00
John R Barker
94bd3a70e5 Correct typos (#3055) 2016-12-08 11:34:55 -05:00
Tim Rupp
781dd9c459 Distinguish between untagged and tagged vlans
We were incorrectly making VLANS always be untagged when they could
be either tagged or untagged. This change corrects the arguments to
the vlan module to allow for specifying either untagged or tagged
interfaces. The arguments are mutually exclusive
2016-12-08 11:34:55 -05:00
Ryan Saunders
b48e1e9b65 Fix documentation typos and broken URL (#3039) 2016-12-08 11:34:54 -05:00
Tim Rupp
15df1c84ad Fixes the bigip_selfip module to respect traffic groups (#3009)
The code for traffic groups was not being tested and therefore
had errors associated with it. It is now covered in coverage tests
and bugs that were found in it have been fixed.

See this issue for details
https://github.com/F5Networks/f5-ansible/issues/28
2016-12-08 11:34:54 -05:00
Tim Rupp
5abc8a1927 Corrects an implied map() usage as list (#3010)
In the six package, the map() function returns an iterator instead
of a list. This code was continuing to use the map() return value
as if it were a list and this broke the address_class facts.

This patch changes the code to use the list() method on the return
value of map().
2016-12-08 11:34:53 -05:00
perbly
ec05027c7e added enabled vlan functionality for f5 vip (#2988)
* added vlan functionality for f5 vip

* line 91, : was missing after description
2016-12-08 11:34:53 -05:00
Tim Rupp
4e8566739e Fixes domains method not defined (#2907)
The domains method was not defined, and therefore when specifying
a parent domain during route domain creation, the process would
fail.

Tests have been added to detect this going forward
2016-12-08 11:34:50 -05:00
Peter Sprygada
4932df69bc updates to asa_config module for Ansible 2.2
* clean up functions and remove unneeded code
* config difference now includes keyword argument
* module reports changed when save argument is yes with or without check_mode
* updated fail_json return with exc kwargs
* fixed up import statements
2016-12-08 11:34:50 -05:00
Peter Sprygada
dc52d3627a fixes a number of nagging issues in asa_acl due to refactoring
* fixes issues with import error
* removes need for filter attribute in Cli instance
* now filters config either from device or provided via config argument

ref: #2890
2016-12-08 11:34:50 -05:00
Peter Sprygada
7ce98f52cf bug fix in asa_acl module for missing candidate config
This bug was introduced accidentally when refactoring to 2.2.  The instance
of the candidate config was deleted.  This adds the candidate config
instance back

fixes #2890
2016-12-08 11:34:50 -05:00
John R Barker
3f1c3a0532 Document a10_server new options (#2876)
* Document write_config and validate_certs
2016-12-08 11:34:49 -05:00
Tim Rupp
7e36f4f302 Adds bigip_ssl_certificate module (#2831)
Adds bigip_ssl_certificate module

This module is another in the ongoing "bootstrapping saga" that is
being undertaken. With this module you can manage the lifecycle of
the SSL certificates on a BIG-IP. This includes those used for
SSL offloading.

Tests for this module can be found here

https://github.com/F5Networks/f5-ansible/blob/master/roles/__bigip_ssl_certificate/tasks/main.yaml

Platforms this was tested on are

12.0.0
12.1.0
2016-12-08 11:34:49 -05:00
Michael Scherer
f8b7ab1e10 Do not crash if the system do not have required modules (#2852) 2016-12-08 11:34:49 -05:00
Peter Sprygada
32bbddee23 update asa_config module
* removes get_module() factory method for NetworkModule
* add src argument to provide path to config file
* add new choice to match used to ignore current running config
* add update argument with choices merge or check
* add backup argument to backup current running config to control host
* add defaults argument to control collection of config with or withoutdefaults
* add save argument to save current running config to startup config
2016-12-08 11:34:48 -05:00