James Cammarata
7034bbef30
Merge branch 'connection-locking' of https://github.com/amenonsen/ansible into amenonsen-connection-locking
2015-09-02 23:54:52 -04:00
Abhijit Menon-Sen
9378c8e2da
Make the paramiko plugin use locking
2015-09-03 08:43:21 +05:30
Abhijit Menon-Sen
5887e96b27
Introduce a connection locking infrastructure
...
The lock file is (a temporary file) opened in the parent process, whose
open fd is inherited by the workers after fork, and passed down through
the PlayContext. Connection grows lock/unlock methods which can be used
by individual connection plugins.
2015-09-03 08:43:21 +05:30
Abhijit Menon-Sen
12d8f9132e
Make lock_host_keys a real noop, instead of half-a-noop
...
Right now, we don't do any locking, but we still scan known_hosts files
twice per connection. That's completely unnecessary, and the proposed
solutions to the locking problem wouldn't need known_hosts scanning
anyway, so this code can go away.
2015-09-03 05:52:57 +05:30
Brian Coca
a006e85947
removed printing module args as it violates no_log settings
2015-09-02 16:14:40 -04:00
James Cammarata
f162990cb3
Properly assign the searchpath for templates to the environment loader
...
dbd755e0
previously assigned the value to self._templar.environment.searchpath,
which is incorrect - it needs to be assigned to the environment.loader.searchpath
value instead.
Fixes #11931
2015-09-01 17:33:14 -04:00
James Cammarata
d00c445d2c
Merge pull request #12188 from amenonsen/easy-debug
...
Show module name and args with -vvv
2015-09-01 14:15:15 -04:00
Abhijit Menon-Sen
d6d523bcae
Show module name and args with -vvv
...
This information was earlier shown only with ANSIBLE_DEBUG, but it's
extremely useful in a user context, especially with module invocations
with deeply nested args like the ec2_vpc/ec2 modules.
Closes #11680
2015-09-01 23:44:13 +05:30
James Cammarata
974b69d236
looped includes need unique references to prevent information bleeding
...
Fixes #12155
2015-09-01 12:32:35 -04:00
Brian Coca
7458331539
package and service now check that module exists before trying to execute it
2015-08-31 20:34:20 -04:00
James Cammarata
fca27c29f4
Properly fail if slurp fails during fetch
2015-08-31 16:45:03 -04:00
James Cammarata
66a2f2923e
Look for proper values in slurp result during fetch with become enabled
2015-08-31 16:36:07 -04:00
Brian Coca
6b73cac35a
corrected skipped_hosts constant usage, thanks @benjixx
2015-08-30 20:21:15 -04:00
Brian Coca
5a65dce6fb
fix issues with csh redirection
2015-08-30 17:49:16 -04:00
Brian Coca
6154ed1dda
Merge pull request #12146 from thekarlbrown/patch-1
...
Fixed Spelling Error on Line 67
2015-08-28 20:10:47 -04:00
James Cammarata
f0257683b0
Fixed missing constants import in default callback
...
Fixes #12145
2015-08-28 16:54:56 -04:00
James Cammarata
057712c129
Also move action/connection plugins to shared plugin loader code
...
Fixes #12099
2015-08-28 16:32:09 -04:00
Karl Brown
9aae1d5810
Fixed Spelling Error on Line 67
...
Noticed while running Ansible from Tip.
Throws: NameError: global name 'tself' is not defined
2015-08-28 15:45:49 -04:00
Brian Coca
b6c6ed91fe
implemented not showing skipped hosts config
2015-08-28 12:32:50 -04:00
James Cammarata
66ed397360
Fix redis fact_caching_timeout=0 bug
...
Fixes #12018
2015-08-28 11:47:06 -04:00
James Cammarata
5a5b9f211b
Validate variable names when loading 'vars:' blocks
...
TODO: add this to VariableManager to validate vars loaded from files too
Fixes #12022
2015-08-28 11:36:31 -04:00
Marius Gedminas
df1b41d3d3
Avoid types.NoneType
...
types.NoneType was removed in Python 3.
None is a singleton in Python, so 'x is None' is equivalent to
'isinstance(x, NoneType)'.
2015-08-27 22:15:56 +03:00
Marius Gedminas
39196ec91e
Drop the L suffix on numerical constants
...
Python has had automatic int-to-long promotion for a long long time now.
Even Python 2.4 does that automatically.
Python 3 drops support for the L suffix altogether.
2015-08-27 22:15:04 +03:00
Marius Gedminas
0eb538df03
Use 0oNNN octal syntax
...
This syntax is valid in Python 2.6+ and 3.x.
2015-08-27 22:15:04 +03:00
Marius Gedminas
0c6ce31f76
Use 'except ... as' syntax
...
This syntax works on Python 2.6 through 3.x. lib/ansible/module_utils
(and lib/ansible/modules) need to support Python 2.4, so I didn't touch
those.
2015-08-27 22:15:04 +03:00
Abhijit Menon-Sen
b328bc023d
Add a combine filter with documentation
...
This is based on some code from (closed) PR #7872 , but reworked based on
suggestions by @abadger and the other core team members.
Closes #7872 by @darkk (hash_merge/hash_replace filters)
Closes #11153 by @telbizov (merged_dicts lookup plugin)
2015-08-27 23:29:12 +05:30
Brian Coca
b2bfe3502b
make sure delimiter is basestring for cvsfile
...
fixes #12062
2015-08-26 18:38:39 -04:00
James Cammarata
0441a7a217
Finishing off porting of chroot connection plugin
2015-08-26 16:43:06 -04:00
Toshio Kuratomi
017bd7b1cd
Fix synchronize lookup of localhost info
2015-08-26 13:36:50 -07:00
Thomas Quenolle
c948af3b1e
Synchronize fix error
...
Fix the error:
"RuntimeError: dictionary changed size during iteration"
2015-08-26 11:01:00 +02:00
James Cammarata
601a1cc6d9
Multiple fixes for include statements and blocks in general
...
Fixes #11981
Fixes #11995
Fixes #12039
Fixes #12077
2015-08-26 02:23:22 -04:00
Toshio Kuratomi
56ae3a032f
Merge pull request #12075 from ansible/fix-vault-unicode
...
Unicode and other fixes for vault
2015-08-25 14:49:15 -07:00
Toshio Kuratomi
a3fd4817ef
Unicode and other fixes for vault
2015-08-25 12:43:09 -07:00
Toshio Kuratomi
156feec264
Merge pull request #11650 from objectified/feature-docker-connection
...
allow ansible to connect to docker containers (without using ssh)
2015-08-25 09:28:25 -07:00
Brian Coca
ae91cdfc98
fixed environment inheritance
2015-08-25 10:15:32 -04:00
objectified
b1785a0361
replace compare_versions() with distutils.version
2015-08-25 02:18:37 -04:00
objectified
c39fb43ad9
added Maintainer comment header
2015-08-25 02:06:01 -04:00
Brian Coca
17060f9849
remove +1 from size that was cutting off first char of copied files when a recursive dir
...
fixes #12055
2015-08-24 21:10:03 -04:00
objectified
d9723069c5
align exec_command() definition with local.py
2015-08-24 12:32:11 -04:00
objectified
3a5522a22c
fake being connected for logging purposes
2015-08-24 12:32:11 -04:00
objectified
8f2a6a9fae
use docker cp when docker >=1.8.0
2015-08-24 12:32:11 -04:00
objectified
2de773477f
allow ansible to connect to docker containers
2015-08-24 12:32:11 -04:00
James Cammarata
db65503778
Revert "Add PowerShell exception handling and turn on strict mode."
2015-08-23 21:09:16 -04:00
Brian Coca
3ccfebc9f7
Merge pull request #12047 from cchurch/powershell_common_cleanup
...
Add PowerShell exception handling and turn on strict mode.
2015-08-23 14:08:18 -04:00
Abhijit Menon-Sen
09e4eac2e5
Use rsplit(':',1) for clarity; no functional changes
2015-08-23 22:52:35 +05:30
Ryan Petrello
1886307845
Fix a parsing bug that prevents IPv6 addresses from being used with add_host
...
Closes #8682
2015-08-23 22:50:47 +05:30
Chris Church
4b2cdadc98
Add PowerShell exception handling and turn on strict mode.
...
* Add exception handling when running PowerShell modules to provide exception message and stack trace.
* Enable strict mode for all PowerShell modules and internal commands.
* Update common PowerShell code to fix strict mode errors.
* Fix an issue with Set-Attr where it would not replace an existing property if already set.
* Add tests for exception handling using modified win_ping modules.
2015-08-22 18:28:07 -04:00
Brian Coca
47d9e7ca93
Merge pull request #11984 from Alphadelta14/devel
...
Support any Mapping for with_dict lookup.
2015-08-22 12:39:42 -04:00
Brian Coca
f150fe2c23
moved mandatory back to filters as it does not always return a boolean, it does an exception on failure
2015-08-21 09:54:56 -04:00
Brian Coca
2787b3acac
ported consul_kv lookup from v1
2015-08-21 00:22:20 -04:00