Lindsay Hill
727503c5ab
fix typo in edit_config_capability name ( #44102 )
2018-08-14 09:17:50 +05:30
Trishna Guha
96346938ee
nxos_vlan refactor to support non structured output ( #43805 )
...
* nxos_vlan refactor to support non structured output
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* unittest fix
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* minor fixes
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* use check_rc
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* address review comment
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* remove additional return statement
* address Nate's review
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-08-10 21:03:56 +05:30
Ganesh Nalawade
d1de1e0449
Update iosxr cliconf plugin ( #43837 )
...
* Update iosxr cliconf plugin
Fixes #39056
* Update iosxr cliconf plugin
* Modify iosxr module_utils code to support
refactored cliconf plugin api's
* Other minor changes
* Fix unit test failure
* Update ios, eos, nxos plugin for diff
* Fix review comment
2018-08-10 13:12:51 +05:30
Ganesh Nalawade
35adc12c38
Update junos cliconf plugin ( #43643 )
...
* Update junos cliconf plugin
Fixes #39056
Refactor junos cliconf plugin api and other
minor changes
* Fix CI issue
* Fix CI failure
2018-08-06 10:08:05 +05:30
Trishna Guha
09ae1ec308
cliconf refactor eos, nxos fix ( #43596 )
...
* cliconf refactor eos and nxos fix
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* move nxos replace check to plugins
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* address review comment
* fix shippable
2018-08-02 16:34:48 +05:30
Ganesh Nalawade
733e512f35
Fix typo in cliconf get_config ( #43553 )
2018-08-02 09:44:30 +05:30
Ganesh Nalawade
857200fa7f
Update cliconf get_config api ( #43472 )
...
* Change `filter` parameter to `flag` to be in sync
with original naming convention
2018-07-31 02:53:29 -07:00
Ganesh Nalawade
af3f510316
nxos cliconf plugin refactor ( #43203 )
...
* nxos cliconf plugin refactor
Fixes #39056
* Refactor nxos cliconf plugin as per new api definition
* Minor changes in ios, eos, vyos cliconf plugin
* Change nxos httpapi plugin edit_config method to be in sync with
nxos cliconf edit_config
* Fix CI failure
* Fix unit test failure and review comment
2018-07-27 11:05:40 +05:30
Trishna Guha
dd6ef3355f
get_device_info nxos zero or more whitespace regex ( #43178 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-07-24 10:55:37 +05:30
Trishna Guha
df8ad8ebf9
fix regex cliconf nxos ( #42288 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-07-04 10:46:28 +05:30
Trishna Guha
0e05425b32
Refactor nxos cliconf get_device_info and add requirements for JSON structured output support in nxos_facts module ( #42089 )
...
* nxos_facts requires JSON structured output support
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* refactor get_device_info for legacy devices
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* update additional logic
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-07-03 19:44:50 +05:30
Trishna Guha
f170298332
fix nxos edit_config for httpapi and have uniform load_config ( #41358 )
...
* fix nxos load_config for httpapi and migrate to cliconf
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* add comment
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* address review comment
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* address review comment
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-06-14 22:02:12 +05:30
Trishna Guha
a7421e8611
httpapi fix nxos ( #40806 )
...
* httpapi fix nxos
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* nxos_hsrp fix
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-05-29 21:43:34 +05:30
Nathaniel Case
c04d0ebc23
Connection-side, the expection is AnsibleConnectionFailure ( #40658 )
2018-05-24 09:43:59 -04:00
Nathaniel Case
d028a0257a
Change default output of NXAPI to text to match CLI ( #40607 )
...
* Default output format for nxapi now 'text'
* Apply json output to both types of input
* Add missing ConnectionError import to cliconf plugins
2018-05-23 10:09:50 -04:00
Nathaniel Case
e9d7fa0418
HTTP(S) API connection plugin ( #39224 )
...
* HTTPAPI connection
* Punt run_commands to cliconf or httpapi
* Fake enable_mode on eapi
* Pull changes to nxos
* Move load_config to edit_config for future-preparedness
* Don't fail on lldp disabled
* Re-enable check_rc on nxos' run_commands
* Reorganize nxos httpapi plugin for compatibility
* draft docs for connection: httpapi
* restores docs for connection:local for eapi
* Add _remote_is_local to httpapi
2018-05-17 18:47:15 -04:00
Nathaniel Case
3b3c72f3e5
Fix use of bytes in cliconf plugins for Python 3 ( #37715 )
...
* Remove raw byte-strings from cliconf plugins of supported platforms + edgeos
Remove uses of to_bytes, too
* Update CliConfBase docstring to reflect current position on byte strings
2018-04-17 10:15:21 -04:00
Peter Sprygada
fb6a8c0133
fix cliconf get_config method to match base signature ( #36682 )
...
This commit fixes up the get_config method to match the minimum method
signature as defined by the base class. Without this patch, the
get_config method calls will fail in some cirumstances.
2018-02-26 10:56:22 -05:00
Nathaniel Case
c371ed8d30
nxos tests to use network_cli ( #34474 )
...
* Fix over-byte
* Fix nxos_l2_interface docs
* Update connections for tasks
* Add default ssh port
* Only report provider when using connection=local
* Send empty provider when connection=network_cli
* Fix find tasks
2018-01-05 12:39:04 -05:00
Trishna Guha
9f86b923e9
[CLI_CONF] Refactor nxos module common library to use cliconf plugin ( #31524 )
...
* refactor nxos modules
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* get_config update
* fix get_config
* update nxos module
* device_info
* fix conflict
* add failure message check
* pep8 fixes
* use get_capabilities to check cliconf
* Add logic to detect platform in get_capabilities and cache in module_utils
* return msg in edit_config
* fix conflicts
* make modules compatible
* fix nxos cliconf api
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* cache capabilities
* Update transport queries to get_capabilities in module level
* fix unit tests
* load_config error code
* remove unnecessary change
* Refactor nxos_install_os module
2017-12-19 12:22:33 +05:30
Ganesh Nalawade
11c9ad23d5
Refactor common network shared and platform utils code into package ( #33452 )
...
* Refactor common network shared and platform specific code into package (part-1)
As per proposal #76 refactor common network shared and platform specific
code into sub-package.
https://github.com/ansible/proposals/issues/76
* ansible.module_utils.network.common - command shared functions
* ansible.module_utils.network.{{ platform }} - where platform is platform specific shared functions
* Fix review comments
* Fix review comments
2017-12-03 21:42:30 +05:30
Kedar K
6749a39dbe
Change cliconf get() method signature with explicit args ( #33341 )
...
* Change cliconf get() method signature to explicit args instead of *args and **kwargs
* updates doc string
2017-11-28 21:40:58 +05:30
Ganesh Nalawade
6215922889
Add support for cliconf and netconf plugin ( #25093 )
...
* ansible-connection refactor and action plugin changes
* Add cliconf plugin for eos, ios, iosxr, junos, nxos, vyos
* Add netconf plugin for junos
* Add jsonrpc support
* Modify network_cli and netconf connection plugin
* Fix py3 unit test failure
* Fix review comment
* Minor fixes
* Fix ansible-connection review comments
* Fix CI issue
* platform_agnostic related changes
2017-06-06 13:56:25 +05:30
