ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-04-25 03:41:25 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 9
22878 commits 11 branches 190 tags 299 MiB
Commit graph

16 commits

Author SHA1 Message Date
Sarah Haskins
3ad19e75cc Expose cache_parameter_group_name in elasticache module 
The cache_parameter_group_name was not previously exposed in
elasticachy.py, I have exposed it, as optional.
 2016-12-08 11:23:45 -05:00
Alex Kessinger
4d227e508d Fix a argument mismatch in elasticache 
I think in this commit 720aeffca2bd2ae1eca158abc2d1463a8597afb6

There was bug introduced where the ElastiCacheManager init method has
a number of positional arguments like so.

```py
    def __init__(self, module, name, engine, cache_engine_version, node_type,
                 num_nodes, cache_port, parameter_group, cache_subnet_group,
                 cache_security_groups, security_group_ids, zone, wait,
                 hard_modify, region, **aws_connect_kwargs):
```

But then later in the code the positional arguments are passed in
like this.

```py
    elasticache_manager = ElastiCacheManager(module, name, engine,
                                             cache_engine_version, node_type,
                                             num_nodes, cache_port,
                                             cache_subnet_group,
                                             cache_security_groups,
                                             security_group_ids, parameter_group, zone, wait,
                                             hard_modify, region, **aws_connect_kwargs)
```

If you count, you can see that cache_subnet_group, is being passed in
where the manager expects to see parameter_group.
 2016-12-08 11:23:38 -05:00
Scot Spinner
0fff871819 one thing missed 2016-12-08 11:23:31 -05:00
Scot Spinner
bcc57875ed adding parameter group option 2016-12-08 11:23:29 -05:00
Frank van Tol
39e24e89f4 Remove default port value, it does not work in _requires_destroy_and_create logic 
When creating a Redis cluster, every run it gets destroyed and recreated because the port number of memcached is used as the default.
 2016-12-08 11:23:20 -05:00
Frank van Tol
6655cd89c4 Update elasticache.py 2016-12-08 11:23:20 -05:00
Frank van Tol
426f93a291 Remove default for engine_version 
Redis and memcached have different engine version numbering, there can not be a shared default value.
 2016-12-08 11:23:20 -05:00
Greg DeKoenigsberg
18ca7aee07 Updating cloud modules with proper github author information 2016-12-08 11:23:07 -05:00
steenzout
67f769d9a6 issue #994: use HAS_BOTO to determine if import was successful: - removed import of sys module. - HAS_BOTO constant to check if import was successful. - trigger a failure when import fails. - removed unnecessary imports. 2016-12-08 11:22:53 -05:00
Brian Coca
4f7bc895d2 removed requirements/boto as it broke documentation as it is duplicated in shared aws fragements 2016-12-08 11:22:51 -05:00
Mick Bass
9980205edc Add support for AWS Security Token Service (temporary credentials) to all AWS cloud modules. 2016-12-08 11:22:51 -05:00
Brandon W Maister
c1571928e5 Make cache_subnet_group default to empty security groups 
Since they can't be specified together, it seems like setting the
default to no security groups is the right option.
 2016-12-08 11:22:51 -05:00
Brandon W Maister
cffb2bdee9 Add cache_subnet_group to elasticache module 
According to the [docs] cache subnet groups are required inside a VPC.

[docs]: http://docs.aws.amazon.com/AmazonElastiCache/latest/UserGuide/CacheSubnetGroups.html
 2016-12-08 11:22:50 -05:00
Toshio Kuratomi
f3d41cdb06 Potential fix for 640 2016-12-08 11:22:38 -05:00
Michael DeHaan
76efaa6cfb More EC2 doc tweaks 2016-12-08 11:22:29 -05:00
Brian Coca
32e85c0944 made subcategories for cloud modules for better organization 2016-12-08 11:22:24 -05:00
Renamed from lib/ansible/modules/cloud/elasticache.py (Browse further)