Commit graph

199 commits

Author SHA1 Message Date
Dale Smith
7404418cbd Fix regression of #821 in puppet of show_diff
Issue #821 fix: 1382576100ee3b17f4eb28c7186d92376f370676
Regressed since: 6912ca0acaed0d738d8dd9867721d2ff0094084a

Issue: #821
2016-12-08 11:33:46 -05:00
Yannig Perré
bf5fbfe2a7 Use -f when pvcreate to avoid interactive input. Fix https://github.com/ansible/ansible-modules-extras/issues/1504 2016-12-08 11:33:46 -05:00
Daniel Vigueras
801e895f62 iptables: fix param check in append_csv function 2016-12-08 11:33:46 -05:00
Michal Mach
855bf75709 Fix seport module issue when ports argument is interpolated from a variable and is a int 2016-12-08 11:33:46 -05:00
Alexander Bulimov
23675c3f8b Allow recreation of same FS with force=yes 2016-12-08 11:33:46 -05:00
Alexander Gubin
58f3518666 Make fileystem module idemponent. Compare devicesize and filesystemsize. 2016-12-08 11:33:46 -05:00
colynn.liu
ed48fb0f25 fixed python 2.4 compatibility
nf=tempfile.NamedTemporaryFile(delete=False)
TypeError: NamedTemporaryFile() got an unexpected keyword argument 'delete'
2016-12-08 11:33:45 -05:00
Björn Lichtblau
f9383cb8ef Check to make sure the firewalld client is connected before proceeding.
Fixes #1138

Original patch referenced in https://github.com/ansible/ansible/issues/6911 ( f547733b1f ) was undone by 6f2b61d2d8
2016-12-08 11:33:45 -05:00
Tom X. Tobin
1223143ebe osx_defaults: Fix boolean value parsing
Values for boolean types were being unconditionally treated as strings
(by calling `.lower()`), thus breaking value parsing for actual boolean
and integer objects.

It looks like the bug was introduced in:

- 130bd670d82cc55fa321021e819838e07ff10c08

Fixes #709.
2016-12-08 11:33:45 -05:00
Linus Unnebäck
a928198783 iptables: cleanup 2016-12-08 11:33:44 -05:00
Jeroen Geusebroek
f1c3eb1413 Fix documentation default value for gluster_volume start_on_create 2016-12-08 11:33:44 -05:00
Jose A. Rivera
73a9abd1c8 gluster_volume: allow probing ourselves
We should allow "gluster peer probe" to determine if a given "host" maps to the
localhost, and detect that case accordingly.
2016-12-08 11:33:44 -05:00
Benjamin Wilson
0a8310b29f Properly handle adding multiple bricks to volume 2016-12-08 11:33:44 -05:00
Toshio Kuratomi
ad0d2c1747 Update for modules which import json.
Some do not use the json module directly so don't need import json.
Some needed to fallback to simplejson with no traceback if neither was installed

Fixes #1298
2016-12-08 11:33:44 -05:00
Jonathan Mainguy
be5dd09237 add snapshot feature to lvol 2016-12-08 11:33:43 -05:00
Jonathan Mainguy
badef2912b Remove advertising show_diff feature
--diff will be added to more modules soon, and we want puppet module to utilize this instead of show_diff
2016-12-08 11:33:41 -05:00
Casey Lang
1c8ad72b7b Fix puppet module formatting issue
The `->` in the `show_diff` option doc seemed to be causing the docs
page to break. Not sure why, since it was still valid YAML.
2016-12-08 11:33:41 -05:00
ag-wood
67cd464ac7 Fix for ansible-modules-extras issue #1080 2016-12-08 11:33:41 -05:00
Jeroen Geusebroek
0b12f35f61 Improved fix for #1074. Both None and '' transform to fqdn. 2016-12-08 11:33:41 -05:00
Jeroen Geusebroek
6fc533d663 Fix for issue #1074. Now able to create volume without replica's. 2016-12-08 11:33:41 -05:00
Matt Martz
74c3e008d2 Import module snippets in the correct location 2016-12-08 11:33:40 -05:00
Matt Martz
7f42dda976 Remove unneeded spaces at the end of ohai 2016-12-08 11:33:40 -05:00
Michael Scherer
df195b3076 Replace choices=BOOLEANS by type='bool', fix #1326 2016-12-08 11:33:40 -05:00
Monty Taylor
40a4247611 Sync minor fixes from OpenStack Infra
Infra has been keeping a local copy of this waiting for ansible 2 to
release. In getting ready for ansible 2 (and our ability to delete our
local copy of the file, I noticed we had a couple of minor cleanups.

Also, the timeout command is there to improve life and workaround puppet
deficiencies. However, it's not working around deficiencies on systems
that do not have the timeout command if we blindly use it.

The puppet specific timeout options are more complex and out of scope of
this.

Issue: #1273
2016-12-08 11:33:39 -05:00
Will Keeling
f1f98a15ca Fixes #634 - multiple param handling by modprobe.py 2016-12-08 11:33:38 -05:00
Gordon Fierce
c23162c04b Fix documentation to prevent formatting error where each letter has its own line. 2016-12-08 11:33:37 -05:00
Michael Scherer
4e4085ad7e Add a more explicit error message, fix #1282 2016-12-08 11:33:37 -05:00
Guillaume Grossetie
af12e6d3a3 Resolves #1312, Improve pam_limits documentation
Adds comment parameter and improve examples.
2016-12-08 11:33:37 -05:00
GUILLAUME GROSSETIE
5fbc5cb529 Resolves #1290, Adds limit_type choice "-" 2016-12-08 11:33:36 -05:00
Xav Paice
f30dbc9b20 Added stdout and stderr to puppet output for rc=2 2016-12-08 11:33:36 -05:00
Brian Coca
4ddb181d71 removed json import 2016-12-08 11:33:36 -05:00
Romain Brucker
e8b5b8bd20 Editing iptable module to use -m state --state instead of -m conntrack --ctstate 2016-12-08 11:33:34 -05:00
Romain Brucker
3ef5be470f Fixing limit type from list to string 2016-12-08 11:33:33 -05:00
Romain Brucker
fbad76e86a Adding limit feature to iptables module 2016-12-08 11:33:33 -05:00
Brian Coca
61ba4b98e1 made ctstate default to [] and evaluation conditional on the list being popoulated 2016-12-08 11:33:33 -05:00
Brian Coca
fb3aec47ca fixed default from None to [] for ctstate 2016-12-08 11:33:33 -05:00
Brian Coca
eae8942583 avoid index error on empty list, key being true means its not None nor [] fixes #13009 2016-12-08 11:33:33 -05:00
Brian Coca
eb4fe5a0d8 made ctstate accept lists 2016-12-08 11:33:32 -05:00
Daniel Vigueras
d332a9a8e4 Add conntrack module ctstate support to iptables 2016-12-08 11:33:32 -05:00
Monty Taylor
9b9464ab89 Revert "Change show_diff to default to yes"
This was originally to match what puppet agent --test is, since the
rest of the options defaulted to on are grabbed from --test. However,
some security concerns have since been raised - namely that since this
is not the same invocation as --test but instead a remote orchestration
of puppet, the fact that passwords leak into the diff is a dangerous
default.

This reverts commit b86762c1806aa7f021a4780d06db2d3937910a62.
2016-12-08 11:33:31 -05:00
Brian Coca
29fad0223d whitespace fixes 2016-12-08 11:33:30 -05:00
Romain Brucker
e4ce38fa0b Adding comment support for iptables module 2016-12-08 11:33:30 -05:00
Brian Coca
50905e5673 fixed typos in cryptab, thanks @timw fixes #1176 2016-12-08 11:33:30 -05:00
Alexander
8e509c2736 fix typo error
fix spell error for whether
2016-12-08 11:33:30 -05:00
Matt Carroll
164e1f3baa Fix ZFS create
This was failing due to the createparent variable being referenced but
never actually loaded from properties
2016-12-08 11:33:30 -05:00
Ondra Machacek
d43d4718f3 system: pam_limits: add support for unlimited/infinity/-1
Early pam_limits module didn't support special values for items.
This patch is adding support to special values unlimited, infinity and -1.

Issue: https://github.com/ansible/ansible-modules-extras/issues/1033
Signed-off-by: Ondra Machacek <machacek.ondra@gmail.com>
2016-12-08 11:33:30 -05:00
Jonathan Mainguy
451a05c1a2 Change show_diff to default to yes, to match what puppet agent --test is, since the rest of the options defaulted to on are grabbed from --test 2016-12-08 11:33:30 -05:00
Toshio Kuratomi
0111b616d7 Fix docs to build 2016-12-08 11:33:28 -05:00
Linus Unnebäck
ebfb8bc7cf iptables: add note about rules 2016-12-08 11:33:28 -05:00
Linus Unnebäck
8d93747275 iptables: expand rule options 2016-12-08 11:33:28 -05:00