Commit graph

205 commits

Author SHA1 Message Date
nitzmahone
4ff086c1a8 Fix win_chocolatey version comparison
fixes #2995
2016-12-08 11:34:54 -05:00
nitzmahone
6db9ed981e clean up win_chocolatey doc bugs, remove redundant 2016-12-08 11:34:41 -05:00
Greyeye
4bae025666 pass flag to choco, allowemptychecksums and ignorechecksums (#2722) 2016-12-08 11:34:41 -05:00
nitzmahone
2c87fe3b58 make the win_chocolatey force arg actually work
fixes #1561
2016-12-08 11:34:41 -05:00
nitzmahone
a2f9e0d2fe isolate chocolatey bootstrapper execution
fixes #2742
added output capture/return, exit code check to bootstrapper exec
2016-12-08 11:34:41 -05:00
Andrea Scarpino
b54d352a69 win_firewall_rule: fix "property X doesn't exist"
After commit 9392943 more properties are always sets with their defaults
values (e.g. service to 'any'). This causes no issue when the rule is created,
but causes an error message that says "The property 'X' cannot be found on this
object. Verify that the property exists." because the module checks for
any property value that has changed, but `netsh advfirewall firewall show rule`
does not list any property unless `verbose` is set. This patch solves this.

Fixes #2624
2016-12-08 11:34:41 -05:00
trondhindenes
20844c1ef6 updated documentation for win_package (#2677) 2016-12-08 11:34:38 -05:00
Robin Schneider
f408a4db02 Use HTTPS instead of legacy HTTP for ansible.com (#2636)
Mechanical edit done by this "one-liner":

git ls-files -z "$(git rev-parse --show-toplevel)" | xargs --null -I '{}' find '{}' -type f -print0 | xargs --null sed --in-place --regexp-extended 's#http://www\.ansible\.com#https://www.ansible.com#g;'

Related to: https://github.com/ansible/ansible/issues/16869
2016-12-08 11:34:36 -05:00
Trond Hindenes
6972df76ef bugfix code error in win_firewall 2016-12-08 11:34:25 -05:00
nitzmahone
10ea69c8de fix win_updates to prevent Get-Member failure on bogus job output 2016-12-08 11:34:25 -05:00
Andrea Scarpino
9b41c6bfe3 win_firewall_rule: strictmode fixes (#2432)
I set the default values to `netsh advfirewall firewall add rule` defaults.
2016-12-08 11:34:24 -05:00
Tim Small
efb29d6436 Allow parameters to be passed for uninstall (required by some packages) (#2269) 2016-12-08 11:34:24 -05:00
nitzmahone
2809c1ca07 add win_chocolatey support for nonzero success exit codes 2016-12-08 11:34:24 -05:00
jhawkesworth
b32c550e22 Various fixes to win_regedit and documentation (#2436) 2016-12-08 11:34:23 -05:00
nitzmahone
e5e1869403 StrictMode fixes for win_iis_webbinding
StrictMode fixes for win_scheduled_task

StrictMode fixes for win_webpicmd
2016-12-08 11:34:23 -05:00
Andrea Scarpino
5bec8ad321 Fix win_environment: strict-mode fix for 'value' (#2404) 2016-12-08 11:34:23 -05:00
Rob Powell
09a53fb225 Update win_firewall_rule.py (#2337)
added profile examples as my firewall task would pass yet no firewall rule was created until I added

profile: Domain,Private,Public

When setting a Firewall rule on Windows Server 2008 R2 manually, these three are selected as default, useful to have in the documentation maybe?
2016-12-08 11:34:22 -05:00
Dag Wieers
7e5e9bd7e8 Validate return code and fail properly (#2334)
This fixes #2333
2016-12-08 11:34:22 -05:00
Toshio Kuratomi
f159597914 Make documentation of win_unzip work on python3 as well 2016-12-08 11:34:20 -05:00
jjshoe
2ba75b7082 A couple of touch ups (#2288)
I peeked at #2281 a little late, thought this might help some as well.
2016-12-08 11:34:19 -05:00
René Moser
99646d5dbb fix build and doc cleanups (#2286) 2016-12-08 11:34:17 -05:00
jhawkesworth
ac44058457 Add info about where you can find product ids for changed checking on win_package module (#2281) 2016-12-08 11:34:17 -05:00
Nicolas Landais
e93f7241be Fix problem with 'restarted' state not restarting the apppool when it is in running state (#1451)
* Fix problem with 'restarted' state not restarting the apppool when it is in running state

* Implemeting code review comments

Comment from previous commit “You basically want to start the pool if
it's stopped and requested state is started or restarted, otherwise if
requested state is restarted, restart it.” This commit implements the
behavior stated in the PR comment
2016-12-08 11:34:16 -05:00
Corwin Brown
d0ada049f2 Add Win Robocopy module (#1078)
* Added more robust error handling

* Add Win Synchronize module

Renamed win_synchronize to win_robocopy

Updating email address

Adding "flags" argument.

Adding a "flags" argument that will allow the user to pass args
directly to robocopy.

If "flags" is set, recurse and purge will be ignored.

Add return code to output

Added bits to support check mode

Fixing typo in Documentation

Updated Documentation to have "RETURNED" field

Updated win_robocopy.py to have the RETURNED field. I also noticed
that win_robocopy.ps1 wasn't really using the "changed" attribute,
so I went in and made sure it was being set appropriately.

Forcing bool type for recurse and purge flag

Updated "version_added"
2016-12-08 11:34:16 -05:00
jhawkesworth@users.noreply.github.com
e878cf43f6 Fix for https://github.com/ansible/ansible-modules-extras/issues/2090 2016-12-08 11:34:10 -05:00
Hans-Joachim Kliemeck
b36fc23a50 suggestion by @nitzmahone to not use Get-Attr in combination with ConvertTo-Bool, improved documentation regarding organize 2016-12-08 11:34:09 -05:00
Hans-Joachim Kliemeck
ba0c75f5a7 fixed version added and tests 2016-12-08 11:34:09 -05:00
Hans-Joachim Kliemeck
867b7a9649 fixed bugs with flipped protection attribute 2016-12-08 11:34:09 -05:00
Hans-Joachim Kliemeck
632df80276 introduced state to differentiate between enabled/disabled inheritance. renamed copy to reorganize, since the meaning for inheritance=enabled is different 2016-12-08 11:34:09 -05:00
Hans-Joachim Kliemeck
bdf0a888bb suggestions by @marcind 2016-12-08 11:34:09 -05:00
Hans-Joachim Kliemeck
a240b14e09 added module to disable acl inheritance 2016-12-08 11:34:09 -05:00
jhawkesworth@users.noreply.github.com
b94a614b7e fix problem where you couldn't compare empty strings in win_regedit following my previous change 2016-12-08 11:34:08 -05:00
Dreamcat4
314843b431 win-firewall-rule: temp disable strict-mode for the time being 2016-12-08 11:34:08 -05:00
Dreamcat4
820d5a7a3e fix: win-environment strict-mode fixes 2016-12-08 11:34:08 -05:00
Dreamcat4
572b6669c4 fix: win-scheduled-task strict-mode fixes 2016-12-08 11:34:08 -05:00
jhawkesworth@users.noreply.github.com
b08b1cf2f3 Documentation improvements 2016-12-08 11:34:07 -05:00
jhawkesworth@users.noreply.github.com
aaa9541abd Further fixes to support binary data. Added boolean return values and return documentation. 2016-12-08 11:34:07 -05:00
jhawkesworth@users.noreply.github.com
c2ca0a9e93 adding the ability to manage binary registry data 2016-12-08 11:34:07 -05:00
Andrea Scarpino
b4064a352e The enable parameter is a boolean, then convert to a boolean. (#1607)
At the moment, this only works when 'enable' is equals to 'yes' or 'no'.

While I'm on it, I also fixed a typo in the example and added a required
parameter.
2016-12-08 11:34:05 -05:00
nitzmahone
bd3172b2e8 win_updates fix to use documented InstanceGuid property name 2016-12-08 11:34:03 -05:00
nitzmahone
e20eac089f win_updates shouldn't install hidden updates 2016-12-08 11:34:03 -05:00
Hans-Joachim Kliemeck
e3d8facc7f fixxed tests 2016-12-08 11:34:02 -05:00
Hans-Joachim Kliemeck
c82d72e12a fixed problems related to userpricincipalname (user@domain) and undefined variables fixed variable capitalization 2016-12-08 11:34:02 -05:00
Hans-Joachim Kliemeck
186197397c fixxed problem with match @ 2016-12-08 11:34:02 -05:00
Hans-Joachim Kliemeck
9ba30d2cea only call set-acl if necessary 2016-12-08 11:34:02 -05:00
Hans-Joachim Kliemeck
700ca56c61 as suggested by @marcind, convert to boolean 2016-12-08 11:34:02 -05:00
Hans-Joachim Kliemeck
404483ea83 fixed documentation 2016-12-08 11:34:02 -05:00
Hans-Joachim Kliemeck
de4a271dd0 added userprincipal support 2016-12-08 11:34:02 -05:00
Hans-Joachim Kliemeck
65d5658553 added separate module to change owner, since win_acl is ACL only and should not be more complex 2016-12-08 11:34:02 -05:00
Tyler Cross
c84bd72496 Add note server 2012 note to win_scheduled_task.
This change adds a note to the win_scheduled_task module
docs that indicates Windows Server 2012 or later is required.
This is because the module relies on the Get-ScheduledTask
cmdlet, which is a part of the Server 2012 OS. Previous
versions, like Server 2008, simply can't work with this
module.
2016-12-08 11:34:00 -05:00