Allowing uppercase tags in proxmox & proxmox_kvm (#10024)
* Allowing uppercase tags in proxmox & proxmox_kvm
* Fix#9895 : fixes the 'not a valid tag' error message when the VM or container tag contains uppercase characters
* Add PR URL to changelog fragment.
---------
Co-authored-by: s1githug <sgithug@free.fr>
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit ce421dbd7d)
Co-authored-by: s1github <sgithub@free.fr>
fix: github_deploy_key check key exists on 422 (#10011)
* fix: github_deploy_key check key exists on 422
If we get a 422 response code as we add a key, check if it's because the key already exists or for another reason.
fixes: #6718
* chore: add changelog 10011-github_deploy_key-check-key-present
* chore: fix changelog fragment
* chore: fix changelog fragment
* Update changelog fragment.
---------
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit c248073079)
Co-authored-by: Alex Garel <alex@garel.org>
Homebrew: Emit a useful error message if brew info reports a package tap is null. (#10013)
* Fix#10012.
Homebrew: Emit a useful error message if a package tap is null. This can happen if an installed package is subsequently removed from the tap (e.g. it is withdrawn by homebrew).
* Added changelogs fragment for PR 10013
* Do not raise error when tap is null in package_detail
pylint: remove trailing whitespace
* Minor: Update plugins/modules/homebrew.py
Co-authored-by: Felix Fontein <felix@fontein.de>
* Minor: Update changelogs/fragments/10012-improve-error-handling-homebrew-missing-tap.yml
Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
* Update plugins/modules/homebrew.py
Co-authored-by: Felix Fontein <felix@fontein.de>
---------
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
(cherry picked from commit 4b9373f694)
Co-authored-by: brad2014 <brad2014@users.noreply.github.com>
param pkcs12_alias and cert_alias to be optional in java_cert module (#9970)
* changed pkcs12_alias and cert_alias to be optional when importing pkcs12 certificate in keystore
* Add changelog fragment
* Update changelogs/fragments/9970-pkcs12_alias_cert_alias_optional.yml
Co-authored-by: Felix Fontein <felix@fontein.de>
* Update changelogs/fragments/9970-pkcs12_alias_cert_alias_optional.yml
Co-authored-by: Felix Fontein <felix@fontein.de>
---------
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 42a161abf5)
Co-authored-by: Emanuele Bernardi <e.berna@gmail.com>
Fix typo in rpm_ostree_pkg documentation example (#9999)
Fix typo in rpm_ostree_pkg examples
The example showing use of a delay to improve resiliency misspelled 'delay'
(cherry picked from commit 216e7dc06b)
Co-authored-by: Jeffrey Borcean <jjborcean@gmail.com>
allow gitlab-project-members module to handle user level "owner" (#9953)
* fix(modules/gitlab-project-members): fix ...
... module not being able to handle owner access level
* add changelog fragment for this pr
* fix and extend integration tests
* extend parameter docu as requested by review
* also add docu for other parameters
* remove pip install break-packages flag from ...
... integration tests
---------
Co-authored-by: Mirko Wilhelmi <Mirko.Wilhelmi@sma.de>
(cherry picked from commit 1157b7102f)
Co-authored-by: morco <thegreatwiper@web.de>
hpilo_boot: fix module failing when trying to power on an already powered-on server (#9646)
* fix: fix hpilo_boot.py module failing when trying to power on an already powered-on server
For this module to be idempotent, it should be successful when trying to reach a power state which is already there.
It was already the case for "poweroff", however when running the module with "boot_once" state, it was failing if the server was already powered_on, which is not an idempotent behavior
* doc: Add changelog fragment
* fix: add flag to run boot_once idempotently without breaking the previous behavior and add deprecation warning
* doc: fix documentation fragment description
* fix unwanted format changes
seems like I had an older version of this module formatted differently or that I had a formatter that automatically ran on this file
* fix linting errors
Removed trailing whitespace line 164
* add missing dash in idempotent_boot_once parameter description
* fix doc issue
* Update changelogs/fragments/9646-hpilo-fix-idempotency.yml
Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
* Update plugins/modules/hpilo_boot.py
Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
* Update changelogs/fragments/9646-hpilo-fix-idempotency.yml
Co-authored-by: Felix Fontein <felix@fontein.de>
* comment out module deprecation and change idempotent boot_once parameter description
* Update plugins/modules/hpilo_boot.py
* Update plugins/modules/hpilo_boot.py
Co-authored-by: Felix Fontein <felix@fontein.de>
---------
Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Ryan BADAÏ <ryan.badai@dbi-services.com>
(cherry picked from commit d7edd34ba4)
Co-authored-by: Ryan Badaï <43403063+ryanb74@users.noreply.github.com>
Unify TLS/SSL config for Redfish modules with new common argument spec and docs fragment; add validate_certs and ca_path options (#9964)
Unify TLS/SSL config for Redfish modules with new common argument spec and docs fragment.
(cherry picked from commit 1375cb65d6)
Co-authored-by: Felix Fontein <felix@fontein.de>
proxmox_disk: fail gracefully if storage hasn't been provided by the user (#9963)
Fail gracefully if storage hasn't been provided by the user.
(cherry picked from commit 34b6fb74eb)
Co-authored-by: Felix Fontein <felix@fontein.de>
Fix payload to match Rocket Chat 7.4.1 API (#9882)
* Fix payload to match Rocket Chat 7.4 API
* Add a fallback to send payload argument in case the user still interacts with a Rocket Chat version < 7.4.0
* Fix sanity checks
* Add changelog fragment of PR #9882
* Add argument option_is_pre740 to keep backward compatibility of the payload
* Add new argument doc
* Rename new parameter, add missing pieces of information in parameter doc
* Use appropriate change label and fix change description. Description about future plans for the parameter is now set at the parameter doc level
* Fix missing punctuation in the new parameter doc block
* Improve documentation.
* Fix line length.
---------
Co-authored-by: ludovic <ludovic.petetin@aleph-networks.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit c3b0354da0)
Co-authored-by: X <2465124+broferek@users.noreply.github.com>
The yarn module is Yarn Classic only at the moment (#9926)
The yarn module is Yarn Classic only.
(cherry picked from commit cb776e7cd5)
Co-authored-by: Felix Fontein <felix@fontein.de>
nmcli: fix reordering of DNS nameservers and search suffixes (#9880)
* nmcli: fix reordering of DNS nameservers and search suffixes
- Fixes#8724
* Update changelog fragment index in line with PR number
- Now I understand what that number is for
* Use correct changelog format for nmcli PR #9880
(cherry picked from commit 3922b82a57)
Co-authored-by: ashleyghooper <ashleyghooper@gmail.com>
Add caddy example to copr module (#9904)
Add caddy example to copr.py
(cherry picked from commit e3d92491a3)
Co-authored-by: Elijah Lopez <elijahllopezz@gmail.com>
systemd_info - extend support to timer unit (#9891)
* systemd_info - extend support to timer unit
* systemd_info - add changelogs fragments
* systemd_info - fix description and base_props
(cherry picked from commit 4a2cc71141)
Co-authored-by: Nocchia <133043574+NomakCooper@users.noreply.github.com>
Redfish: implement setting PowerRestorePolicy (#9837)
This property ("The desired power state of the system when power is
restored after a power loss.") was added in ComputerSystem.v1_6_0 which
became part of 2018.3 Redfish release.
Tested against an OpenBMC system running bmcweb Redfish server making sure the
policy is updated only when needed and that errors and messages are propogated
properly.
Signed-off-by: Paul Fertser <fercerpav@gmail.com>
(cherry picked from commit abe4e5ce95)
Co-authored-by: Paul Fertser <fercerpav@gmail.com>
add pacemaker_resource plugin (#9531)
* Add initial pacemaker resource
* Additional fixes on pacemaker_resource
* Fix up module parameters
* fix doc and lint
* fix group command build
* Apply suggestions for removing status and improve descriptions
* fix cmd builder list
* Apply suggestions and add initial unit tests
* Fix unit tests expected output
* Initial refactor on pacemaker resource
Refactorization on pacemaker_resource to utilize module helpers.
* Apply suggestions and fix up initial unit test
* Apply suggestions from code review
* Fix pep8 format for utils
* Fix unit tests for pacemaker resource
* Add botmeta maintainers for new moduules
* Apply suggestions from code review
Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
* Apply unit test suggestion
* Add disable and enable states for pacemaker_resource
* Fix state names and add cli_action for runner
* Remove unnecessary variables
* Fix documentation example playbook
* Fix IP Address for resource_option
* Refactor and remove unnecessary facts
* Apply suggestions from code review
---------
Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
(cherry picked from commit 402f725424)
Co-authored-by: Dexter <45038532+munchtoast@users.noreply.github.com>
Example typo in homebrew_services.py (#9819)
Maybe this was mixed up with the _brew_service_state() function? I get this error as-written:
```
fatal: [eahmm3]: FAILED! => {"changed": false, "msg": "Unsupported parameters for (community.general.homebrew_services) module: service
_state. Supported parameters include: name, path, state (formula)."}
```
(cherry picked from commit 5f48f2ca0d)
Co-authored-by: Ernie Hershey <github@ernie.org>
Redfish: implement obtaining PowerRestorePolicy (#9824) (#9824)
This property ("The desired power state of the system when power is
restored after a power loss.") was added in ComputerSystem.v1_6_0 which
became part of 2018.3 Redfish release.
Example result from querying OpenBMC's bmcweb Redfish server:
```
entries:
- - system_uri: /redfish/v1/Systems/system
- AlwaysOff
ret: true
```
Signed-off-by: Paul Fertser <fercerpav@gmail.com>
(cherry picked from commit 129f51cf9d)
Co-authored-by: Paul Fertser <fercerpav@gmail.com>
cloudflare_dns: handle exhausted response stream in case of http error (#9818)
* cloudflare_dns: handle exhausted response stream in case of http error
* Update changelogs/fragments/9818-cloudflare-dns-exhausted-response.yml
Co-authored-by: Felix Fontein <felix@fontein.de>
---------
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 3b6efd5cbc)
Co-authored-by: Kristian Heljas <11139388+kristianheljas@users.noreply.github.com>
proxmox: fix status getter (#9809)
* proxmox: fix status getter
get_lxc_status was missing a selection of the 'status' key
* proxmox: add changelog fragment
* proxmox: fix changelog fragment
(cherry picked from commit e39320c354)
Co-authored-by: JL Euler <Lithimlin@users.noreply.github.com>
keycloak_realm: remove realm id requirement (#9768)
* remove realm id requirement
* replace id with realm
* replace id with realm in documentation
* add changelog fragment
* Update changelogs/fragments/9768-keycloak_realm-remove-id-requirement.yaml
Co-authored-by: Felix Fontein <felix@fontein.de>
* Update changelogs/fragments/9768-keycloak_realm-remove-id-requirement.yaml
Co-authored-by: Felix Fontein <felix@fontein.de>
* add comment to get_realm_by_id
* Update plugins/module_utils/identity/keycloak/keycloak.py
Co-authored-by: Felix Fontein <felix@fontein.de>
---------
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 4c11902fdc)
Co-authored-by: gruenbauer@b1-systems.de <gruenbauer@b1-systems.de>
apache2_mod_proxy: big revamp (#9457)
* apache2_mod_proxy: big revamp
* fix case when state=null
* fix logic for change detection
(cherry picked from commit 98b328c539)
Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
lldp: Handling attributes that are defined multiple times (#9657)
* lldp: Ignoring values for keys already defined
This fixes crashes when the lldpctl output has lines for unknown tlvs that
redefine a key in the middle of the nested dict data structure.
* lldp: handling attributes that are defined multiple times
- Fix crash caused by certain lldpctl output where an attribute is defined as branch and leaf
- Adds multivalues parameter to control behavior when lldpctl outputs an attribute multiple times
* lldp: using isinstance instead of type
* Link to Github PR
Apply suggestions from code review
Co-authored-by: Felix Fontein <felix@fontein.de>
* lldp: only push value to subkey in multivalues mode
To provide backwards compatibility values that are defined as a
attribute and also as a path element are only pushed to the 'value'
subkey when using the new multivalues mode.
---------
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 2b6f4ba299)
Co-authored-by: Julian Wecke <julian@net23.de>
redhat_registration: use 'enable_content' D-Bus option when available (#9778)
This makes sure that subscription-manager always enables the content for
the system right after the registration.
This is particular important on EL 10+ and Fedora 41+.
(cherry picked from commit 203c1ecfec)
Co-authored-by: Pino Toscano <ptoscano@redhat.com>
apache2_mod_proxy: follow-up for #9762, forgot one place with find_all/findAll (#9775)
Follow-up for #9762, forgot one place.
(cherry picked from commit 8e36fd4847)
Co-authored-by: Felix Fontein <felix@fontein.de>
Make apache2_mod_proxy work with Python 3, half-way modern Apache 2 versions, and add basic tests (#9762)
* Move Apache 2 installation to setup role.
* Make module work with Python 3.
* Add basic tests.
* Add changelog fragment.
* Simplify change.
* Pass referer.
(cherry picked from commit a3fd357d81)
Co-authored-by: Felix Fontein <felix@fontein.de>
Jira: add SSL client certificate support for authentication (#9753)
* jira: add ssl client certificate support for authentification
* fix code bugs from first CI run
* fix fstring not compatible with older python and chhange urlopen module call
* removed duplicated post,put,get method
* fix urllib module detection Python2/ Python3
* edit HTTP Request back to fetch_url
* add changelog fragment
* fix python line spacing
* Update plugins/modules/jira.py
Co-authored-by: Felix Fontein <felix@fontein.de>
* Update plugins/modules/jira.py
Co-authored-by: Felix Fontein <felix@fontein.de>
* edit documentation certificate auth not mutually exclusive
* Update changelogs/fragments/9753-jira-add-client-certificate-auth.yml
Co-authored-by: Felix Fontein <felix@fontein.de>
* edit documentation for client certificate auth and token
* add no_log for client_cert and client_key
* removed no_log for client_cert and client_key
---------
Co-authored-by: domin <domin@MacBookPro.fritz.box>
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit fa7876bb40)
Co-authored-by: Dominik <47948163+weristdominik@users.noreply.github.com>
keycloak_client: compare desired and before dicts directly in checkmode (#9739)
* compare desired and before dicts directly in checkmode
* fix authorizationServicesEnabled being dropped by kc if unset
* only add authorizationsServicesEnabled=false if before_client exists
* add changelog fragment
* Update changelog.
---------
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit b2e2d2d37b)
Co-authored-by: gruenbauer@b1-systems.de <gruenbauer@b1-systems.de>
