mirror of
https://github.com/ansible-collections/community.general.git
synced 2025-07-22 04:40:22 -07:00
one_image/one_image_info: refactor (#8889)
* Refactor one_image * Refactor one_image_info * Add examples one_image * Add CHANGELOG fragment * Add integration tests for one_image * Add integration tests for one_image_info * Update one_image DOC * Update one_image_info DOC * Update one_image DOC * Update one_image_info DOC * Fix f-strings for one_image * Update CHANGELOG fragment * PR fixes * PR fixes
This commit is contained in:
alexander
GitHub
parent
e7ccbc2f18
commit
fea0ffa5aa
8 changed files with 1130 additions and 383 deletions
7
tests/integration/targets/one_image/aliases
Normal file
7
tests/integration/targets/one_image/aliases
Normal file
|
|
@ -0,0 +1,7 @@
|
|||
# Copyright (c) Ansible Project
|
||||
# GNU General Public License v3.0+ (see LICENSES/GPL-3.0-or-later.txt or https://www.gnu.org/licenses/gpl-3.0.txt)
|
||||
# SPDX-License-Identifier: GPL-3.0-or-later
|
||||
|
||||
azp/generic/1
|
||||
cloud/opennebula
|
||||
disabled # FIXME - when this is fixed, also re-enable the generic tests in CI!
|
||||
210
tests/integration/targets/one_image/tasks/main.yml
Normal file
210
tests/integration/targets/one_image/tasks/main.yml
Normal file
|
|
@ -0,0 +1,210 @@
|
|||
---
|
||||
####################################################################
|
||||
# WARNING: These are designed specifically for Ansible tests #
|
||||
# and should not be used as examples of how to write Ansible roles #
|
||||
####################################################################
|
||||
|
||||
# Copyright (c) Ansible Project
|
||||
# GNU General Public License v3.0+ (see LICENSES/GPL-3.0-or-later.txt or https://www.gnu.org/licenses/gpl-3.0.txt)
|
||||
# SPDX-License-Identifier: GPL-3.0-or-later
|
||||
|
||||
# Checks for existence
|
||||
- name: Make sure image is present by ID
|
||||
one_image:
|
||||
api_url: "{{ opennebula_url }}"
|
||||
api_username: "{{ opennebula_username }}"
|
||||
api_password: "{{ opennebula_password }}"
|
||||
id: 0
|
||||
state: present
|
||||
register: result
|
||||
|
||||
- name: Assert that image is present
|
||||
assert:
|
||||
that:
|
||||
- result is not changed
|
||||
|
||||
- name: Make sure image is present by ID
|
||||
one_image:
|
||||
api_url: "{{ opennebula_url }}"
|
||||
api_username: "{{ opennebula_username }}"
|
||||
api_password: "{{ opennebula_password }}"
|
||||
name: my_image
|
||||
state: present
|
||||
register: result
|
||||
|
||||
- name: Assert that image is present
|
||||
assert:
|
||||
that:
|
||||
- result is not changed
|
||||
|
||||
# Updating an image
|
||||
- name: Clone image without name
|
||||
one_image:
|
||||
api_url: "{{ opennebula_url }}"
|
||||
api_username: "{{ opennebula_username }}"
|
||||
api_password: "{{ opennebula_password }}"
|
||||
id: 0
|
||||
state: cloned
|
||||
register: result
|
||||
|
||||
- name: Assert that image is cloned
|
||||
assert:
|
||||
that:
|
||||
- result is changed
|
||||
|
||||
- name: Clone image with name
|
||||
one_image:
|
||||
api_url: "{{ opennebula_url }}"
|
||||
api_username: "{{ opennebula_username }}"
|
||||
api_password: "{{ opennebula_password }}"
|
||||
id: 0
|
||||
state: renamed
|
||||
new_name: new_image
|
||||
register: result
|
||||
|
||||
- name: Assert that image is cloned
|
||||
assert:
|
||||
that:
|
||||
- result is changed
|
||||
|
||||
- name: Disable image
|
||||
one_image:
|
||||
api_url: "{{ opennebula_url }}"
|
||||
api_username: "{{ opennebula_username }}"
|
||||
api_password: "{{ opennebula_password }}"
|
||||
id: 0
|
||||
enabled: false
|
||||
register: result
|
||||
|
||||
- name: Assert that network is disabled
|
||||
assert:
|
||||
that:
|
||||
- result is changed
|
||||
|
||||
- name: Enable image
|
||||
one_image:
|
||||
api_url: "{{ opennebula_url }}"
|
||||
api_username: "{{ opennebula_username }}"
|
||||
api_password: "{{ opennebula_password }}"
|
||||
id: 0
|
||||
enabled: true
|
||||
register: result
|
||||
|
||||
- name: Assert that network is enabled
|
||||
assert:
|
||||
that:
|
||||
- result is changed
|
||||
|
||||
- name: Make image persistent
|
||||
one_image:
|
||||
api_url: "{{ opennebula_url }}"
|
||||
api_username: "{{ opennebula_username }}"
|
||||
api_password: "{{ opennebula_password }}"
|
||||
id: 0
|
||||
persistent: true
|
||||
register: result
|
||||
|
||||
- name: Assert that network is persistent
|
||||
assert:
|
||||
that:
|
||||
- result is changed
|
||||
|
||||
- name: Make image non-persistent
|
||||
one_image:
|
||||
api_url: "{{ opennebula_url }}"
|
||||
api_username: "{{ opennebula_username }}"
|
||||
api_password: "{{ opennebula_password }}"
|
||||
id: 0
|
||||
persistent: false
|
||||
register: result
|
||||
|
||||
- name: Assert that network is non-persistent
|
||||
assert:
|
||||
that:
|
||||
- result is changed
|
||||
|
||||
# Testing idempotence using the same tasks
|
||||
- name: Make image non-persistent
|
||||
one_image:
|
||||
api_url: "{{ opennebula_url }}"
|
||||
api_username: "{{ opennebula_username }}"
|
||||
api_password: "{{ opennebula_password }}"
|
||||
id: 0
|
||||
persistent: false
|
||||
enabled: true
|
||||
register: result
|
||||
|
||||
- name: Assert that network not changed
|
||||
assert:
|
||||
that:
|
||||
- result is not changed
|
||||
|
||||
# Delete images
|
||||
- name: Deleting non-existing image
|
||||
one_image:
|
||||
api_url: "{{ opennebula_url }}"
|
||||
api_username: "{{ opennebula_username }}"
|
||||
api_password: "{{ opennebula_password }}"
|
||||
id: 228
|
||||
state: absent
|
||||
register: result
|
||||
|
||||
- name: Assert that network not changed
|
||||
assert:
|
||||
that:
|
||||
- result is not changed
|
||||
|
||||
- name: Delete an existing image
|
||||
one_image:
|
||||
api_url: "{{ opennebula_url }}"
|
||||
api_username: "{{ opennebula_username }}"
|
||||
api_password: "{{ opennebula_password }}"
|
||||
id: 0
|
||||
state: absent
|
||||
register: result
|
||||
|
||||
- name: Assert that image was deleted
|
||||
assert:
|
||||
that:
|
||||
- result is changed
|
||||
|
||||
# Trying to run with wrong arguments
|
||||
- name: Try to use name and ID at the same time
|
||||
one_image:
|
||||
api_url: "{{ opennebula_url }}"
|
||||
api_username: "{{ opennebula_username }}"
|
||||
api_password: "{{ opennebula_password }}"
|
||||
id: 0
|
||||
name: name
|
||||
register: result
|
||||
ignore_errors: true
|
||||
|
||||
- name: Assert that task failed
|
||||
assert:
|
||||
that:
|
||||
- result is failed
|
||||
|
||||
- name: Try to rename image without specifying new name
|
||||
one_image:
|
||||
api_url: "{{ opennebula_url }}"
|
||||
api_username: "{{ opennebula_username }}"
|
||||
api_password: "{{ opennebula_password }}"
|
||||
id: 0
|
||||
state: rename
|
||||
register: result
|
||||
ignore_errors: true
|
||||
|
||||
- name: Assert that task failed
|
||||
assert:
|
||||
that:
|
||||
- result is failed
|
||||
|
||||
- name: Try to rename image without specifying new name
|
||||
one_image:
|
||||
api_url: "{{ opennebula_url }}"
|
||||
api_username: "{{ opennebula_username }}"
|
||||
api_password: "{{ opennebula_password }}"
|
||||
id: 0
|
||||
state: rename
|
||||
register: result
|
||||
ignore_errors: true
|
||||
7
tests/integration/targets/one_image_info/aliases
Normal file
7
tests/integration/targets/one_image_info/aliases
Normal file
|
|
@ -0,0 +1,7 @@
|
|||
# Copyright (c) Ansible Project
|
||||
# GNU General Public License v3.0+ (see LICENSES/GPL-3.0-or-later.txt or https://www.gnu.org/licenses/gpl-3.0.txt)
|
||||
# SPDX-License-Identifier: GPL-3.0-or-later
|
||||
|
||||
azp/generic/1
|
||||
cloud/opennebula
|
||||
disabled # FIXME - when this is fixed, also re-enable the generic tests in CI!
|
||||
192
tests/integration/targets/one_image_info/tasks/main.yml
Normal file
192
tests/integration/targets/one_image_info/tasks/main.yml
Normal file
|
|
@ -0,0 +1,192 @@
|
|||
---
|
||||
####################################################################
|
||||
# WARNING: These are designed specifically for Ansible tests #
|
||||
# and should not be used as examples of how to write Ansible roles #
|
||||
####################################################################
|
||||
|
||||
# Copyright (c) Ansible Project
|
||||
# GNU General Public License v3.0+ (see LICENSES/GPL-3.0-or-later.txt or https://www.gnu.org/licenses/gpl-3.0.txt)
|
||||
# SPDX-License-Identifier: GPL-3.0-or-later
|
||||
|
||||
# Checks for existence
|
||||
- name: Get info by ID
|
||||
one_image_info:
|
||||
api_url: "{{ opennebula_url }}"
|
||||
api_username: "{{ opennebula_username }}"
|
||||
api_password: "{{ opennebula_password }}"
|
||||
id: 0
|
||||
register: result
|
||||
|
||||
- name: Assert that image is present
|
||||
assert:
|
||||
that:
|
||||
- result is not changed
|
||||
|
||||
- name: Get info by list of ID
|
||||
one_image_info:
|
||||
api_url: "{{ opennebula_url }}"
|
||||
api_username: "{{ opennebula_username }}"
|
||||
api_password: "{{ opennebula_password }}"
|
||||
ids:
|
||||
- 2
|
||||
- 2
|
||||
- 8
|
||||
register: result
|
||||
|
||||
- name: Assert that image is present
|
||||
assert:
|
||||
that:
|
||||
- result is not changed
|
||||
|
||||
- name: Get info by list of ID
|
||||
one_image_info:
|
||||
api_url: "{{ opennebula_url }}"
|
||||
api_username: "{{ opennebula_username }}"
|
||||
api_password: "{{ opennebula_password }}"
|
||||
name: somename
|
||||
register: result
|
||||
|
||||
- name: Assert that image is present
|
||||
assert:
|
||||
that:
|
||||
- result is not changed
|
||||
|
||||
- name: Gather all info
|
||||
one_image_info:
|
||||
api_url: "{{ opennebula_url }}"
|
||||
api_username: "{{ opennebula_username }}"
|
||||
api_password: "{{ opennebula_password }}"
|
||||
register: result
|
||||
|
||||
- name: Assert that images are present
|
||||
assert:
|
||||
that:
|
||||
- result is not changed
|
||||
|
||||
- name: Gather info by regex
|
||||
one_image_info:
|
||||
api_url: "{{ opennebula_url }}"
|
||||
api_username: "{{ opennebula_username }}"
|
||||
api_password: "{{ opennebula_password }}"
|
||||
name: '~my_image-[0-9].*'
|
||||
register: result
|
||||
|
||||
- name: Assert that images are present
|
||||
assert:
|
||||
that:
|
||||
- result is not changed
|
||||
|
||||
- name: Gather info by regex and ignore upper/lower cases
|
||||
one_image_info:
|
||||
api_url: "{{ opennebula_url }}"
|
||||
api_username: "{{ opennebula_username }}"
|
||||
api_password: "{{ opennebula_password }}"
|
||||
name: '~*my_image-[0-9].*'
|
||||
register: result
|
||||
|
||||
- name: Assert that images are present
|
||||
assert:
|
||||
that:
|
||||
- result is not changed
|
||||
|
||||
# Updating an image
|
||||
- name: Clone image without name
|
||||
one_image_info:
|
||||
api_url: "{{ opennebula_url }}"
|
||||
api_username: "{{ opennebula_username }}"
|
||||
api_password: "{{ opennebula_password }}"
|
||||
id: 0
|
||||
state: cloned
|
||||
register: result
|
||||
|
||||
- name: Assert that image is cloned
|
||||
assert:
|
||||
that:
|
||||
- result is changed
|
||||
|
||||
- name: Clone image with name
|
||||
one_image_info:
|
||||
api_url: "{{ opennebula_url }}"
|
||||
api_username: "{{ opennebula_username }}"
|
||||
api_password: "{{ opennebula_password }}"
|
||||
id: 0
|
||||
state: renamed
|
||||
new_name: new_image
|
||||
register: result
|
||||
|
||||
- name: Assert that image is cloned
|
||||
assert:
|
||||
that:
|
||||
- result is changed
|
||||
|
||||
- name: Disable image
|
||||
one_image_info:
|
||||
api_url: "{{ opennebula_url }}"
|
||||
api_username: "{{ opennebula_username }}"
|
||||
api_password: "{{ opennebula_password }}"
|
||||
id: 0
|
||||
enabled: false
|
||||
register: result
|
||||
|
||||
- name: Assert that network is disabled
|
||||
assert:
|
||||
that:
|
||||
- result is changed
|
||||
|
||||
- name: Enable image
|
||||
one_image_info:
|
||||
api_url: "{{ opennebula_url }}"
|
||||
api_username: "{{ opennebula_username }}"
|
||||
api_password: "{{ opennebula_password }}"
|
||||
id: 0
|
||||
enabled: true
|
||||
register: result
|
||||
|
||||
- name: Assert that network is enabled
|
||||
assert:
|
||||
that:
|
||||
- result is changed
|
||||
|
||||
- name: Make image persistent
|
||||
one_image_info:
|
||||
api_url: "{{ opennebula_url }}"
|
||||
api_username: "{{ opennebula_username }}"
|
||||
api_password: "{{ opennebula_password }}"
|
||||
id: 0
|
||||
persistent: true
|
||||
register: result
|
||||
|
||||
- name: Assert that network is persistent
|
||||
assert:
|
||||
that:
|
||||
- result is changed
|
||||
|
||||
- name: Make image non-persistent
|
||||
one_image_info:
|
||||
api_url: "{{ opennebula_url }}"
|
||||
api_username: "{{ opennebula_username }}"
|
||||
api_password: "{{ opennebula_password }}"
|
||||
id: 0
|
||||
persistent: false
|
||||
register: result
|
||||
|
||||
- name: Assert that network is non-persistent
|
||||
assert:
|
||||
that:
|
||||
- result is changed
|
||||
|
||||
# Testing errors
|
||||
- name: Try to use name and ID a the same time
|
||||
one_image_info:
|
||||
api_url: "{{ opennebula_url }}"
|
||||
api_username: "{{ opennebula_username }}"
|
||||
api_password: "{{ opennebula_password }}"
|
||||
id: 0
|
||||
name: somename
|
||||
register: result
|
||||
ignore_errors: true
|
||||
|
||||
- name: Assert that network not changed
|
||||
assert:
|
||||
that:
|
||||
- result is failed
|
||||
Loading…
Add table
Add a link
Reference in a new issue