docker_*: report more warnings (#53710)

* More warnings.

* Add changelog.

* Improve docstring.
This commit is contained in:
Felix Fontein 2019-03-14 10:55:16 +01:00 committed by John R Barker
parent 35e7fb776a
commit fbbab7429e
4 changed files with 20 additions and 2 deletions

View file

@ -496,7 +496,7 @@ class DockerNetworkManager(object):
if not self.check_mode:
resp = self.client.create_network(self.parameters.network_name, **params)
self.client.report_warnings(resp, ['Warning'])
self.existing_network = self.client.get_network(id=resp['Id'])
self.results['actions'].append("Created network %s with driver %s" % (self.parameters.network_name, self.parameters.driver))
self.results['changed'] = True

View file

@ -2255,10 +2255,13 @@ class DockerServiceManager(object):
name=name,
**service_data
)
# Unfortunately, docker-py f***ed up and doesn't return the structure
# the corresponding API call returns, which would include a list of warnings.
def create_service(self, name, service):
service_data = service.build_docker_service(self.get_networks_names_ids())
self.client.create_service(name=name, **service_data)
result = self.client.create_service(name=name, **service_data)
self.client.report_warnings(result, ['Warning'])
def remove_service(self, name):
self.client.remove_service(name)