Rename inconsistent azure_rm_virtualmachine_scaleset modules (#54579)

@yungezz yes, i remember. pls keep in mind that they are not broken
This commit is contained in:
Zim Kalinowski 2019-04-01 13:05:45 +08:00 committed by GitHub
commit f9877fca18
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
8 changed files with 45 additions and 30 deletions

View file

@ -0,0 +1 @@
azure_rm_virtualmachinescaleset.py

View file

@ -0,0 +1 @@
azure_rm_virtualmachinescaleset_facts.py

View file

@ -15,7 +15,7 @@ ANSIBLE_METADATA = {'metadata_version': '1.1',
DOCUMENTATION = '''
---
module: azure_rm_virtualmachine_scaleset
module: azure_rm_virtualmachinescaleset
version_added: "2.4"
@ -24,6 +24,9 @@ short_description: Manage Azure virtual machine scale sets.
description:
- Create and update a virtual machine scale set.
notes:
- This module was called C(azure_rm_virtualmachine_scaleset) before Ansible 2.8. The usage did not change.
options:
resource_group:
description:
@ -226,7 +229,7 @@ author:
EXAMPLES = '''
- name: Create VMSS
azure_rm_virtualmachine_scaleset:
azure_rm_virtualmachinescaleset:
resource_group: myResourceGroup
name: testvmss
vm_size: Standard_DS1_v2
@ -251,7 +254,7 @@ EXAMPLES = '''
managed_disk_type: Standard_LRS
- name: Create a VMSS with a custom image
azure_rm_virtualmachine_scaleset:
azure_rm_virtualmachinescaleset:
resource_group: myResourceGroup
name: testvmss
vm_size: Standard_DS1_v2
@ -264,7 +267,7 @@ EXAMPLES = '''
image: customimage001
- name: Create a VMSS with a custom image from a particular resource group
azure_rm_virtualmachine_scaleset:
azure_rm_virtualmachinescaleset:
resource_group: myResourceGroup
name: testvmss
vm_size: Standard_DS1_v2
@ -481,6 +484,9 @@ class AzureRMVirtualMachineScaleSet(AzureRMModuleBase):
for key in list(self.module_arg_spec.keys()) + ['tags']:
setattr(self, key, kwargs[key])
if self.module._name == 'azure_rm_virtualmachine_scaleset':
self.module.deprecate("The 'azure_rm_virtualmachine_scaleset' module has been renamed to 'azure_rm_virtualmachinescaleset'", version='2.12')
# make sure options are lower case
self.remove_on_absent = set([resource.lower() for resource in self.remove_on_absent])

View file

@ -13,7 +13,7 @@ ANSIBLE_METADATA = {'metadata_version': '1.1',
DOCUMENTATION = '''
---
module: azure_rm_virtualmachine_scaleset_facts
module: azure_rm_virtualmachinescaleset_facts
version_added: "2.4"
@ -22,6 +22,9 @@ short_description: Get Virtual Machine Scale Set facts
description:
- Get facts for a virtual machine scale set
notes:
- This module was called C(azure_rm_virtualmachine_scaleset_facts) before Ansible 2.8. The usage did not change.
options:
name:
description:
@ -36,7 +39,7 @@ options:
description:
- Format of the data returned.
- If C(raw) is selected information will be returned in raw format from Azure Python SDK.
- If C(curated) is selected the structure will be identical to input parameters of azure_rm_virtualmachine_scaleset module.
- If C(curated) is selected the structure will be identical to input parameters of azure_rm_virtualmachinescaleset module.
- In Ansible 2.5 and lower facts are always returned in raw format.
- Please note that this option will be deprecated in 2.10 when curated format will become the only supported format.
default: 'raw'
@ -54,17 +57,17 @@ author:
EXAMPLES = '''
- name: Get facts for a virtual machine scale set
azure_rm_virtualmachine_scaleset_facts:
azure_rm_virtualmachinescaleset_facts:
resource_group: myResourceGroup
name: testvmss001
format: curated
- name: Get facts for all virtual networks
azure_rm_virtualmachine_scaleset_facts:
azure_rm_virtualmachinescaleset_facts:
resource_group: myResourceGroup
- name: Get facts by tags
azure_rm_virtualmachine_scaleset_facts:
azure_rm_virtualmachinescaleset_facts:
resource_group: myResourceGroup
tags:
- testing
@ -289,6 +292,10 @@ class AzureRMVirtualMachineScaleSetFacts(AzureRMModuleBase):
for key in self.module_args:
setattr(self, key, kwargs[key])
if self.module._name == 'azure_rm_virtualmachine_scaleset_facts':
self.module.deprecate("The 'azure_rm_virtualmachine_scaleset_facts' module has been renamed to 'azure_rm_virtualmachinescaleset_facts'",
version='2.12')
if self.name and not self.resource_group:
self.fail("Parameter error: resource group required when filtering by name.")
if self.name: