From f9478c76189865d1544c9e250766694ccd719327 Mon Sep 17 00:00:00 2001 From: Michael Scherer Date: Sun, 16 Oct 2016 23:39:36 +0200 Subject: [PATCH] Make subversion module work on python 3 In python 3, filter return a iterator and so result in this traceback: Traceback (most recent call last): File \"/tmp/ansible_kzu72kz5/ansible_module_subversion.py\", line 264, in main() File \"/tmp/ansible_kzu72kz5/ansible_module_subversion.py\", line 243, in main local_mods = svn.has_local_mods() File \"/tmp/ansible_kzu72kz5/ansible_module_subversion.py\", line 178, in has_local_mods return len(filter(regex.match, lines)) > 0 TypeError: object of type 'filter' has no len() --- lib/ansible/modules/source_control/subversion.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ansible/modules/source_control/subversion.py b/lib/ansible/modules/source_control/subversion.py index 8940154c33..470779a7f2 100644 --- a/lib/ansible/modules/source_control/subversion.py +++ b/lib/ansible/modules/source_control/subversion.py @@ -175,7 +175,7 @@ class Subversion(object): # Match only revisioned files, i.e. ignore status '?'. regex = re.compile(r'^[^?X]') # Has local mods if more than 0 modified revisioned files. - return len(filter(regex.match, lines)) > 0 + return len(list(filter(regex.match, lines))) > 0 def needs_update(self): curr, url = self.get_revision()