ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-04-23 10:51:24 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

Guard against assignments that are not ast.Name in docs parsing (#35513)

Browse source
This commit is contained in:
Matt Martz 2018-01-30 12:56:16 -06:00 • committed by GitHub
parent ef34eb1a7d
commit f659cc5963
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/ansible/parsing/metadata.py
View file

@ -191,7 +191,7 @@ def extract_metadata(module_ast=None, module_data=None, offsets=False):
for root_idx, child in reversed(list(enumerate(module_ast.body))): for root_idx, child in reversed(list(enumerate(module_ast.body))):
if isinstance(child, ast.Assign): if isinstance(child, ast.Assign):
for target in child.targets: for target in child.targets:
if target.id == 'ANSIBLE_METADATA': if isinstance(target, ast.Name) and target.id == 'ANSIBLE_METADATA':
metadata = ast.literal_eval(child.value) metadata = ast.literal_eval(child.value)
if not offsets: if not offsets:
continue continue

3
test/sanity/validate-modules/main.py
View file

@ -753,6 +753,9 @@ class ModuleValidator(Validator):
for child in self.ast.body: for child in self.ast.body:
if isinstance(child, ast.Assign): if isinstance(child, ast.Assign):
for grandchild in child.targets: for grandchild in child.targets:
if not isinstance(grandchild, ast.Name):
continue
if grandchild.id == 'DOCUMENTATION': if grandchild.id == 'DOCUMENTATION':
docs['DOCUMENTATION']['value'] = child.value.s docs['DOCUMENTATION']['value'] = child.value.s
docs['DOCUMENTATION']['lineno'] = child.lineno docs['DOCUMENTATION']['lineno'] = child.lineno