ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-07-28 23:51:23 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

code-smell test changes

Browse source 
* Create get_exception and wildcard import code-smell tests
* Add more detail to boilerplate and no-basestring descriptions
* Remove the no-list-cmp test as the pylint undefined-variable test covers it
This commit is contained in:
Toshio Kuratomi 2017-08-01 16:18:27 -07:00
commit f4d7b9a596
9 changed files with 149 additions and 56 deletions
Download patch file Download diff file Expand all files Collapse all files

9
docs/docsite/rst/dev_guide/testing/sanity/no-basestring.rst
View file

@ -1,4 +1,11 @@
Sanity Tests » no-basestring
============================
Do not use ``isinstance(s, basestring)``.
Do not use ``isinstance(s, basestring)`` as basestring has been removed in
Python3. You can import ``string_types``, ``binary_type``, or ``text_type``
from ``ansible.module_utils.six`` and then use ``isinstance(s, string_types)``
or ``isinstance(s, (binary_type, text_type))`` instead.
If this is part of code to convert a string to a particular type,
``ansible.module_utils._text`` contains several functions that may be even
better for you: ``to_text``, ``to_bytes``, and ``to_native``.