ios test changes (#35510)

* Fix over-byte

* Update ios tests to call `provider`

To continue to support testing `connection: local`

* Fix command dict handling in ios_user

* Clean up unit tests, too

test/integration/targets/ios_config/tests/cli/backup.yaml

@@ -9,7 +9,7 @@
     parents:
       - interface Loopback999
     match: none
-    authorize: yes
+    provider: "{{ cli }}"
 
 - name: collect any backup files
   find:
@@ -28,7 +28,7 @@
   ios_config:
     src: basic/config.j2
     backup: yes
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 
 - assert:

test/integration/targets/ios_config/tests/cli/defaults.yaml

@@ -9,13 +9,13 @@
     parents:
       - interface Loopback999
     match: none
-    authorize: yes
+    provider: "{{ cli }}"
 
 - name: configure device with defaults included
   ios_config:
     src: defaults/config.j2
     defaults: yes
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 
 - debug: var=result
@@ -30,7 +30,7 @@
   ios_config:
     src: defaults/config.j2
     defaults: yes
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 
 - debug: var=result
@@ -44,14 +44,14 @@
   ios_config:
     lines:
         - mac-address-table notification mac-move
-    authorize: yes
+    provider: "{{ cli }}"
   ignore_errors: yes
 
 - name: show interfaces brief to ensure deivce goes to valid prompt
   ios_command:
     commands:
       - show interfaces
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 
 - assert:

test/integration/targets/ios_config/tests/cli/save.yaml

@@ -9,13 +9,13 @@
     parents:
       - interface Loopback999
     match: none
-    authorize: yes
+    provider: "{{ cli }}"
 
 
 - name: save config
   ios_config:
     save: true
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 # FIXME https://github.com/ansible/ansible-modules-core/issues/5008
   ignore_errors: true
@@ -29,7 +29,7 @@
 - name: save should always run
   ios_config:
     save: true
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 # FIXME https://github.com/ansible/ansible-modules-core/issues/5008
   ignore_errors: true
@@ -40,7 +40,7 @@
     lines:
       - "no ip http server"
     save_when: modified
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 
 - name: save should always run
@@ -49,7 +49,7 @@
     lines:
       - "ip http server"
     save_when: modified
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 
 - assert:
@@ -60,7 +60,7 @@
   ios_config:
     lines:
       - "no ip http server"
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 
 - debug: msg="END cli/save.yaml on connection={{ ansible_connection }}"

test/integration/targets/ios_config/tests/cli/src_basic.yaml

@@ -9,12 +9,12 @@
     parents:
       - interface Loopback999
     match: none
-    authorize: yes
+    provider: "{{ cli }}"
 
 - name: configure device with config
   ios_config:
     src: basic/config.j2
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 
 - name: debug, remove me
@@ -30,7 +30,7 @@
 - name: check device with config
   ios_config:
     src: basic/config.j2
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 
 - assert:

test/integration/targets/ios_config/tests/cli/src_invalid.yaml

@@ -6,7 +6,7 @@
 - name: configure with invalid src
   ios_config:
     src: basic/foobar.j2
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
   ignore_errors: yes
 

test/integration/targets/ios_config/tests/cli/src_match_none.yaml

@@ -9,13 +9,13 @@
     parents:
       - interface Loopback999
     match: none
-    authorize: yes
+    provider: "{{ cli }}"
 
 - name: configure device with config
   ios_config:
     src: basic/config.j2
     match: none
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 
 - assert:
@@ -28,7 +28,7 @@
 - name: check device with config
   ios_config:
     src: basic/config.j2
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 
 - assert:

test/integration/targets/ios_config/tests/cli/sublevel.yaml

@@ -7,13 +7,13 @@
       - 'no ip access-list extended test'
       - 'no ip access-list standard test'
     match: none
-    authorize: yes
+    provider: "{{ cli }}"
 
 - name: configure sub level command
   ios_config:
     lines: ['permit ip any any log']
     parents: ['ip access-list extended test']
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 
 - assert:
@@ -26,7 +26,7 @@
   ios_config:
     lines: ['permit ip any any log']
     parents: ['ip access-list extended test']
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 
 - assert:
@@ -38,6 +38,6 @@
     lines:
       - 'no ip access-list extended test'
     match: none
-    authorize: yes
+    provider: "{{ cli }}"
 
 - debug: msg="END cli/sublevel.yaml on connection={{ ansible_connection }}"

test/integration/targets/ios_config/tests/cli/sublevel_block.yaml

@@ -10,7 +10,7 @@
     parents: ['ip access-list extended test']
     before: ['no ip access-list extended test']
     after: ['exit']
-    authorize: yes
+    provider: "{{ cli }}"
     match: none
 
 - name: configure sub level command using block resplace
@@ -23,7 +23,7 @@
     parents: ['ip access-list extended test']
     replace: block
     after: ['exit']
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 
 - assert:
@@ -45,7 +45,7 @@
     parents: ['ip access-list extended test']
     replace: block
     after: ['exit']
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 
 - assert:
@@ -57,6 +57,6 @@
     lines:
       - no ip access-list extended test
     match: none
-    authorize: yes
+    provider: "{{ cli }}"
 
 - debug: msg="END cli/sublevel_block.yaml on connection={{ ansible_connection }}"

test/integration/targets/ios_config/tests/cli/sublevel_exact.yaml

@@ -13,7 +13,7 @@
     before: no ip access-list extended test
     after: exit
     match: none
-    authorize: yes
+    provider: "{{ cli }}"
 
 - name: configure sub level command using exact match
   ios_config:
@@ -26,7 +26,7 @@
     before: no ip access-list extended test
     after: exit
     match: exact
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 
 - assert:
@@ -48,7 +48,7 @@
       - permit ip host 4.4.4.4 any log
     parents: ip access-list extended test
     match: exact
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 
 - assert:
@@ -60,6 +60,6 @@
     lines:
       - no ip access-list extended test
     match: none
-    authorize: yes
+    provider: "{{ cli }}"
 
 - debug: msg="END cli/sublevel_exact.yaml on connection={{ ansible_connection }}"

test/integration/targets/ios_config/tests/cli/sublevel_strict.yaml

@@ -12,7 +12,7 @@
     parents: ip access-list extended test
     before: no ip access-list extended test
     match: none
-    authorize: yes
+    provider: "{{ cli }}"
 
 - name: configure sub level command using strict match
   ios_config:
@@ -23,7 +23,7 @@
       - permit ip host 4.4.4.4 any log
     parents: ip access-list extended test
     match: strict
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 
 - assert:
@@ -39,7 +39,7 @@
     parents: ip access-list extended test
     after: exit
     match: strict
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 
 - assert:
@@ -56,6 +56,6 @@
   ios_config:
     lines: no ip access-list extended test
     match: none
-    authorize: yes
+    provider: "{{ cli }}"
 
 - debug: msg="END cli/sublevel_strict.yaml on connection={{ ansible_connection }}"

test/integration/targets/ios_config/tests/cli/toplevel.yaml

@@ -5,12 +5,12 @@
   ios_config:
     lines: ['hostname {{ shorter_hostname }}']
     match: none
-    authorize: yes
+    provider: "{{ cli }}"
 
 - name: configure top level command
   ios_config:
     lines: ['hostname foo']
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 
 - assert:
@@ -21,7 +21,7 @@
 - name: configure top level command idempotent check
   ios_config:
     lines: ['hostname foo']
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 
 - assert:
@@ -32,6 +32,6 @@
   ios_config:
     lines: ['hostname {{ shorter_hostname }}']
     match: none
-    authorize: yes
+    provider: "{{ cli }}"
 
 - debug: msg="END cli/toplevel.yaml on connection={{ ansible_connection }}"

test/integration/targets/ios_config/tests/cli/toplevel_after.yaml

@@ -7,13 +7,13 @@
       - "snmp-server contact ansible"
       - "hostname {{ shorter_hostname }}"
     match: none
-    authorize: yes
+    provider: "{{ cli }}"
 
 - name: configure top level command with before
   ios_config:
     lines: ['hostname foo']
     after: ['snmp-server contact bar']
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 
 - assert:
@@ -26,7 +26,7 @@
   ios_config:
     lines: ['hostname foo']
     after: ['snmp-server contact foo']
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 
 - assert:
@@ -39,6 +39,6 @@
       - "no snmp-server contact"
       - "hostname {{ shorter_hostname }}"
     match: none
-    authorize: yes
+    provider: "{{ cli }}"
 
 - debug: msg="END cli/toplevel_after.yaml on connection={{ ansible_connection }}"

test/integration/targets/ios_config/tests/cli/toplevel_before.yaml

@@ -7,13 +7,13 @@
       - "snmp-server contact ansible"
       - "hostname {{ shorter_hostname }}"
     match: none
-    authorize: yes
+    provider: "{{ cli }}"
 
 - name: configure top level command with before
   ios_config:
     lines: ['hostname foo']
     before: ['snmp-server contact bar']
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 
 - assert:
@@ -26,7 +26,7 @@
   ios_config:
     lines: ['hostname foo']
     before: ['snmp-server contact foo']
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 
 - assert:
@@ -39,6 +39,6 @@
       - "no snmp-server contact"
       - "hostname {{ shorter_hostname }}"
     match: none
-    authorize: yes
+    provider: "{{ cli }}"
 
 - debug: msg="END cli/toplevel_before.yaml on connection={{ ansible_connection }}"

test/integration/targets/ios_config/tests/cli/toplevel_nonidempotent.yaml

@@ -5,13 +5,13 @@
   ios_config:
     lines: ['hostname {{ shorter_hostname }}']
     match: none
-    authorize: yes
+    provider: "{{ cli }}"
 
 - name: configure top level command
   ios_config:
     lines: ['hostname foo']
     match: strict
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 
 - assert:
@@ -23,7 +23,7 @@
   ios_config:
     lines: ['hostname foo']
     match: strict
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 
 - assert:
@@ -34,6 +34,6 @@
   ios_config:
     lines: ['hostname {{ shorter_hostname }}']
     match: none
-    authorize: yes
+    provider: "{{ cli }}"
 
 - debug: msg="END cli/toplevel_nonidempotent.yaml on connection={{ ansible_connection }}"