ios test changes (#35510)

* Fix over-byte

* Update ios tests to call `provider`

To continue to support testing `connection: local`

* Fix command dict handling in ios_user

* Clean up unit tests, too

test/integration/targets/ios_command/tests/cli/bad_operator.yaml

@@ -6,7 +6,7 @@
     commands:
       - show version
       - show interfaces GigabitEthernet 0/0
-    authorize: yes
+    provider: "{{ cli }}"
     wait_for:
       - "result[0] contains 'Description: Foo'"
   register: result

test/integration/targets/ios_command/tests/cli/contains.yaml

@@ -6,7 +6,7 @@
     commands:
       - show version
       - show interface loopback 888
-    authorize: yes
+    provider: "{{ cli }}"
     wait_for:
       - "result[0] contains Cisco"
       - "result[1] contains Loopback888"

test/integration/targets/ios_command/tests/cli/invalid.yaml

@@ -4,7 +4,7 @@
 - name: run invalid command
   ios_command:
     commands: show foo
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
   ignore_errors: yes
 
@@ -17,7 +17,7 @@
     commands:
       - show version
       - show foo
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
   ignore_errors: yes
 

test/integration/targets/ios_command/tests/cli/output.yaml

@@ -5,7 +5,7 @@
   ios_command:
     commands:
       - show version
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 
 - assert:
@@ -18,7 +18,7 @@
     commands:
       - show version
       - show interfaces
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 
 - assert:

test/integration/targets/ios_command/tests/cli/timeout.yaml

@@ -5,7 +5,7 @@
   ios_command:
     commands:
       - show version
-    authorize: yes
+    provider: "{{ cli }}"
     wait_for:
       - "result[0] contains bad_value_string"
   register: result