From 7b3dd55c3d6dbd5ca3d7d37276d8c43d2791eeed Mon Sep 17 00:00:00 2001 From: Rene Moser Date: Wed, 10 Jun 2015 17:28:45 +0200 Subject: [PATCH 1/4] cloudstack: remove unused methods used for backward compatibility --- lib/ansible/module_utils/cloudstack.py | 25 ------------------------- v1/ansible/module_utils/cloudstack.py | 25 ------------------------- 2 files changed, 50 deletions(-) diff --git a/lib/ansible/module_utils/cloudstack.py b/lib/ansible/module_utils/cloudstack.py index 86ccef588e..39e02107ff 100644 --- a/lib/ansible/module_utils/cloudstack.py +++ b/lib/ansible/module_utils/cloudstack.py @@ -111,11 +111,6 @@ class AnsibleCloudStack: return my_dict - # TODO: for backward compatibility only, remove if not used anymore - def get_project_id(self): - return self.get_project(key='id') - - def get_project(self, key=None): if self.project: return self._get_by_key(key, self.project) @@ -135,11 +130,6 @@ class AnsibleCloudStack: self.module.fail_json(msg="project '%s' not found" % project) - # TODO: for backward compatibility only, remove if not used anymore - def get_ip_address_id(self): - return self.get_ip_address(key='id') - - def get_ip_address(self, key=None): if self.ip_address: return self._get_by_key(key, self.ip_address) @@ -162,11 +152,6 @@ class AnsibleCloudStack: return self._get_by_key(key, self.ip_address) - # TODO: for backward compatibility only, remove if not used anymore - def get_vm_id(self): - return self.get_vm(key='id') - - def get_vm(self, key=None): if self.vm: return self._get_by_key(key, self.vm) @@ -189,11 +174,6 @@ class AnsibleCloudStack: self.module.fail_json(msg="Virtual machine '%s' not found" % vm) - # TODO: for backward compatibility only, remove if not used anymore - def get_zone_id(self): - return self.get_zone(key='id') - - def get_zone(self, key=None): if self.zone: return self._get_by_key(key, self.zone) @@ -214,11 +194,6 @@ class AnsibleCloudStack: self.module.fail_json(msg="zone '%s' not found" % zone) - # TODO: for backward compatibility only, remove if not used anymore - def get_os_type_id(self): - return self.get_os_type(key='id') - - def get_os_type(self, key=None): if self.os_type: return self._get_by_key(key, self.zone) diff --git a/v1/ansible/module_utils/cloudstack.py b/v1/ansible/module_utils/cloudstack.py index 2b4ec0be17..973ce24f8e 100644 --- a/v1/ansible/module_utils/cloudstack.py +++ b/v1/ansible/module_utils/cloudstack.py @@ -109,11 +109,6 @@ class AnsibleCloudStack: return my_dict - # TODO: for backward compatibility only, remove if not used anymore - def get_project_id(self): - return self.get_project(key='id') - - def get_project(self, key=None): if self.project: return self._get_by_key(key, self.project) @@ -133,11 +128,6 @@ class AnsibleCloudStack: self.module.fail_json(msg="project '%s' not found" % project) - # TODO: for backward compatibility only, remove if not used anymore - def get_ip_address_id(self): - return self.get_ip_address(key='id') - - def get_ip_address(self, key=None): if self.ip_address: return self._get_by_key(key, self.ip_address) @@ -160,11 +150,6 @@ class AnsibleCloudStack: return self._get_by_key(key, self.ip_address) - # TODO: for backward compatibility only, remove if not used anymore - def get_vm_id(self): - return self.get_vm(key='id') - - def get_vm(self, key=None): if self.vm: return self._get_by_key(key, self.vm) @@ -187,11 +172,6 @@ class AnsibleCloudStack: self.module.fail_json(msg="Virtual machine '%s' not found" % vm) - # TODO: for backward compatibility only, remove if not used anymore - def get_zone_id(self): - return self.get_zone(key='id') - - def get_zone(self, key=None): if self.zone: return self._get_by_key(key, self.zone) @@ -212,11 +192,6 @@ class AnsibleCloudStack: self.module.fail_json(msg="zone '%s' not found" % zone) - # TODO: for backward compatibility only, remove if not used anymore - def get_os_type_id(self): - return self.get_os_type(key='id') - - def get_os_type(self, key=None): if self.os_type: return self._get_by_key(key, self.zone) From 0b074c449b1c5c0483470a4df623232eb9682609 Mon Sep 17 00:00:00 2001 From: Rene Moser Date: Wed, 10 Jun 2015 17:31:46 +0200 Subject: [PATCH 2/4] cloudstack: methods renaming --- lib/ansible/module_utils/cloudstack.py | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/lib/ansible/module_utils/cloudstack.py b/lib/ansible/module_utils/cloudstack.py index 39e02107ff..13d4c59a01 100644 --- a/lib/ansible/module_utils/cloudstack.py +++ b/lib/ansible/module_utils/cloudstack.py @@ -77,8 +77,12 @@ class AnsibleCloudStack: else: self.cs = CloudStack(**read_config()) - # TODO: rename to has_changed() + # TODO: for backward compatibility only, remove if not used anymore def _has_changed(self, want_dict, current_dict, only_keys=None): + return self.has_changed(want_dict=want_dict, current_dict=current_dict, only_keys=only_keys) + + + def has_changed(self, want_dict, current_dict, only_keys=None): for key, value in want_dict.iteritems(): # Optionally limit by a list of keys @@ -336,8 +340,12 @@ class AnsibleCloudStack: return self._get_by_key(key, self.capabilities) - # TODO: rename to poll_job() + # TODO: for backward compatibility only, remove if not used anymore def _poll_job(self, job=None, key=None): + return self.poll_job(job=job, key=key) + + + def poll_job(self, job=None, key=None): if 'jobid' in job: while True: res = self.cs.queryAsyncJobResult(jobid=job['jobid']) From 6eb96c1a56fec6557becec8ba822eeeb708243ec Mon Sep 17 00:00:00 2001 From: Rene Moser Date: Wed, 10 Jun 2015 17:35:30 +0200 Subject: [PATCH 3/4] cloudstack: methods renaming --- v1/ansible/module_utils/cloudstack.py | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/v1/ansible/module_utils/cloudstack.py b/v1/ansible/module_utils/cloudstack.py index 973ce24f8e..ddb08e9f9c 100644 --- a/v1/ansible/module_utils/cloudstack.py +++ b/v1/ansible/module_utils/cloudstack.py @@ -75,8 +75,12 @@ class AnsibleCloudStack: else: self.cs = CloudStack(**read_config()) - # TODO: rename to has_changed() + # TODO: for backward compatibility only, remove if not used anymore def _has_changed(self, want_dict, current_dict, only_keys=None): + return self.has_changed(want_dict=want_dict, current_dict=current_dict, only_keys=only_keys) + + + def has_changed(self, want_dict, current_dict, only_keys=None): for key, value in want_dict.iteritems(): # Optionally limit by a list of keys @@ -334,8 +338,12 @@ class AnsibleCloudStack: return self._get_by_key(key, self.capabilities) - # TODO: rename to poll_job() + # TODO: for backward compatibility only, remove if not used anymore def _poll_job(self, job=None, key=None): + return self.poll_job(job=job, key=key) + + + def poll_job(self, job=None, key=None): if 'jobid' in job: while True: res = self.cs.queryAsyncJobResult(jobid=job['jobid']) From 034228f64b48077707871a1b008999d9290e8c76 Mon Sep 17 00:00:00 2001 From: Rene Moser Date: Wed, 10 Jun 2015 20:31:26 +0200 Subject: [PATCH 4/4] cloudstack: add missing api_timeout into v1 --- v1/ansible/module_utils/cloudstack.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/v1/ansible/module_utils/cloudstack.py b/v1/ansible/module_utils/cloudstack.py index ddb08e9f9c..13d4c59a01 100644 --- a/v1/ansible/module_utils/cloudstack.py +++ b/v1/ansible/module_utils/cloudstack.py @@ -64,12 +64,14 @@ class AnsibleCloudStack: api_secret = self.module.params.get('secret_key') api_url = self.module.params.get('api_url') api_http_method = self.module.params.get('api_http_method') + api_timeout = self.module.params.get('api_timeout') if api_key and api_secret and api_url: self.cs = CloudStack( endpoint=api_url, key=api_key, secret=api_secret, + timeout=api_timeout, method=api_http_method ) else: