From f0e26d0b769c77f7523826a66e17ad33f2742194 Mon Sep 17 00:00:00 2001 From: James Cammarata Date: Tue, 17 May 2016 14:06:10 -0400 Subject: [PATCH] In TQM run() mark any entries in _failed_hosts as failed in the PlayIterator As noted in the comment, the TQM may be used for more than one play. As such, after creating the new PlayIterator object it is necessary to mark any failed hosts from previous calls to run() as failed in the iterator, so they are properly skipped during any future calls to run(). --- lib/ansible/executor/task_queue_manager.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/lib/ansible/executor/task_queue_manager.py b/lib/ansible/executor/task_queue_manager.py index c2592f0f34..ba4970ed66 100644 --- a/lib/ansible/executor/task_queue_manager.py +++ b/lib/ansible/executor/task_queue_manager.py @@ -236,6 +236,13 @@ class TaskQueueManager: start_at_done = self._start_at_done, ) + # because the TQM may survive multiple play runs, we start by + # marking any hosts as failed in the iterator here which may + # have been marked as failed in previous runs. + for host_name in self._failed_hosts.keys(): + host = self._inventory.get_host(host_name) + iterator.mark_host_failed(host) + # during initialization, the PlayContext will clear the start_at_task # field to signal that a matching task was found, so check that here # and remember it so we don't try to skip tasks on future plays