From f09c2a10bcb7549fbd1ea90fe453da5b9a372134 Mon Sep 17 00:00:00 2001 From: mayabi Date: Sun, 30 Mar 2025 13:57:12 +0330 Subject: [PATCH] rollback --- plugins/modules/proxmox_backup_schedule.py | 9 ++++----- .../unit/plugins/modules/test_proxmox_backup_schedule.py | 7 +++++-- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/plugins/modules/proxmox_backup_schedule.py b/plugins/modules/proxmox_backup_schedule.py index 48a2d70d60..7a4c11acd0 100644 --- a/plugins/modules/proxmox_backup_schedule.py +++ b/plugins/modules/proxmox_backup_schedule.py @@ -246,14 +246,13 @@ def main(): vm_id = proxmox.vmname_2_vmid(vm_name) if state == 'present': - backup_schedule_result = proxmox.backup_present(vm_id, backup_id) + result['backup_schedule'] = proxmox.backup_present(vm_id, backup_id) if state == 'absent': - backup_schedule_result = proxmox.backup_absent(vm_id, backup_id) + result['backup_schedule'] = proxmox.backup_absent(vm_id, backup_id) - if backup_schedule_result: - result['changed'] = backup_schedule_result - result['vm_id'] = vm_id + if result['backup_schedule']: + result['changed'] = True result['message'] = 'The backup schedule has been changed successfully.' else: result['message'] = 'The backup schedule did not change anything.' diff --git a/tests/unit/plugins/modules/test_proxmox_backup_schedule.py b/tests/unit/plugins/modules/test_proxmox_backup_schedule.py index fad35b25b4..d130175ed2 100644 --- a/tests/unit/plugins/modules/test_proxmox_backup_schedule.py +++ b/tests/unit/plugins/modules/test_proxmox_backup_schedule.py @@ -158,6 +158,9 @@ BACKUP_JOBS = [ } ] +EXPECTED_UPDATE_BACKUP_SCHEDULE = True +EXPECTED_DEL_BACKUP_SCHEDULE = True + class TestProxmoxBackupScheduleModule(ModuleTestCase): def setUp(self): @@ -201,7 +204,7 @@ class TestProxmoxBackupScheduleModule(ModuleTestCase): result = exc_info.value.args[0] assert result['changed'] is True - assert result['vm_id'] == 105 + assert result['backup_schedule'] == EXPECTED_UPDATE_BACKUP_SCHEDULE def test_delete_vmid_from_backup(self): with pytest.raises(AnsibleExitJson) as exc_info: @@ -216,7 +219,7 @@ class TestProxmoxBackupScheduleModule(ModuleTestCase): result = exc_info.value.args[0] assert result['changed'] is True - assert result['vm_id'] == 101 + assert result['backup_schedule'] == EXPECTED_DEL_BACKUP_SCHEDULE if __name__ == '__main__':