ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-08-22 22:11:44 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

include_role handlers bug fix (#26335)

Browse source 
* Ensure that include_role properly fires handlers

include_role needs to ensure that any handlers included
with the role are added to the _notified_handler and
_listening_handler lists of the TaskQueueManager, otherwise
it fails when trying to run the handler.

Additionally, the handler needs to be added to the
PlayIterator's `_uuid_cache` or it fails after running
the handler

Add more uuid debug statements - this code was hard
to debug with existing debug statements, so add more
uuid information at little additional output cost.

Fixes #18411

* Add tests for include_role handlers

Tests for #18411
This commit is contained in:
Will Thames 2017-07-20 06:02:32 +10:00 • committed by James Cammarata
commit ef8c9798d3
13 changed files with 86 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

6
lib/ansible/executor/process/worker.py
View file

@ -118,7 +118,7 @@ class WorkerProcess(multiprocessing.Process):
self._rslt_q
).run()
display.debug("done running TaskExecutor() for %s/%s" % (self._host, self._task))
display.debug("done running TaskExecutor() for %s/%s [%s]" % (self._host, self._task, self._task._uuid))
self._host.vars = dict()
self._host.groups = []
task_result = TaskResult(
@ -129,9 +129,9 @@ class WorkerProcess(multiprocessing.Process):
)
# put the result on the result queue
display.debug("sending task result")
display.debug("sending task result for task %s" % self._task._uuid)
self._rslt_q.put(task_result)
display.debug("done sending task result")
display.debug("done sending task result for task %s" % self._task._uuid)
except AnsibleConnectionFailure:
self._host.vars = dict()