ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-05-03 07:41:30 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Use isinstance instead of type() comparisons. isinstance is more robust

Browse source
This commit is contained in:
Toshio Kuratomi 2017-02-16 15:47:09 -08:00
parent 2192c1eb02
commit eeaec56ed5
4 changed files with 5 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

6
lib/ansible/executor/stats.py
View file

@ -19,6 +19,8 @@
from __future__ import (absolute_import, division, print_function)
__metaclass__ = type
from collections import MutableMapping
from ansible.utils.vars import merge_hash
class AggregateStats:
@ -73,10 +75,10 @@ class AggregateStats:
return self.set_custom_stats(which, what, host)
# mismatching types
if type(what) != type(self.custom[host][which]):
if not isinstance(what, type(self.custom[host][which])):
return None
if isinstance(what, dict):
if isinstance(what, MutableMapping):
self.custom[host][which] = merge_hash(self.custom[host][which], what)
else:
# let overloaded + take care of other types