mirror of
https://github.com/ansible-collections/community.general.git
synced 2025-07-08 22:30:04 -07:00
pamd - fixed issue+minor refactorings (#3285)
* pamd - fixed issue+minor refactorings * added changelog fragment * added unit test suggested in issue * Update tests/integration/targets/pamd/tasks/main.yml * fixed per PR + additional adjustment Co-authored-by: Felix Fontein <felix@fontein.de>
This commit is contained in:
parent
2d6816e11e
commit
edd7b84285
4 changed files with 59 additions and 30 deletions
|
@ -5,11 +5,10 @@
|
|||
set_fact:
|
||||
test_pamd_file: "/tmp/pamd_file"
|
||||
|
||||
- name: Copy temporary pam.d file
|
||||
- name: Create temporary pam.d file
|
||||
copy:
|
||||
content: "session required pam_lastlog.so silent showfailed"
|
||||
dest: "{{ test_pamd_file }}"
|
||||
|
||||
- name: Test working on a single-line file works (2925)
|
||||
community.general.pamd:
|
||||
path: /tmp
|
||||
|
@ -20,17 +19,37 @@
|
|||
module_arguments: silent
|
||||
state: args_absent
|
||||
register: pamd_file_output
|
||||
|
||||
- name: Check if changes made
|
||||
assert:
|
||||
that:
|
||||
- pamd_file_output is changed
|
||||
|
||||
- name: Copy temporary pam.d file
|
||||
- name: Test removing all arguments from an entry (3260)
|
||||
community.general.pamd:
|
||||
path: /tmp
|
||||
name: pamd_file
|
||||
type: session
|
||||
control: required
|
||||
module_path: pam_lastlog.so
|
||||
module_arguments: ""
|
||||
state: updated
|
||||
register: pamd_file_output_noargs
|
||||
- name: Read back the file (3260)
|
||||
slurp:
|
||||
src: "{{ test_pamd_file }}"
|
||||
register: pamd_file_slurp_noargs
|
||||
- name: Check if changes made (3260)
|
||||
vars:
|
||||
line_array: "{{ (pamd_file_slurp_noargs.content|b64decode).split('\n')[2].split() }}"
|
||||
assert:
|
||||
that:
|
||||
- pamd_file_output_noargs is changed
|
||||
- line_array == ['session', 'required', 'pam_lastlog.so']
|
||||
|
||||
- name: Create temporary pam.d file
|
||||
copy:
|
||||
content: ""
|
||||
dest: "{{ test_pamd_file }}"
|
||||
|
||||
# This test merely demonstrates that, as-is, module will not perform any changes on an empty file
|
||||
# All the existing values for "state" will first search for a rule matching type, control, module_path
|
||||
# and will not perform any change whatsoever if no existing rules match.
|
||||
|
@ -43,12 +62,10 @@
|
|||
module_path: pam_lastlog.so
|
||||
module_arguments: silent
|
||||
register: pamd_file_output_empty
|
||||
|
||||
- name: Read back the file
|
||||
slurp:
|
||||
src: "{{ test_pamd_file }}"
|
||||
register: pamd_file_slurp
|
||||
|
||||
- name: Check if changes made
|
||||
assert:
|
||||
that:
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue