ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-10-06 16:34:02 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

[PR #10857/68684a7a backport][stable-10] github_deploy_key: make sure variable exists before use (#10859)
Some checks are pending
EOL CI / EOL Sanity (Ⓐ2.15) (push) Waiting to run
Details
EOL CI / EOL Units (Ⓐ2.15+py2.7) (push) Waiting to run
Details
EOL CI / EOL Units (Ⓐ2.15+py3.10) (push) Waiting to run
Details
EOL CI / EOL Units (Ⓐ2.15+py3.5) (push) Waiting to run
Details
EOL CI / EOL I (Ⓐ2.15+alpine3+py:azp/posix/1/) (push) Waiting to run
Details
EOL CI / EOL I (Ⓐ2.15+alpine3+py:azp/posix/2/) (push) Waiting to run
Details
EOL CI / EOL I (Ⓐ2.15+alpine3+py:azp/posix/3/) (push) Waiting to run
Details
EOL CI / EOL I (Ⓐ2.15+fedora37+py:azp/posix/1/) (push) Waiting to run
Details
EOL CI / EOL I (Ⓐ2.15+fedora37+py:azp/posix/2/) (push) Waiting to run
Details
EOL CI / EOL I (Ⓐ2.15+fedora37+py:azp/posix/3/) (push) Waiting to run
Details
nox / Run extra sanity tests (push) Waiting to run
Details

Browse source 
github_deploy_key: make sure variable exists before use (#10857)

Make sure variable exists before use.

(cherry picked from commit 68684a7a4c)

Co-authored-by: Felix Fontein <felix@fontein.de>
This commit is contained in:
patchback[bot] 2025-09-25 20:49:00 +02:00 • committed by GitHub
commit ebf5dd9007
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 4 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
changelogs/fragments/10857-github_deploy_key-err.yml Normal file
View file

@ -0,0 +1,2 @@
bugfixes:
- "github_deploy_key - fix bug during error handling if no body was present in the result (https://github.com/ansible-collections/community.general/issues/10853, https://github.com/ansible-collections/community.general/pull/10857)."

2
plugins/modules/github_deploy_key.py
View file

@ -284,6 +284,8 @@ class GithubDeployKey(object):
body = info.get('body') body = info.get('body')
if body: if body:
err = self.module.from_json(body)['message'] err = self.module.from_json(body)['message']
else:
err = None
if status_code == 401: if status_code == 401:
self.module.fail_json(msg="Failed to connect to {0} due to invalid credentials".format(self.github_url), http_status_code=status_code, error=err) self.module.fail_json(msg="Failed to connect to {0} due to invalid credentials".format(self.github_url), http_status_code=status_code, error=err)