Add junos_l2_interface module (#35123)

* Add junos_l2_interface module

*  Implementation for junos_l2_interface module
*  Integration test

* Fix CI issues

* Fix review comments
This commit is contained in:
Ganesh Nalawade 2018-01-22 20:38:07 +05:30 committed by GitHub
commit e8dd01fa5b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
9 changed files with 670 additions and 0 deletions

View file

@ -167,6 +167,15 @@
failed_modules: "{{ failed_modules }} + [ 'junos_vrf' ]"
test_failed: true
- block:
- include_role:
name: junos_l2_interface
when: "limit_to in ['*', 'junos_l2_interface']"
rescue:
- set_fact:
failed_modules: "{{ failed_modules }} + [ 'junos_l2_interface' ]"
test_failed: true
###########
- debug: var=failed_modules
when: test_failed

View file

@ -0,0 +1,2 @@
---
testcase: "*"

View file

@ -0,0 +1,2 @@
dependencies:
- prepare_junos_tests

View file

@ -0,0 +1,2 @@
---
- { include: netconf.yaml, tags: ['netconf'] }

View file

@ -0,0 +1,22 @@
---
- name: collect all netconf test cases
find:
paths: "{{ role_path }}/tests/netconf"
patterns: "{{ testcase }}.yaml"
connection: local
register: test_cases
- name: set test_items
set_fact: test_items="{{ test_cases.files | map(attribute='path') | list }}"
- name: run test case (connection=netconf)
include: "{{ test_case_to_run }} ansible_connection=netconf"
with_items: "{{ test_items }}"
loop_control:
loop_var: test_case_to_run
- name: run test case (connection=local)
include: "{{ test_case_to_run }} ansible_connection=local"
with_first_found: "{{ test_items }}"
loop_control:
loop_var: test_case_to_run

View file

@ -0,0 +1,311 @@
---
- debug: msg="START junos_l2_interface netconf/basic.yaml on connection={{ ansible_connection }}"
- name: setup - remove interface address
junos_l2_interface:
name: ge-0/0/1
state: absent
provider: "{{ netconf }}"
- name: setup - remove interface address
junos_l2_interface:
name: ge-0/0/2
state: absent
provider: "{{ netconf }}"
- name: Setup create vlans
junos_vlan:
vlan_id: "{{ item.vlan_id }}"
name: "{{ item.name }}"
state: present
provider: "{{ netconf }}"
with_items:
- { vlan_id: 100, name: red }
- { vlan_id: 200, name: blue }
- { vlan_id: 300, name: green }
- name: Configure interface in access mode
junos_l2_interface:
name: ge-0/0/1
description: test-interface-access
mode: access
access_vlan: red
active: True
state: present
provider: "{{ netconf }}"
register: result
- assert:
that:
- result.diff.prepared is search("\+ *ge-0/0/1")
- result.diff.prepared is search("\+ *description test-interface-access")
- result.diff.prepared is search("\+ *unit 0")
- result.diff.prepared is search("\+ *family ethernet-switching")
- result.diff.prepared is search("\+ *interface-mode access")
- result.diff.prepared is search("\+ *members red")
- name: Configure interface in access mode (idempotent)
junos_l2_interface:
name: ge-0/0/1
description: test-interface-access
mode: access
access_vlan: red
active: True
state: present
provider: "{{ netconf }}"
register: result
- assert:
that:
- "result.changed == false"
- name: Deactivate interface in access mode
junos_l2_interface:
name: ge-0/0/1
description: test-interface-access
mode: access
access_vlan: red
active: False
state: present
provider: "{{ netconf }}"
register: result
- assert:
that:
- "result.changed == true"
- result.diff.prepared is search("! *inactive[:] ge-0/0/1")
- result.diff.prepared is search("! *inactive[:] unit 0")
- result.diff.prepared is search("! *inactive[:] family ethernet-switching")
- result.diff.prepared is search("! *inactive[:] vlan")
- name: Activate interface in access mode
junos_l2_interface:
name: ge-0/0/1
description: test-interface-access
mode: access
access_vlan: red
active: True
state: present
provider: "{{ netconf }}"
register: result
- assert:
that:
- "result.changed == true"
- result.diff.prepared is search("! *active[:] ge-0/0/1")
- result.diff.prepared is search("! *active[:] unit 0")
- result.diff.prepared is search("! *active[:] family ethernet-switching")
- result.diff.prepared is search("! *active[:] vlan")
- name: Change interface to trunk mode
junos_l2_interface:
name: ge-0/0/1
description: test-interface-trunk
mode: trunk
trunk_vlans:
- blue
- green
native_vlan: 100
active: True
state: present
provider: "{{ netconf }}"
register: result
- assert:
that:
- 'result.changed == true'
- result.diff.prepared is search("\- *description test-interface-access")
- result.diff.prepared is search("\+ *description test-interface-trunk")
- result.diff.prepared is search("\+ *native-vlan-id 100")
- result.diff.prepared is search("\- *interface-mode access")
- result.diff.prepared is search("\+ *interface-mode trunk")
- result.diff.prepared is search("\- *members red")
- result.diff.prepared is search("\+ *members \[ blue green \]")
- name: Change interface to trunk mode (idempotent)
junos_l2_interface:
name: ge-0/0/1
description: test-interface-trunk
mode: trunk
trunk_vlans:
- blue
- green
native_vlan: 100
active: True
state: present
provider: "{{ netconf }}"
register: result
- assert:
that:
- "result.changed == false"
- name: Delete l2 interface
junos_l2_interface:
name: ge-0/0/1
description: test-interface-trunk
mode: trunk
trunk_vlans:
- blue
- green
native_vlan: 100
active: True
state: absent
provider: "{{ netconf }}"
register: result
- assert:
that:
- 'result.changed == true'
- result.diff.prepared is search("\- *description test-interface-trunk")
- result.diff.prepared is search("\- *native-vlan-id 100")
- result.diff.prepared is search("\- *unit 0")
- result.diff.prepared is search("\- *family ethernet-switching")
- result.diff.prepared is search("\- *interface-mode trunk")
- result.diff.prepared is search("\- *members \[ blue green \]")
- name: Delete l2 interface (idempotent)
junos_l2_interface:
name: ge-0/0/1
description: test-interface-trunk
mode: trunk
trunk_vlans:
- blue
- green
native_vlan: 100
active: True
state: absent
provider: "{{ netconf }}"
register: result
- assert:
that:
- "result.changed == false"
- name: Configure interface in access and trunk mode using aggregate
junos_l2_interface:
aggregate:
- name: ge-0/0/1
description: test-interface-access
mode: access
access_vlan: red
- name: ge-0/0/2
description: test-interface-trunk
mode: trunk
trunk_vlans:
- blue
- green
native_vlan: 100
active: True
state: present
provider: "{{ netconf }}"
register: result
- assert:
that:
- 'result.changed == true'
- result.diff.prepared is search("\+ *ge-0/0/1")
- result.diff.prepared is search("\+ *description test-interface-access")
- result.diff.prepared is search("\+ *unit 0")
- result.diff.prepared is search("\+ *family ethernet-switching")
- result.diff.prepared is search("\+ *interface-mode access")
- result.diff.prepared is search("\+ *members red")
- result.diff.prepared is search("\+ *ge-0/0/2")
- result.diff.prepared is search("\+ *description test-interface-trunk")
- result.diff.prepared is search("\+ *native-vlan-id 100")
- result.diff.prepared is search("\+ *interface-mode trunk")
- result.diff.prepared is search("\+ *members \[ blue green \]")
- name: Configure interface in access and trunk mode using aggregate (idempotent)
junos_l2_interface:
aggregate:
- name: ge-0/0/1
description: test-interface-access
mode: access
access_vlan: red
- name: ge-0/0/2
description: test-interface-trunk
mode: trunk
trunk_vlans:
- blue
- green
native_vlan: 100
active: True
state: present
provider: "{{ netconf }}"
register: result
- assert:
that:
- "result.changed == false"
- name: Delete interface in access and trunk mode using aggregate
junos_l2_interface:
aggregate:
- name: ge-0/0/1
description: test-interface-access
mode: access
access_vlan: red
- name: ge-0/0/2
description: test-interface-trunk
mode: trunk
trunk_vlans:
- blue
- green
native_vlan: 100
active: True
state: absent
provider: "{{ netconf }}"
register: result
- assert:
that:
- 'result.changed == true'
- result.diff.prepared is search("\- *ge-0/0/1")
- result.diff.prepared is search("\- *description test-interface-access")
- result.diff.prepared is search("\- *unit 0")
- result.diff.prepared is search("\- *family ethernet-switching")
- result.diff.prepared is search("\- *interface-mode access")
- result.diff.prepared is search("\- *members red")
- result.diff.prepared is search("\- *ge-0/0/2")
- result.diff.prepared is search("\- *description test-interface-trunk")
- result.diff.prepared is search("\- *native-vlan-id 100")
- result.diff.prepared is search("\- *interface-mode trunk")
- result.diff.prepared is search("\- *members \[ blue green \]")
- name: Delete interface in access and trunk mode using aggregate (idempotent)
junos_l2_interface:
aggregate:
- name: ge-0/0/1
description: test-interface-access
mode: access
access_vlan: red
- name: ge-0/0/2
description: test-interface-trunk
mode: trunk
trunk_vlans:
- blue
- green
native_vlan: 100
active: True
state: absent
provider: "{{ netconf }}"
register: result
- assert:
that:
- "result.changed == false"
- name: Teradown delete vlans
junos_vlan:
vlan_id: "{{ item.vlan_id }}"
name: "{{ item.name }}"
state: absent
provider: "{{ netconf }}"
with_items:
- { vlan_id: 100, name: red }
- { vlan_id: 200, name: blue }
- { vlan_id: 300, name: green }
- debug: msg="END junos_l2_interface netconf/basic.yaml on connection={{ ansible_connection }}"

View file

@ -0,0 +1,57 @@
---
- debug: msg="START junos netconf/net_l2_interface.yaml on connection={{ ansible_connection }}"
# Add minimal testcase to check args are passed correctly to
# implementation module and module run is successful.
- name: setup - remove interface address
net_l2_interface:
name: ge-0/0/1
state: absent
provider: "{{ netconf }}"
- name: Setup create vlan 100
junos_vlan:
vlan_id: 100
name: red
state: present
provider: "{{ netconf }}"
register: result
- name: Configure interface in access mode using platform agnostic module
net_l2_interface:
name: ge-0/0/1
description: l2 interface configured by Ansible
mode: access
access_vlan: red
active: True
state: present
provider: "{{ netconf }}"
register: result
- assert:
that:
- result.diff.prepared is search("\+ *ge-0/0/1")
- result.diff.prepared is search("\+ *description \"l2 interface configured by Ansible\"")
- result.diff.prepared is search("\+ *unit 0")
- result.diff.prepared is search("\+ *family ethernet-switching")
- result.diff.prepared is search("\+ *interface-mode access")
- result.diff.prepared is search("\+ *members red")
- name: teardown - remove interface address
net_l2_interface:
name: ge-0/0/1
state: absent
provider: "{{ netconf }}"
- name: teardown delete vlan 100
junos_vlan:
vlan_id: 100
name: red
state: absent
provider: "{{ netconf }}"
register: result
- debug: msg="END junos netconf/net_l3_interface.yaml on connection={{ ansible_connection }}"