ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-07-23 13:20:23 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Fixes multiple lgtm issues (#45629)

Browse source 
Most of the issues were just inclusions of code that were not used.
This cleans those up. Other alerts were semi-false-positives for now
This commit is contained in:
Tim Rupp 2018-09-13 15:26:17 -04:00 • committed by GitHub
commit e619052424
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
40 changed files with 255 additions and 239 deletions
Download patch file Download diff file Expand all files Collapse all files

28
lib/ansible/modules/network/f5/bigip_log_destination.py
View file

@ -362,21 +362,6 @@ class BaseManager(object):
def __init__(self, *args, **kwargs):
self.module = kwargs.get('module', None)
self.client = kwargs.get('client', None)
self.want = self.get_module_params(params=self.module.params)
self.have = self.get_api_params()
self.changes = self.get_usable_changes()
def get_usable_changes(self, params=None):
pass
def get_api_params(self, params=None):
pass
def get_module_params(self, params=None):
pass
def get_reportable_changes(self, params=None):
pass
def _set_changed_options(self):
changed = {}
@ -482,6 +467,13 @@ class V1Manager(BaseManager):
"""Manages remote-syslog settings
"""
def __init__(self, *args, **kwargs):
super(V1Manager, self).__init__(*args, **kwargs)
self.want = self.get_module_params(params=self.module.params)
self.have = self.get_api_params()
self.changes = self.get_usable_changes()
def _validate_creation_parameters(self):
if self.want.syslog_format is None:
self.want.update({'syslog_format': 'bsd-syslog'})
@ -560,6 +552,12 @@ class V2Manager(BaseManager):
"""Manages remote-high-speed-log settings
"""
def __init__(self, *args, **kwargs):
super(V2Manager, self).__init__(*args, **kwargs)
self.want = self.get_module_params(params=self.module.params)
self.have = self.get_api_params()
self.changes = self.get_usable_changes()
def get_reportable_changes(self, params=None):
if params:
return V2ReportableChanges(params=params)