ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-08-05 21:54:22 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

[PR #9255/9452a2c8 backport][stable-10] homebrew: fix incorrect handling of aliases (#9289)

Browse source 
homebrew: fix incorrect handling of aliases (#9255)

* Add failing test (See commit description)

Second assert returns this:

changed: [localhost] => changed=true
  changed_pkgs:
  - sqlite3
  msg: 'Changed: 1, Unchanged: 1'
  unchanged_pkgs:
  - sqlite

* Extract proper package_name from brew info using alisases

* Add changelog fragment

* Fix pep8

* Make sure sqlite is uninstalled beforehand

* Use `package_result is (not) changed` syntax in assertions

* Register more explicit names

* Fix handling of casks

(cherry picked from commit 9452a2c8ac)

Co-authored-by: Thibaut Decombe <68703331+UnknownPlatypus@users.noreply.github.com>
This commit is contained in:
patchback[bot] 2024-12-20 23:27:15 +01:00 • committed by GitHub
commit df5818282b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 83 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

8
tests/integration/targets/homebrew/tasks/casks.yml
View file

@ -55,7 +55,7 @@
- assert:
that:
- package_result.changed
- package_result is changed
- name: Again install {{ package_name }} package using homebrew
homebrew:
@ -68,7 +68,7 @@
- assert:
that:
- not package_result.changed
- package_result is not changed
- name: Uninstall {{ package_name }} package using homebrew
homebrew:
@ -81,7 +81,7 @@
- assert:
that:
- package_result.changed
- package_result is changed
- name: Again uninstall {{ package_name }} package using homebrew
homebrew:
@ -94,4 +94,4 @@
- assert:
that:
- not package_result.changed
- package_result is not changed