remove deprecated get_md5 from stat (#55659)

* remove deprecated get_md5 from stat

  fixes #55309

* removed get_md5 from tests involving stat

* keep get_md5 but hide it

* rst it

* ammended comment

* ws

* added ignore for hidden md5

lib/ansible/modules/files/stat.py

@@ -29,17 +29,6 @@ options:
       - Whether to follow symlinks.
     type: bool
     default: no
-  get_md5:
-    description:
-      - Whether to return the md5 sum of the file.
-      - Will return None if not a regular file or if we're
-        unable to use md5 (Common for FIPS-140 compliant systems).
-      - The default of this option changed from C(yes) to C(no) in Ansible 2.5
-        and will be removed altogether in Ansible 2.9.
-      - Use C(get_checksum=true) with C(checksum_algorithm=md5) to return an
-        md5 hash under the C(checksum) return value.
-    type: bool
-    default: no
   get_checksum:
     description:
       - Whether to return a checksum of the file.
@@ -444,7 +433,7 @@ def main():
         argument_spec=dict(
             path=dict(type='path', required=True),
             follow=dict(type='bool', default=False),
-            get_md5=dict(type='bool'),
+            get_md5=dict(type='bool', default=False),
             get_checksum=dict(type='bool', default=True),
             get_mime=dict(type='bool', default=True, aliases=['mime', 'mime_type', 'mime-type']),
             get_attributes=dict(type='bool', default=True, aliases=['attr', 'attributes']),
@@ -460,18 +449,13 @@ def main():
     follow = module.params.get('follow')
     get_mime = module.params.get('get_mime')
     get_attr = module.params.get('get_attributes')
-    get_md5 = module.params.get('get_md5')
-
-    # get_md5 will be an undocumented option in 2.9 to be removed at a later
-    # date if possible (3.0+)
-    if get_md5:
-        module.deprecate("get_md5 has been deprecated along with the md5 return value, use "
-                         "get_checksum=True and checksum_algorithm=md5 instead", 2.9)
-    else:
-        get_md5 = False
     get_checksum = module.params.get('get_checksum')
     checksum_algorithm = module.params.get('checksum_algorithm')
 
+    # NOTE: undocumented option since 2.9 to be removed at a later date if possible (3.0+)
+    # no real reason for keeping other than fear we may break older content.
+    get_md5 = module.params.get('get_md5')
+
     # main stat data
     try:
         if follow:
@@ -511,6 +495,8 @@ def main():
 
     # checksums
     if output.get('isreg') and output.get('readable'):
+
+        # NOTE: see above about get_md5
         if get_md5:
             # Will fail on FIPS-140 compliant systems
             try: