ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-07-09 14:50:02 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

Tidy up all pylint:blacklisted-name ignore lines (#1819) (#1839)

Browse source 
* fixed validation-modules for plugins/callback/hipchat.py

* fixed validation-modules for plugins/connection/lxc.py

* fixed validation-modules for plugins/modules/cloud/lxc/lxc_container.py

* fixed validation-modules for plugins/modules/monitoring/statusio_maintenance.py

* fixed validation-modules for plugins/modules/system/alternatives.py

* fixed validation-modules for plugins/modules/system/beadm.py

* fixed validation-modules for plugins/modules/system/cronvar.py

* fixed validation-modules for plugins/modules/system/dconf.py

* fixed validation-modules for plugins/modules/system/interfaces_file.py

* fixed validation-modules for plugins/modules/system/java_cert.py

* fixed validation-modules for plugins/modules/system/lvg.py

* fixed validation-modules for plugins/modules/system/lvol.py

* fixed validation-modules for plugins/modules/system/parted.py

* fixed validation-modules for plugins/modules/system/timezone.py

* fixed validation-modules for plugins/modules/web_infrastructure/rundeck_acl_policy.py

* Tidy up all pylint:blacklisted-name sanity checks ignore lines

* Missed one in statusio_maintenace.py

* fixed validation-modules for plugins/modules/system/filesystem.py

* Missed one in gconftool2.py

* Missed one in alternatives.py

* Using dummies now

* fixed indentation

* Made all the changes about replacing _ with dummy

* Rollback bug fixed

* Rollback bug fixed, part II

* added changelog fragment

* Improved changelog frag message per PR

(cherry picked from commit 03b7b39424)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
This commit is contained in:
patchback[bot] 2021-02-16 08:46:20 +01:00 • committed by GitHub
parent a60f9bc78b
commit dd400e8c21
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
21 changed files with 69 additions and 104 deletions
Download patch file Download diff file Expand all files Collapse all files

17
tests/sanity/ignore-2.10.txt
View file

@ -1,5 +1,3 @@
plugins/callback/hipchat.py pylint:blacklisted-name
plugins/connection/lxc.py pylint:blacklisted-name
plugins/module_utils/cloud.py pylint:bad-option-value # a pylint test that is disabled was modified over time
plugins/module_utils/compat/ipaddress.py no-assert
plugins/module_utils/compat/ipaddress.py no-unicode-literals
@ -10,7 +8,6 @@ plugins/modules/cloud/linode/linode.py validate-modules:parameter-list-no-elemen
plugins/modules/cloud/linode/linode.py validate-modules:parameter-type-not-in-doc
plugins/modules/cloud/linode/linode.py validate-modules:undocumented-parameter
plugins/modules/cloud/linode/linode_v4.py validate-modules:parameter-list-no-elements
plugins/modules/cloud/lxc/lxc_container.py pylint:blacklisted-name
plugins/modules/cloud/lxc/lxc_container.py use-argspec-type-path
plugins/modules/cloud/lxc/lxc_container.py validate-modules:invalid-ansiblemodule-schema
plugins/modules/cloud/lxc/lxc_container.py validate-modules:use-run-command-not-popen
@ -178,7 +175,6 @@ plugins/modules/monitoring/logstash_plugin.py validate-modules:invalid-ansiblemo
plugins/modules/monitoring/sensu/sensu_check.py validate-modules:parameter-list-no-elements
plugins/modules/monitoring/sensu/sensu_client.py validate-modules:parameter-list-no-elements
plugins/modules/monitoring/sensu/sensu_handler.py validate-modules:parameter-list-no-elements
plugins/modules/monitoring/statusio_maintenance.py pylint:blacklisted-name
plugins/modules/net_tools/ldap/ldap_attr.py validate-modules:parameter-type-not-in-doc # This triggers when a parameter is undocumented
plugins/modules/net_tools/ldap/ldap_attr.py validate-modules:undocumented-parameter # Parameter removed but reason for removal is shown by custom code
plugins/modules/net_tools/ldap/ldap_entry.py validate-modules:doc-missing-type
@ -294,21 +290,10 @@ plugins/modules/storage/purestorage/purefa_facts.py validate-modules:parameter-l
plugins/modules/storage/purestorage/purefa_facts.py validate-modules:return-syntax-error
plugins/modules/storage/purestorage/purefb_facts.py validate-modules:parameter-list-no-elements
plugins/modules/storage/purestorage/purefb_facts.py validate-modules:return-syntax-error
plugins/modules/system/alternatives.py pylint:blacklisted-name
plugins/modules/system/beadm.py pylint:blacklisted-name
plugins/modules/system/cronvar.py pylint:blacklisted-name
plugins/modules/system/dconf.py pylint:blacklisted-name
plugins/modules/system/filesystem.py pylint:blacklisted-name
plugins/modules/system/gconftool2.py pylint:blacklisted-name
plugins/modules/system/gconftool2.py validate-modules:parameter-state-invalid-choice
plugins/modules/system/interfaces_file.py pylint:blacklisted-name
plugins/modules/system/iptables_state.py validate-modules:undocumented-parameter
plugins/modules/system/java_cert.py pylint:blacklisted-name
plugins/modules/system/launchd.py use-argspec-type-path # False positive
plugins/modules/system/lvg.py pylint:blacklisted-name
plugins/modules/system/lvol.py pylint:blacklisted-name
plugins/modules/system/osx_defaults.py validate-modules:parameter-state-invalid-choice
plugins/modules/system/parted.py pylint:blacklisted-name
plugins/modules/system/parted.py validate-modules:parameter-state-invalid-choice
plugins/modules/system/puppet.py use-argspec-type-path
plugins/modules/system/puppet.py validate-modules:doc-default-does-not-match-spec # show_diff is not documented
@ -319,11 +304,9 @@ plugins/modules/system/runit.py validate-modules:doc-default-does-not-match-spec
plugins/modules/system/runit.py validate-modules:parameter-type-not-in-doc
plugins/modules/system/runit.py validate-modules:undocumented-parameter
plugins/modules/system/ssh_config.py use-argspec-type-path # Required since module uses other methods to specify path
plugins/modules/system/timezone.py pylint:blacklisted-name
plugins/modules/system/xfconf.py validate-modules:parameter-state-invalid-choice
plugins/modules/system/xfconf.py validate-modules:return-syntax-error
plugins/modules/web_infrastructure/jenkins_plugin.py use-argspec-type-path
plugins/modules/web_infrastructure/rundeck_acl_policy.py pylint:blacklisted-name
tests/integration/targets/django_manage/files/base_test/simple_project/p1/manage.py compile-2.6 # django generated code
tests/integration/targets/django_manage/files/base_test/simple_project/p1/manage.py compile-2.7 # django generated code
tests/utils/shippable/check_matrix.py replace-urlopen

17
tests/sanity/ignore-2.11.txt
View file

@ -1,5 +1,3 @@
plugins/callback/hipchat.py pylint:blacklisted-name
plugins/connection/lxc.py pylint:blacklisted-name
plugins/module_utils/compat/ipaddress.py no-assert
plugins/module_utils/compat/ipaddress.py no-unicode-literals
plugins/module_utils/_mount.py future-import-boilerplate
@ -9,7 +7,6 @@ plugins/modules/cloud/linode/linode.py validate-modules:parameter-list-no-elemen
plugins/modules/cloud/linode/linode.py validate-modules:parameter-type-not-in-doc
plugins/modules/cloud/linode/linode.py validate-modules:undocumented-parameter
plugins/modules/cloud/linode/linode_v4.py validate-modules:parameter-list-no-elements
plugins/modules/cloud/lxc/lxc_container.py pylint:blacklisted-name
plugins/modules/cloud/lxc/lxc_container.py use-argspec-type-path
plugins/modules/cloud/lxc/lxc_container.py validate-modules:invalid-ansiblemodule-schema
plugins/modules/cloud/lxc/lxc_container.py validate-modules:use-run-command-not-popen
@ -177,7 +174,6 @@ plugins/modules/monitoring/logstash_plugin.py validate-modules:invalid-ansiblemo
plugins/modules/monitoring/sensu/sensu_check.py validate-modules:parameter-list-no-elements
plugins/modules/monitoring/sensu/sensu_client.py validate-modules:parameter-list-no-elements
plugins/modules/monitoring/sensu/sensu_handler.py validate-modules:parameter-list-no-elements
plugins/modules/monitoring/statusio_maintenance.py pylint:blacklisted-name
plugins/modules/net_tools/ldap/ldap_attr.py validate-modules:parameter-type-not-in-doc # This triggers when a parameter is undocumented
plugins/modules/net_tools/ldap/ldap_attr.py validate-modules:undocumented-parameter # Parameter removed but reason for removal is shown by custom code
plugins/modules/net_tools/ldap/ldap_entry.py validate-modules:doc-missing-type
@ -293,21 +289,10 @@ plugins/modules/storage/purestorage/purefa_facts.py validate-modules:parameter-l
plugins/modules/storage/purestorage/purefa_facts.py validate-modules:return-syntax-error
plugins/modules/storage/purestorage/purefb_facts.py validate-modules:parameter-list-no-elements
plugins/modules/storage/purestorage/purefb_facts.py validate-modules:return-syntax-error
plugins/modules/system/alternatives.py pylint:blacklisted-name
plugins/modules/system/beadm.py pylint:blacklisted-name
plugins/modules/system/cronvar.py pylint:blacklisted-name
plugins/modules/system/dconf.py pylint:blacklisted-name
plugins/modules/system/filesystem.py pylint:blacklisted-name
plugins/modules/system/gconftool2.py pylint:blacklisted-name
plugins/modules/system/gconftool2.py validate-modules:parameter-state-invalid-choice
plugins/modules/system/interfaces_file.py pylint:blacklisted-name
plugins/modules/system/iptables_state.py validate-modules:undocumented-parameter
plugins/modules/system/java_cert.py pylint:blacklisted-name
plugins/modules/system/launchd.py use-argspec-type-path # False positive
plugins/modules/system/lvg.py pylint:blacklisted-name
plugins/modules/system/lvol.py pylint:blacklisted-name
plugins/modules/system/osx_defaults.py validate-modules:parameter-state-invalid-choice
plugins/modules/system/parted.py pylint:blacklisted-name
plugins/modules/system/parted.py validate-modules:parameter-state-invalid-choice
plugins/modules/system/puppet.py use-argspec-type-path
plugins/modules/system/puppet.py validate-modules:doc-default-does-not-match-spec # show_diff is not documented
@ -318,11 +303,9 @@ plugins/modules/system/runit.py validate-modules:doc-default-does-not-match-spec
plugins/modules/system/runit.py validate-modules:parameter-type-not-in-doc
plugins/modules/system/runit.py validate-modules:undocumented-parameter
plugins/modules/system/ssh_config.py use-argspec-type-path # Required since module uses other methods to specify path
plugins/modules/system/timezone.py pylint:blacklisted-name
plugins/modules/system/xfconf.py validate-modules:parameter-state-invalid-choice
plugins/modules/system/xfconf.py validate-modules:return-syntax-error
plugins/modules/web_infrastructure/jenkins_plugin.py use-argspec-type-path
plugins/modules/web_infrastructure/rundeck_acl_policy.py pylint:blacklisted-name
tests/integration/targets/django_manage/files/base_test/simple_project/p1/manage.py compile-2.6 # django generated code
tests/integration/targets/django_manage/files/base_test/simple_project/p1/manage.py compile-2.7 # django generated code
tests/utils/shippable/check_matrix.py replace-urlopen

17
tests/sanity/ignore-2.9.txt
View file

@ -1,5 +1,3 @@
plugins/callback/hipchat.py pylint:blacklisted-name
plugins/connection/lxc.py pylint:blacklisted-name
plugins/module_utils/cloud.py pylint:bad-option-value # a pylint test that is disabled was modified over time
plugins/module_utils/compat/ipaddress.py no-assert
plugins/module_utils/compat/ipaddress.py no-unicode-literals
@ -7,7 +5,6 @@ plugins/module_utils/_mount.py future-import-boilerplate
plugins/module_utils/_mount.py metaclass-boilerplate
plugins/modules/cloud/linode/linode.py validate-modules:parameter-type-not-in-doc
plugins/modules/cloud/linode/linode.py validate-modules:undocumented-parameter
plugins/modules/cloud/lxc/lxc_container.py pylint:blacklisted-name
plugins/modules/cloud/lxc/lxc_container.py use-argspec-type-path
plugins/modules/cloud/lxc/lxc_container.py validate-modules:use-run-command-not-popen
plugins/modules/cloud/misc/helm.py validate-modules:deprecation-mismatch
@ -179,7 +176,6 @@ plugins/modules/files/iso_extract.py validate-modules:doc-default-does-not-match
plugins/modules/identity/opendj/opendj_backendprop.py validate-modules:doc-missing-type
plugins/modules/identity/opendj/opendj_backendprop.py validate-modules:parameter-type-not-in-doc
plugins/modules/monitoring/icinga2_host.py validate-modules:undocumented-parameter
plugins/modules/monitoring/statusio_maintenance.py pylint:blacklisted-name
plugins/modules/net_tools/ldap/ldap_attr.py validate-modules:deprecation-mismatch
plugins/modules/net_tools/ldap/ldap_attr.py validate-modules:invalid-documentation
plugins/modules/net_tools/ldap/ldap_attr.py validate-modules:parameter-type-not-in-doc
@ -286,19 +282,8 @@ plugins/modules/storage/purestorage/purefa_facts.py validate-modules:return-synt
plugins/modules/storage/purestorage/purefb_facts.py validate-modules:deprecation-mismatch
plugins/modules/storage/purestorage/purefb_facts.py validate-modules:invalid-documentation
plugins/modules/storage/purestorage/purefb_facts.py validate-modules:return-syntax-error
plugins/modules/system/alternatives.py pylint:blacklisted-name
plugins/modules/system/beadm.py pylint:blacklisted-name
plugins/modules/system/cronvar.py pylint:blacklisted-name
plugins/modules/system/dconf.py pylint:blacklisted-name
plugins/modules/system/filesystem.py pylint:blacklisted-name
plugins/modules/system/gconftool2.py pylint:blacklisted-name
plugins/modules/system/interfaces_file.py pylint:blacklisted-name
plugins/modules/system/iptables_state.py validate-modules:undocumented-parameter
plugins/modules/system/java_cert.py pylint:blacklisted-name
plugins/modules/system/launchd.py use-argspec-type-path # False positive
plugins/modules/system/lvg.py pylint:blacklisted-name
plugins/modules/system/lvol.py pylint:blacklisted-name
plugins/modules/system/parted.py pylint:blacklisted-name
plugins/modules/system/puppet.py use-argspec-type-path
plugins/modules/system/puppet.py validate-modules:parameter-invalid
plugins/modules/system/puppet.py validate-modules:parameter-type-not-in-doc
@ -307,12 +292,10 @@ plugins/modules/system/runit.py validate-modules:doc-default-does-not-match-spec
plugins/modules/system/runit.py validate-modules:parameter-type-not-in-doc
plugins/modules/system/runit.py validate-modules:undocumented-parameter
plugins/modules/system/ssh_config.py use-argspec-type-path # Required since module uses other methods to specify path
plugins/modules/system/timezone.py pylint:blacklisted-name
plugins/modules/system/xfconf.py validate-modules:return-syntax-error
plugins/modules/web_infrastructure/jenkins_plugin.py use-argspec-type-path
plugins/modules/web_infrastructure/nginx_status_facts.py validate-modules:deprecation-mismatch
plugins/modules/web_infrastructure/nginx_status_facts.py validate-modules:invalid-documentation
plugins/modules/web_infrastructure/rundeck_acl_policy.py pylint:blacklisted-name
tests/integration/targets/django_manage/files/base_test/simple_project/p1/manage.py compile-2.6 # django generated code
tests/integration/targets/django_manage/files/base_test/simple_project/p1/manage.py compile-2.7 # django generated code
tests/utils/shippable/check_matrix.py replace-urlopen