fix nxos_pim_interface issues (#35405)

* fix nxos_pim_interface issues

* add absent test for pim_interface

test/integration/targets/nxos_pim_interface/tests/common/sanity.yaml

@@ -33,22 +33,22 @@
     state: present
     provider: "{{ connection }}"
 
-- name: Configure nxos_pim_interface state absent
-  nxos_pim_interface:
-    interface: "{{ testint }}"
-    state: absent
-    provider: "{{ connection }}"
-
 - block:
-  - name: configure pim interface
-    nxos_pim_interface: &config
+  - name: Configure nxos_pim_interface state absent
+    nxos_pim_interface: &pimabsent
       interface: "{{ testint }}"
-      dr_prio: 10
-      hello_interval: 40
-      border: 'false'
-      neighbor_policy: 'ansible_policy'
-      neighbor_type: 'prefix'
-      state: present
+      state: absent
+      provider: "{{ connection }}"
+
+  - name: configure jp policy and type
+    nxos_pim_interface: &configjp
+      interface: "{{ testint }}"
+      jp_policy_in: JPIN
+      jp_policy_out: JPOUT
+      jp_type_in: routemap
+      jp_type_out: routemap
+      sparse: True
+      border: True
       provider: "{{ connection }}"
     register: result
 
@@ -57,31 +57,96 @@
         - "result.changed == true"
 
   - name: Check idempotence
-    nxos_pim_interface: *config
+    nxos_pim_interface: *configjp
     register: result
 
   - assert: &false
       that:
         - "result.changed == false"
 
-  - name: configure gp policy and type
-    nxos_pim_interface: &configjp
+  - name: configure neighbor policy and rm
+    nxos_pim_interface: &confignpr
       interface: "{{ testint }}"
-      jp_policy_in: JPIN
-      jp_policy_out: JPOUT
-      jp_type_in: routemap
-      jp_type_out: routemap
+      neighbor_policy: NPR
+      neighbor_type: routemap
       provider: "{{ connection }}"
     register: result
 
   - assert: *true
 
   - name: Check idempotence
-    nxos_pim_interface: *configjp
+    nxos_pim_interface: *confignpr
     register: result
 
   - assert: *false
 
+  - pause:
+      seconds: 5
+
+  - name: configure neighbor policy and prefix
+    nxos_pim_interface: &confignpp
+      interface: "{{ testint }}"
+      neighbor_policy: NPPF
+      neighbor_type: prefix
+      provider: "{{ connection }}"
+    register: result
+
+  - assert: *true
+
+  - name: Check idempotence
+    nxos_pim_interface: *confignpp
+    register: result
+
+  - assert: *false
+
+  - name: configure hello_auth_key
+    nxos_pim_interface: &confighak1
+      interface: "{{ testint }}"
+      hello_auth_key: password1
+      provider: "{{ connection }}"
+    register: result
+
+  - assert: *true
+
+  - name: configure pim other params
+    nxos_pim_interface: &configo
+      interface: "{{ testint }}"
+      dr_prio: 10
+      hello_interval: 40
+      sparse: True
+      border: True
+      state: present
+      provider: "{{ connection }}"
+    register: result
+
+  - assert: *true
+
+  - name: Check idempotence
+    nxos_pim_interface: *configo
+    register: result
+
+  - assert: *false
+
+  - name: configure negative
+    nxos_pim_interface: &configno
+      interface: "{{ testint }}"
+      sparse: False
+      border: False
+      state: present
+      provider: "{{ connection }}"
+    register: result
+
+  - assert: *true
+
+  - name: Check idempotence
+    nxos_pim_interface: *configno
+    register: result
+
+  - assert: *false
+
+  - pause:
+      seconds: 5
+
   - name: configure state default
     nxos_pim_interface: &configdefault
       interface: "{{ testint }}"
@@ -97,6 +162,34 @@
 
   - assert: *false
 
+  - name: configure border
+    nxos_pim_interface: &configb
+      interface: "{{ testint }}"
+      border: True
+      state: present
+      provider: "{{ connection }}"
+    register: result
+
+  - assert: *true
+
+  - name: Check idempotence
+    nxos_pim_interface: *configb
+    register: result
+
+  - assert: *false
+
+  - name: configure state absent
+    nxos_pim_interface: *pimabsent
+    register: result
+
+  - assert: *true
+
+  - name: Check idempotence
+    nxos_pim_interface: *pimabsent
+    register: result
+
+  - assert: *false
+
   always:
   - name: "Disable feature PIM"
     nxos_feature: *disable_feature

test/units/modules/network/nxos/test_nxos_pim_interface.py

@@ -70,7 +70,7 @@ class TestNxosIPInterfaceModule(TestNxosModule):
             changed=True,
             commands=[
                 'interface eth2/1', 'ip pim dr-priority 10', 'ip pim hello-interval 40000',
-                'ip pim sparse-mode', 'no ip pim border']
+                'ip pim sparse-mode']
         )
 
     def test_nxos_pim_interface_jp(self):
@@ -81,14 +81,14 @@ class TestNxosIPInterfaceModule(TestNxosModule):
         self.execute_module(
             changed=True,
             commands=['interface eth2/1', 'ip pim jp-policy JPOUT out',
-                      'ip pim jp-policy JPIN in', 'ip pim sparse-mode']
+                      'ip pim jp-policy JPIN in']
         )
 
     def test_nxos_pim_interface_default(self):
         set_module_args(dict(interface='eth2/1', state='default'))
         self.execute_module(
-            changed=True,
-            commands=['interface eth2/1', 'ip pim dr-priority 1', 'ip pim hello-interval 30000', 'no ip pim border']
+            changed=False,
+            commands=[]
         )
 
     def test_nxos_pim_interface_ip_absent(self):